Re: [PATCH v3 0/1] platform/x86: Introduce dasharo-acpi platform driver

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1996 bytes --]

On Fri, 28 Mar 2025, Michał Kopeć wrote:

> Introduce a driver for devices running Dasharo firmware. The driver
> supports thermal monitoring using a new ACPI interface in Dasharo. The
> initial version supports monitoring fan speeds, fan PWM duty cycles and
> system temperatures as well as determining which specific interfaces are
> implemented by firmware.
> 
> It has been tested on a NovaCustom laptop running pre-release Dasharo
> firmware, which implements fan and thermal monitoring for the CPU and
> the discrete GPU, if present.
> 
> Changes in v2:
> - Remove redundant copyright information
> - Turn dasharo_fill_* functions into single dasharo_fill_feature_caps
>   function
> - Code style fixes
> - Turn large if / else blocks into switch / case
> - Fix possible positive return values in hwmon read handler
> - Change while loops to for loops
> - Add local variable for data->sensors[data->sensors_count] in
>   dasharo_fill_feature_caps
> - Replace snprintf with scnprintf per Ilpo's review
> - Keep the "ok" path silent
> 
> Changes in V3:
> - Simplify dasharo_read_value_by_cap_idx arguments and rename to
>   dasharo_read_channel

Hi,

This doesn't address my comments to v2 which I sent today. Please give it 
a bit more time for people to review a version before sending a new one
as we're on different time zones etc. so latency is expected. And try to 
double check you've addressed all the comments before sending a new 
version.

This is not a sprint you have to finish in a week, you have plenty of time 
in this kernel cycle that has just started. :-)

> Michał Kopeć (1):
>   platform/x86: Introduce dasharo-acpi platform driver
> 
>  drivers/platform/x86/Kconfig        |  10 +
>  drivers/platform/x86/Makefile       |   3 +
>  drivers/platform/x86/dasharo-acpi.c | 375 ++++++++++++++++++++++++++++
>  3 files changed, 388 insertions(+)
>  create mode 100644 drivers/platform/x86/dasharo-acpi.c
> 
> 

-- 
 i.