Re: [PATCH 01/28] drm/amdgpu: enable legacy enforce isolation by default

["Christian König" <christian.koenig@amd.com>]

On 5/29/25 22:07, Alex Deucher wrote:
> Enable legacy enforce isolation (just serialize kernel
> GC submissions).  This way we can reset a ring and
> only affect the the process currently using that ring.
> This mirrors what windows does.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Yeah, that's exactly what I wanted to suggest after seeing that you wanted to do that per GFX IP version.

Reviewed-by: Christian König <christian.koenig@amd.com>

But we might run into complains if people used compute for background jobs for some reason.

Regards,
Christian.

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 72e41781afb06..ca882e3d95bb7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2148,9 +2148,7 @@ static int amdgpu_device_check_arguments(struct amdgpu_device *adev)
>  
>  	for (i = 0; i < MAX_XCP; i++) {
>  		switch (amdgpu_enforce_isolation) {
> -		case -1:
>  		case 0:
> -		default:
>  			/* disable */
>  			adev->enforce_isolation[i] = AMDGPU_ENFORCE_ISOLATION_DISABLE;
>  			break;
> @@ -2159,7 +2157,9 @@ static int amdgpu_device_check_arguments(struct amdgpu_device *adev)
>  			adev->enforce_isolation[i] =
>  				AMDGPU_ENFORCE_ISOLATION_ENABLE;
>  			break;
> +		case -1:
>  		case 2:
> +		default:
>  			/* enable legacy mode */
>  			adev->enforce_isolation[i] =
>  				AMDGPU_ENFORCE_ISOLATION_ENABLE_LEGACY;