From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 391DAC433E0 for ; Sat, 23 Jan 2021 12:34:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2D2922BE8 for ; Sat, 23 Jan 2021 12:34:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2D2922BE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2Q7wzAu4I776QX2hk0ggF6jL/7yLENjWMbarF9SvwZ8=; b=KC3q8S42u9fQT4dRWeQC5blKw mH/Cp7NjtDYrH4i/AYzio6KCx8z09SI0+uk6vKgk/Sn3t9aSnojPPI5SupAZCUjAQ105rn0hUbWLe KfTg+lbSCnUa216eGJ79WKQ314Hz6ZrOrwMKLwZWuOrf/ppYknsxeKh19RYlbXWGrmjm7jf8YgNI5 9wT/E79GoDMlZtj4LaGhoIPODXLFg0c1R3BTcrXz5LDF3gVhXKZBdVIawdEKdVZcnCAVGApSmo165 zCIDNJ/uZ6VRpuP0Pg7x5TX/xJA2Vw0HzQhRVFNviQrpubYNJ97zwNDPFZoACizZzKhfmMxZVsM9L 3L0ETQGPQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3I6A-0000lW-4N; Sat, 23 Jan 2021 12:33:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3I66-0000kj-7q for linux-arm-kernel@lists.infradead.org; Sat, 23 Jan 2021 12:32:59 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9591222BE8; Sat, 23 Jan 2021 12:32:55 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l3I61-009bUV-Lv; Sat, 23 Jan 2021 12:32:53 +0000 MIME-Version: 1.0 Date: Sat, 23 Jan 2021 12:32:53 +0000 From: Marc Zyngier To: Shameerali Kolothum Thodi Subject: Re: [PATCH] genirq/msi: Make sure early activation of all PCI MSIs In-Reply-To: References: <20210121110247.20320-1-shameerali.kolothum.thodi@huawei.com> <87o8hij83d.wl-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.10 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: shameerali.kolothum.thodi@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eric.auger@redhat.com, tglx@linutronix.de, linuxarm@openeuler.org, prime.zeng@hisilicon.com, wangzhou1@hisilicon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210123_073258_344428_BFD13170 X-CRM114-Status: GOOD ( 14.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linuxarm@openeuler.org, eric.auger@redhat.com, "Wangzhou \(B\)" , "Zengtao \(B\)" , tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU2hhbWVlciwKCk9uIDIwMjEtMDEtMjIgMDk6MjEsIFNoYW1lZXJhbGkgS29sb3RodW0gVGhv ZGkgd3JvdGU6Cj4gSGkgTWFyYywKPiAKClsuLi5dCgo+PiBJIGZpbmQgdGhpcyBwcmV0dHkgY29t cGxpY2F0ZWQsIGFuZCB0aGUgSSdkIGxpa2UgdG8gYXZvaWQgaW5qZWN0aW5nIAo+PiB0aGUgUENJ Cj4+IE1TSS12cy1NU0ktWCBjb25jZXB0IGluIHNvbWV0aGluZyB0aGF0IGlzIHN1cHBvc2VkIHRv IGJlIGJ1cy1hZ25vc3RpYy4KPiAKPiBBZ3JlZS4gVGhhdOKAmXMgbWFpbmx5IGJlY2F1c2UgSSB3 YXMgdmVyeSBza2VwdGljYWwoVEJILCB2ZXJ5IGxpbWl0ZWQgaW4KPiBteSBrbm93bGVkZ2UKPiBv biB0aGlzIG1zaSBjb3JlIGNvZGUpIGFib3V0IGNoYW5naW5nIHRoZSBNU0ktWCBhY3RpdmF0aW9u IGxvZ2ljIGhlcmUKPiBhbmQganVzdCB0aG91Z2h0Cj4gb2YgbGltaXRpbmcgdGhlIGltcGFjdCB0 byBNU0kgY2FzZSBhcyBhIGZpcnN0IGF0dGVtcHQuCj4gCj4+IFdoYXQncyB3cm9uZyB3aXRoIHRo ZSBmb2xsb3dpbmcgKHVudGVzdGVkKSBwYXRjaCwgd2hpY2ggbG9va3MgbXVjaCAKPj4gc2ltcGxl cj8KPiAKPiBZZXMsIGhhZCB0cmllZCB0aGlzIGFzIG9uZSBvZiB0aGUgZWFybHkgZml4LCBidXQg YXMgc2FpZCBhYm92ZSB3YXMgbm90Cj4gdmVyeSBzdXJlIG9mCj4gdGhlIGltcGFjdCBvbiBvdGhl ciBwbGF0Zm9ybXMuIFRlc3RlZCB0aGlzIGFnYWluIGFuZCBpdCB3b3Jrcy4KPiAKPiBQbGVhc2Ug c2VuZCBpdC4KCkFjdHVhbGx5LCB0aGVyZSBpcyBhIGJldHRlciB3YXksIHdoaWNoIGlzIHRvIGhh dmUgYSBwcm9wZXIgaXRlcmF0b3Igb24KdmVjdG9ycyBpbnN0ZWFkIG9mIGRlc2NyaXB0b3JzLiBX aXRoIHRoYXQgYW5kIGEgYml0IG9mIGNsZWFudXAsIHRoZQpwYXRjaFsxXSBsb29rcyBwcmV0dHkg bmVhdC4KClBsZWFzZSBnaXZlIGl0IGEgZ28uCgpUaGFua3MsCgogICAgICAgICBNLgoKWzFdIGh0 dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMTAxMjMxMjI3NTkuMTc4MTM1OS0xLW1hekBrZXJu ZWwub3JnCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNtZWxscyBmdW5ueS4uLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5521C433DB for ; Sat, 23 Jan 2021 12:33:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83D9222BE8 for ; Sat, 23 Jan 2021 12:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbhAWMdk (ORCPT ); Sat, 23 Jan 2021 07:33:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:41748 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbhAWMdg (ORCPT ); Sat, 23 Jan 2021 07:33:36 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9591222BE8; Sat, 23 Jan 2021 12:32:55 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l3I61-009bUV-Lv; Sat, 23 Jan 2021 12:32:53 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 23 Jan 2021 12:32:53 +0000 From: Marc Zyngier To: Shameerali Kolothum Thodi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eric.auger@redhat.com, tglx@linutronix.de, linuxarm@openeuler.org, "Zengtao (B)" , "Wangzhou (B)" Subject: Re: [PATCH] genirq/msi: Make sure early activation of all PCI MSIs In-Reply-To: References: <20210121110247.20320-1-shameerali.kolothum.thodi@huawei.com> <87o8hij83d.wl-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.10 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: shameerali.kolothum.thodi@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eric.auger@redhat.com, tglx@linutronix.de, linuxarm@openeuler.org, prime.zeng@hisilicon.com, wangzhou1@hisilicon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shameer, On 2021-01-22 09:21, Shameerali Kolothum Thodi wrote: > Hi Marc, > [...] >> I find this pretty complicated, and the I'd like to avoid injecting >> the PCI >> MSI-vs-MSI-X concept in something that is supposed to be bus-agnostic. > > Agree. That’s mainly because I was very skeptical(TBH, very limited in > my knowledge > on this msi core code) about changing the MSI-X activation logic here > and just thought > of limiting the impact to MSI case as a first attempt. > >> What's wrong with the following (untested) patch, which looks much >> simpler? > > Yes, had tried this as one of the early fix, but as said above was not > very sure of > the impact on other platforms. Tested this again and it works. > > Please send it. Actually, there is a better way, which is to have a proper iterator on vectors instead of descriptors. With that and a bit of cleanup, the patch[1] looks pretty neat. Please give it a go. Thanks, M. [1] https://lore.kernel.org/r/20210123122759.1781359-1-maz@kernel.org -- Jazz is not dead. It just smells funny...