From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Thu, 10 Jan 2013 12:53:16 +0100 Subject: [kvmarm] [PATCH v5.1 0/2] KVM: ARM: Rename =?UTF-8?Q?KVM=5FSET=5FDEVI?= =?UTF-8?Q?CE=5FADDRESS?= In-Reply-To: References: <1357769438.18196.5@snotra> <97E481BC-F14D-4866-B44B-878833CA81DC@suse.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 10 Jan 2013 10:17:09 +0000, Peter Maydell wrote: > On 9 January 2013 22:30, Alexander Graf wrote: >> In fact, in this particular case one could merge all of the patches >> except for the >> particular ioctl implementation and just give the respective addresses >> default >> values until there is an API to set them, similar to how we did things >> with PVR >> in the beginning. > > That's what we started with and we got review comments saying "yuck, > don't hard code this"... Even worse: hard-coding things breaks kvmtool (we do not emulate a vexpress and have a rather different memory map) and arm64 (the requirements on GIC mappings are different). So hard coding addresses is already unacceptable. M. -- Fast, cheap, reliable. Pick two. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [kvmarm] [PATCH v5.1 0/2] KVM: ARM: Rename =?UTF-8?Q?KVM=5FSET=5FDEVI?= =?UTF-8?Q?CE=5FADDRESS?= Date: Thu, 10 Jan 2013 12:53:16 +0100 Message-ID: References: <1357769438.18196.5@snotra> <97E481BC-F14D-4866-B44B-878833CA81DC@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Alexander Graf , Scott Wood , "kvm@vger.kernel.org list" , " " , " " To: Peter Maydell Return-path: Received: from inca-roads.misterjones.org ([213.251.177.50]:45628 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753786Ab3AJLxW (ORCPT ); Thu, 10 Jan 2013 06:53:22 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 10 Jan 2013 10:17:09 +0000, Peter Maydell wrote: > On 9 January 2013 22:30, Alexander Graf wrote: >> In fact, in this particular case one could merge all of the patches >> except for the >> particular ioctl implementation and just give the respective addresses >> default >> values until there is an API to set them, similar to how we did things >> with PVR >> in the beginning. > > That's what we started with and we got review comments saying "yuck, > don't hard code this"... Even worse: hard-coding things breaks kvmtool (we do not emulate a vexpress and have a rather different memory map) and arm64 (the requirements on GIC mappings are different). So hard coding addresses is already unacceptable. M. -- Fast, cheap, reliable. Pick two.