Re: [Buildroot] [PATCH] package/rtl8188eu: fix build failure on PowerPC

[Giulio Benetti <giulio.benetti@benettiengineering.com>]

Hi Luca,

On 28/11/22 10:55, Luca Ceresoli wrote:
> Hi Giulio,
> 
> On Sun, 27 Nov 2022 14:28:55 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> Add local patch(pending upstream[0]) to fix build failure with PowerPC due
>> to a package re-defition of get_ra() that is only defined in Linux PowerPC
>> implementation.
>>
>> [0]: https://github.com/lwfinger/rtl8188eu/pull/432
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/8bcb4d0adabc141ff8144f9e22bd549e3cd8858a/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   ...uild-failure-on-PowerPc-architecture.patch | 106 ++++++++++++++++++
>>   1 file changed, 106 insertions(+)
>>   create mode 100644 package/rtl8188eu/0001-Fix-build-failure-on-PowerPc-architecture.patch
>>
>> diff --git a/package/rtl8188eu/0001-Fix-build-failure-on-PowerPc-architecture.patch b/package/rtl8188eu/0001-Fix-build-failure-on-PowerPc-architecture.patch
>> new file mode 100644
>> index 0000000000..b16a312c7e
>> --- /dev/null
>> +++ b/package/rtl8188eu/0001-Fix-build-failure-on-PowerPc-architecture.patch
>> @@ -0,0 +1,106 @@
>> +From 2a91a721d634a2eca131628b5c9c028af20037af Mon Sep 17 00:00:00 2001
>> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> +Date: Sun, 27 Nov 2022 14:20:43 +0100
>> +Subject: [PATCH] Fix build failure on PowerPc architecture
>> +
>> +In PowerPc Linux only get_ra() exists[0] and conflicts with local get_ra()
>> +that has a completely different purpose. So let's rename local get_ra()
>> +to wifi_get_ra() to make it different from Linux's get_ra().
>> +
>> +[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/include/asm
>> +
>> +Upstream: https://github.com/lwfinger/rtl8188eu/pull/432
>> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> 
> Thank you!
> 
> I have posted some change request to the commit message on your patch
> for upstream, but the patch content itself looks good, so I guess for
> the Buildroot needs this is enough:

Unfortunately I've forgotten some code replacement on get_ra() that has
been pointed upstream. The maintainer answered quickly so at this point
I'd wait some day, if the patch is then merged I'll send a patch to
bump the version, otherwise a send a V2 of this patch with the local
patch.

Thank you!
Kind regards
-- 
Giulio Benetti
Benetti Engineering sas

> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot