From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>, David Ahern <dsahern@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next 1/2] rtnetlink: change rtnl_stats_dump() return value
Date: Mon, 6 May 2024 10:23:48 -0600 [thread overview]
Message-ID: <f1da8bb5-4668-40de-93cd-3a150d000365@kernel.org> (raw)
In-Reply-To: <CANn89iKPSp9_bZAZpFM4biEg7vFXxMmY2nQfEmTfLsiHGdBTxg@mail.gmail.com>
On 5/2/24 10:03 AM, Eric Dumazet wrote:
> On Thu, May 2, 2024 at 5:59 PM David Ahern <dsahern@kernel.org> wrote:
>>
>> On 5/2/24 5:37 AM, Eric Dumazet wrote:
>>> By returning 0 (or an error) instead of skb->len,
>>> we allow NLMSG_DONE to be appended to the current
>>> skb at the end of a dump, saving a couple of recvmsg()
>>> system calls.
>>
>> any concern that a patch similar to:
>> https://lore.kernel.org/netdev/20240411180202.399246-1-kuba@kernel.org/
>> will be needed again here?
>
> This has been discussed, Jakub answer was :
>
> https://lore.kernel.org/netdev/20240411115748.05faa636@kernel.org/
>
> So the plan is to change functions until a regression is reported.
>
As I commented in the past, it is more user friendly to add such
comments to a commit message so that when a regression occurs and a
bisect is done, the user hitting the regression sees the problem with an
obvious resolution.
next prev parent reply other threads:[~2024-05-06 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 11:37 [PATCH net-next 0/2] rtnetlink: rtnl_stats_dump() changes Eric Dumazet
2024-05-02 11:37 ` [PATCH net-next 1/2] rtnetlink: change rtnl_stats_dump() return value Eric Dumazet
2024-05-02 15:59 ` David Ahern
2024-05-02 16:03 ` Eric Dumazet
2024-05-06 16:23 ` David Ahern [this message]
2024-05-06 16:28 ` Eric Dumazet
2024-05-02 11:37 ` [PATCH net-next 2/2] rtnetlink: use for_each_netdev_dump() in rtnl_stats_dump() Eric Dumazet
2024-05-02 16:02 ` David Ahern
2024-05-03 22:20 ` [PATCH net-next 0/2] rtnetlink: rtnl_stats_dump() changes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1da8bb5-4668-40de-93cd-3a150d000365@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.