From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4241BC46CD4 for ; Thu, 28 Dec 2023 01:09:54 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rIeuF-0003Cy-GL; Thu, 28 Dec 2023 01:09:50 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rIeuE-0003Cs-FF for linux-f2fs-devel@lists.sourceforge.net; Thu, 28 Dec 2023 01:09:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e0Bv7bAD8YYlYvi/Mo+K3hlnUUbat0Tf3QVdNoDi7dc=; b=RP/dXuFlu0mGn7WhaqMUFQ7zTR /TWRVzlerznnoGhMOl6fV10LbjCdZ2ObL+gj5QshMPPxCOiqwBkyRxjiR3Zq3IIJ++bTfWN90uIER q+04H8iTPF7CAebntu5HXoLs6OhVukuOvrJFxtxqaqppgdo8PAshtC0J132ekF9cl8j0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=e0Bv7bAD8YYlYvi/Mo+K3hlnUUbat0Tf3QVdNoDi7dc=; b=GyeOwWUQEFo7GSvY4z0Xo/qnvg 2WnBHnhpyRJoVS5xPAlGdn6dfCbV1xOJN6Y1TiVRSSJkqrEGoguacLlOZqMxwZcftPrEmhkd4aK+2 IdUnIuW2wbO6u4dRTviYkM+V9YEnuCBwmp8Z89+Ulz7OrZ9KnKCpCzwlXV0D89jIxTOk=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rIeu9-0002ot-0z for linux-f2fs-devel@lists.sourceforge.net; Thu, 28 Dec 2023 01:09:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 938F560FC7; Thu, 28 Dec 2023 01:09:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A166EC433C8; Thu, 28 Dec 2023 01:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703725774; bh=VwYCv6gGPQ/YYWxYxWflWCiB/el4SBogmDzpvdiEhUA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=I5va7tQ8MTVS+c7ooSC2tg96OtVZYUxvtVGElOdTMeSxywXvk1j79HPZZ9JkI1BjX ylX7ra8UbxT0INljhybm6o24XgjCBukv7UfGitluAoPLDA0xrlgzZEmgCcZfKa1eRz PD/A2WdS9ro00mPmD8spoFdQnsVvpyRaupvLmeaGh+toAYlRUAXvAB7GmAdxOM9qya SkQz2vzdBrkbTU2UwfVPoS8qr9ext0gtrYhwUbUI86Wf0nelk1FBSF32bqYe2yfbAK nrh8Ou9OjNJOFl9acbT+eRy3Lrws3DpGCSUTDnPkKDsFWhn3jwtRM+wFeN9ImOKMFR T9jG00cu55QrQ== Message-ID: Date: Thu, 28 Dec 2023 09:09:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Eric Biggers , linux-fscrypt@vger.kernel.org References: <20231227171429.9223-1-ebiggers@kernel.org> <20231227171429.9223-2-ebiggers@kernel.org> From: Chao Yu In-Reply-To: <20231227171429.9223-2-ebiggers@kernel.org> X-Headers-End: 1rIeu9-0002ot-0z Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: move release of block devices to after kill_block_super() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , Josef Bacik Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2023/12/28 1:14, Eric Biggers wrote: > From: Eric Biggers > > Call destroy_device_list() and free the f2fs_sb_info from > kill_f2fs_super(), after the call to kill_block_super(). This is > necessary to order it after the call to fscrypt_destroy_keyring() once > generic_shutdown_super() starts calling fscrypt_destroy_keyring() just > after calling ->put_super. This is because fscrypt_destroy_keyring() > may call into f2fs_get_devices() via the fscrypt_operations. > > Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC6E1EA9; Thu, 28 Dec 2023 01:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I5va7tQ8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A166EC433C8; Thu, 28 Dec 2023 01:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703725774; bh=VwYCv6gGPQ/YYWxYxWflWCiB/el4SBogmDzpvdiEhUA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=I5va7tQ8MTVS+c7ooSC2tg96OtVZYUxvtVGElOdTMeSxywXvk1j79HPZZ9JkI1BjX ylX7ra8UbxT0INljhybm6o24XgjCBukv7UfGitluAoPLDA0xrlgzZEmgCcZfKa1eRz PD/A2WdS9ro00mPmD8spoFdQnsVvpyRaupvLmeaGh+toAYlRUAXvAB7GmAdxOM9qya SkQz2vzdBrkbTU2UwfVPoS8qr9ext0gtrYhwUbUI86Wf0nelk1FBSF32bqYe2yfbAK nrh8Ou9OjNJOFl9acbT+eRy3Lrws3DpGCSUTDnPkKDsFWhn3jwtRM+wFeN9ImOKMFR T9jG00cu55QrQ== Message-ID: Date: Thu, 28 Dec 2023 09:09:29 +0800 Precedence: bulk X-Mailing-List: linux-fscrypt@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: move release of block devices to after kill_block_super() Content-Language: en-US To: Eric Biggers , linux-fscrypt@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Josef Bacik , linux-f2fs-devel@lists.sourceforge.net References: <20231227171429.9223-1-ebiggers@kernel.org> <20231227171429.9223-2-ebiggers@kernel.org> From: Chao Yu In-Reply-To: <20231227171429.9223-2-ebiggers@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023/12/28 1:14, Eric Biggers wrote: > From: Eric Biggers > > Call destroy_device_list() and free the f2fs_sb_info from > kill_f2fs_super(), after the call to kill_block_super(). This is > necessary to order it after the call to fscrypt_destroy_keyring() once > generic_shutdown_super() starts calling fscrypt_destroy_keyring() just > after calling ->put_super. This is because fscrypt_destroy_keyring() > may call into f2fs_get_devices() via the fscrypt_operations. > > Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks,