From: Rik van Riel <riel@surriel.com>
To: Song Liu <songliubraving@fb.com>, linux-mm@kvack.org
Cc: matthew.wilcox@oracle.com, kirill.shutemov@linux.intel.com,
kernel-team@fb.com, william.kucharski@oracle.com,
akpm@linux-foundation.org
Subject: Re: [PATCH v3 2/6] filemap: update offset check in filemap_fault()
Date: Wed, 19 Jun 2019 21:04:50 -0400 [thread overview]
Message-ID: <f1e3473438cadb6a9677dbff892a1ed02ffdeb64.camel@surriel.com> (raw)
In-Reply-To: <20190619062424.3486524-3-songliubraving@fb.com>
[-- Attachment #1: Type: text/plain, Size: 383 bytes --]
On Tue, 2019-06-18 at 23:24 -0700, Song Liu wrote:
> With THP, current check of offset:
>
> VM_BUG_ON_PAGE(page->index != offset, page);
>
> is no longer accurate. Update it to:
>
> VM_BUG_ON_PAGE(page_to_pgoff(page) != offset, page);
>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Acked-by: Rik van Riel <riel@surriel.com>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-20 1:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 6:24 [PATCH v3 0/6] Enable THP for text section of non-shmem files Song Liu
2019-06-19 6:24 ` [PATCH v3 1/6] filemap: check compound_head(page)->mapping in filemap_fault() Song Liu
2019-06-19 6:24 ` [PATCH v3 2/6] filemap: update offset check " Song Liu
2019-06-20 1:04 ` Rik van Riel [this message]
2019-06-19 6:24 ` [PATCH v3 3/6] mm,thp: stats for file backed THP Song Liu
2019-06-19 6:24 ` [PATCH v3 4/6] khugepaged: rename collapse_shmem() and khugepaged_scan_shmem() Song Liu
2019-06-20 1:05 ` Rik van Riel
2019-06-19 6:24 ` [PATCH v3 5/6] mm,thp: add read-only THP support for (non-shmem) FS Song Liu
2019-06-19 6:24 ` [PATCH v3 6/6] mm,thp: handle writes to file with THP in pagecache Song Liu
2019-06-20 1:39 ` Rik van Riel
2019-06-20 2:10 ` Song Liu
2019-06-20 13:00 ` Rik van Riel
2019-06-20 13:55 ` William Kucharski
2019-06-19 6:51 ` [PATCH v3 0/6] Enable THP for text section of non-shmem files Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e3473438cadb6a9677dbff892a1ed02ffdeb64.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.