From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCC40C2D0DB for ; Mon, 20 Jan 2020 17:38:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49DCD218AC for ; Mon, 20 Jan 2020 17:38:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kBAZ9EoD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49DCD218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=codethink.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9245B1669; Mon, 20 Jan 2020 18:37:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9245B1669 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579541886; bh=vCfPxexBSFe9kUkJlI3XI433vDeTVfaVs2RKkihehTQ=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kBAZ9EoD3mhdcD55+eiRtXYIHjok38mIRpj3zdYmWVNxt/DF8/pbobbFVcZmqYNqF Sf7c8gEz4sUIiWKdBkQdtaqpM8KNU9A0755erteR8oZLJ5miADL0QyUTSxJDE6cy/P /kBYw54MRJpT2A2P0H1mmDWJf9PifQzPo0oHqAS0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 18F09F801D8; Mon, 20 Jan 2020 18:37:16 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 38CB0F8020C; Mon, 20 Jan 2020 18:37:14 +0100 (CET) Received: from imap2.colo.codethink.co.uk (imap2.colo.codethink.co.uk [78.40.148.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 108EBF8012F for ; Mon, 20 Jan 2020 18:37:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 108EBF8012F Received: from [167.98.27.226] (helo=[10.35.5.173]) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1itays-0004aj-J2; Mon, 20 Jan 2020 17:36:54 +0000 To: Dmitry Osipenko , Jon Hunter References: <20191018154833.7560-1-ben.dooks@codethink.co.uk> <621fa27d-9259-2949-9cf5-d2eda5cb0677@gmail.com> <449bdc3c-bf82-7cc4-6704-440dd100ca3a@gmail.com> <5d3ae629-5d30-0930-5dd1-15161e64926e@codethink.co.uk> <9daeeb94-2b90-18b8-2e1e-daae5acf079d@gmail.com> <37beb96a-a525-c72f-a7e1-e9ef5d61f3b2@gmail.com> <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <07cd66dc-1a6c-6b49-55a9-1420fe235161@nvidia.com> From: Ben Dooks Organization: Codethink Limited. Message-ID: Date: Mon, 20 Jan 2020 17:36:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org, Liam Girdwood , Takashi Iwai , Mark Brown , Thierry Reding , Edward Cragg , linux-tegra@vger.kernel.org Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" T24gMjAvMDEvMjAyMCAxNjo1MCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IDA4LjAxLjIwMjAg MTQ6MzcsIEpvbiBIdW50ZXIg0L/QuNGI0LXRgjoKPj4KPj4gT24gMDcvMDEvMjAyMCAwMTozOSwg RG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+Pj4gMDYuMDEuMjAyMCAyMjowMCwgQmVuIERvb2tzINC/ 0LjRiNC10YI6Cj4+Pj4gT24gMDUvMDEvMjAyMCAxMDo1MywgQmVuIERvb2tzIHdyb3RlOgo+Pj4+ Pgo+Pj4+Pgo+Pj4+PiBPbiAyMDIwLTAxLTA1IDAxOjQ4LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6 Cj4+Pj4+PiAwNS4wMS4yMDIwIDAzOjA0LCBCZW4gRG9va3Mg0L/QuNGI0LXRgjoKPj4+Pj4+PiBb c25pcF0KPj4+Pj4+Pgo+Pj4+Pj4+IEkndmUganVzdCBnb25lIHRocm91Z2ggdGVzdGluZy4KPj4+ Pj4+Pgo+Pj4+Pj4+IFNvbWUgc2ltcGxlIGRhdGEgdGVzdHMgc2hvdyAxNiBhbmQgMzItYml0cyB3 b3JrLgo+Pj4+Pj4+Cj4+Pj4+Pj4gVGhlIDI0IGJpdCBjYXNlIHNlZW1zIHRvIGJlIHdlaXJkLCBp dCBsb29rcyBsaWtlIHRoZSAyNC1iaXQgZXhwZWN0cwo+Pj4+Pj4+IDI0IGJpdCBzYW1wbGVzIGlu IDMyIGJpdCB3b3Jkcy4gSSBjYW4ndCBzZWUgYW55IHBhY2tpbmcgb3B0aW9ucyB0bwo+Pj4+Pj4+ IGRvIDI0IGJpdCBpbiAyNCBiaXQsIHNvIHdlIG1heSBoYXZlIHRvIHJlbW92ZSAyNCBiaXQgc2Ft cGxlIHN1cHBvcnQKPj4+Pj4+PiAod2hpY2ggaXMgYSBzaGFtZSkKPj4+Pj4+Pgo+Pj4+Pj4+IE15 IHByZWZlcmVuY2UgaXMgdG8gcmVtb3ZlIHRoZSAyNC1iaXQgc3VwcG9ydCBhbmQga2VlcCB0aGUg MzIgYml0IGluLgo+Pj4+Pj4+Cj4+Pj4+Pgo+Pj4+Pj4gSW50ZXJlc3RpbmcuLiBKb24sIGNvdWxk IHlvdSBwbGVhc2UgY29uZmlybSB0aGF0IDI0Yml0IGZvcm1hdCBpc24ndAo+Pj4+Pj4gdXNhYmxl IG9uIFQzMD8KPj4+Pj4KPj4+Pj4gSWYgdGhlcmUgaXMgYW4gb3B0aW9uIG9mIDI0IHBhY2tlZCBp bnRvIDMyLCB0aGVuIEkgdGhpbmsgdGhhdCB3b3VsZCB3b3JrLgo+Pj4+Pgo+Pj4+PiBJIGNhbiB0 cnkgdGVzdGluZyB0aGF0IHdpdGggcmF3IGRhdGEgb24gTW9uZGF5Lgo+Pj4+Cj4+Pj4gSSBuZWVk IHRvIGNoZWNrIHNvbWUgdGhpbmdzLCBJIGFzc3VtZWQgMjQgd2FzIDI0IHBhY2tlZCBiaXRzLCBp dCBsb29rcwo+Pj4+IGxpa2UgdGhlIGRlZmF1bHQgaXMgMjQgaW4gMzIgYml0cyBzbyB3ZSBtYXkg YmUgb2suIEhvd2V2ZXIgSSBuZWVkIHRvCj4+Pj4gcmUtd3JpdGUgbXkgdGVzdCBjYXNlIHdoaWNo IGFzc3VtZWQgaXQgd2FzIDI0Yml0cyBpbiAzIGJ5dGVzIChTMjRfM0xFKS4KPj4+Pgo+Pj4+IEkn bGwgZm9sbG93IHVwIGxhdGVyLAo+Pj4KPj4+IE9rYXksIHRoZSBTMjRfM0xFIGlzbid0IHN1cHBv cnRlZCBieSBSVDU2NDAgY29kZWMgaW4gbXkgY2FzZS4gSSBicmllZmx5Cj4+PiBsb29rZWQgdGhy b3VnaCB0aGUgVFJNIGRvYyBhbmQgZ290IGltcHJlc3Npb24gdGhhdCBBSFVCIGNvdWxkIHJlLXBh Y2sKPj4+IGRhdGEgc3RyZWFtIGludG8gc29tZXRoaW5nIHRoYXQgY29kZWMgc3VwcG9ydHMsIGJ1 dCBtYXliZSBpdCdzIGEgd3JvbmcKPj4+IGltcHJlc3Npb24uCj4+Cj4+IEkgY2hhdHRlZCB3aXRo IFNhbWVlciBhYm91dCB0aGlzLCBzbyB5ZXMgdGhlIEFIVUIgY2FuIHJlcGFjaywgYnV0IHRoZXJl Cj4+IGlzIGEgcHJvYmxlbSB3aXRoIFMyNF9MRSB3aGVyZSBpZiB3ZSB0cnkgdG8gZXh0cmFjdCAy NC1iaXRzIHdlIGFjdHVhbGx5Cj4+IGdldCB0aGUgdXBwZXIgMjQtYml0cyBhbmQgbm90IHRoZSBs b3dlciBMU0JzIGluIHRoZSAzMi1iaXQgZGF0YSBlbGVtZW50Lgo+PiBTbyBhY3R1YWxseSB3ZSBk b24ndCBzdXBwb3J0IFMyNF9MRS4KPj4KPj4gQmVuIGRvIHlvdSBuZWVkIDI0LWJpdCBzdXBwb3J0 IG9yIDMyLWJpdCBvciBib3RoPwoKSSB0aGluayB0aGUgUzI0IHNob3VsZCB3b3JrIHVucGFja2Vk LiBUaGUgcGFja2VkIGp1c3QgZG9lc24ndCBzZWVtIHRvCmJlIGFuIG9wdGlvbiBvbiB0ZWdyYTIv dGVncmEzIGhhcmR3YXJlICh0aGUgbWFudWFsIGRvZXMgbm90IHRhbGsgYWJvdXQKaXQgZWl0aGVy KS4KCkkgd2lsbCB0cnkgYW5kIGdldCB0aGlzIGxvb2tlZCBhdCBhZ2FpbiBvbiBUaHVyc2RheSAy M3JkIGFuZCBzZWUgaWYKSSBjYW4gcnVuIHNvbWUgbW9yZSB0ZXN0cyB3aXRoIDI0IHNhbXBsZSBk YXRhIGluIHRoZSBpbnB1dCBmb3JtYXQgYW5kCmEgbG9naWMgYW5hbHlzZXIgb24gdGhlIG91dHB1 dC4KCgotLSAKQmVuIERvb2tzCQkJCWh0dHA6Ly93d3cuY29kZXRoaW5rLmNvLnVrLwpTZW5pb3Ig RW5naW5lZXIJCQkJQ29kZXRoaW5rIC0gUHJvdmlkaW5nIEdlbml1cwoKaHR0cHM6Ly93d3cuY29k ZXRoaW5rLmNvLnVrL3ByaXZhY3kuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2Et cHJvamVjdC5vcmcKaHR0cHM6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Date: Mon, 20 Jan 2020 17:36:53 +0000 Message-ID: References: <20191018154833.7560-1-ben.dooks@codethink.co.uk> <621fa27d-9259-2949-9cf5-d2eda5cb0677@gmail.com> <449bdc3c-bf82-7cc4-6704-440dd100ca3a@gmail.com> <5d3ae629-5d30-0930-5dd1-15161e64926e@codethink.co.uk> <9daeeb94-2b90-18b8-2e1e-daae5acf079d@gmail.com> <37beb96a-a525-c72f-a7e1-e9ef5d61f3b2@gmail.com> <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <07cd66dc-1a6c-6b49-55a9-1420fe235161@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-GB Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko , Jon Hunter Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Takashi Iwai , Liam Girdwood , Jaroslav Kysela , Mark Brown , Thierry Reding , Edward Cragg , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 20/01/2020 16:50, Dmitry Osipenko wrote: > 08.01.2020 14:37, Jon Hunter пишет: >> >> On 07/01/2020 01:39, Dmitry Osipenko wrote: >>> 06.01.2020 22:00, Ben Dooks пишет: >>>> On 05/01/2020 10:53, Ben Dooks wrote: >>>>> >>>>> >>>>> On 2020-01-05 01:48, Dmitry Osipenko wrote: >>>>>> 05.01.2020 03:04, Ben Dooks пишет: >>>>>>> [snip] >>>>>>> >>>>>>> I've just gone through testing. >>>>>>> >>>>>>> Some simple data tests show 16 and 32-bits work. >>>>>>> >>>>>>> The 24 bit case seems to be weird, it looks like the 24-bit expects >>>>>>> 24 bit samples in 32 bit words. I can't see any packing options to >>>>>>> do 24 bit in 24 bit, so we may have to remove 24 bit sample support >>>>>>> (which is a shame) >>>>>>> >>>>>>> My preference is to remove the 24-bit support and keep the 32 bit in. >>>>>>> >>>>>> >>>>>> Interesting.. Jon, could you please confirm that 24bit format isn't >>>>>> usable on T30? >>>>> >>>>> If there is an option of 24 packed into 32, then I think that would work. >>>>> >>>>> I can try testing that with raw data on Monday. >>>> >>>> I need to check some things, I assumed 24 was 24 packed bits, it looks >>>> like the default is 24 in 32 bits so we may be ok. However I need to >>>> re-write my test case which assumed it was 24bits in 3 bytes (S24_3LE). >>>> >>>> I'll follow up later, >>> >>> Okay, the S24_3LE isn't supported by RT5640 codec in my case. I briefly >>> looked through the TRM doc and got impression that AHUB could re-pack >>> data stream into something that codec supports, but maybe it's a wrong >>> impression. >> >> I chatted with Sameer about this, so yes the AHUB can repack, but there >> is a problem with S24_LE where if we try to extract 24-bits we actually >> get the upper 24-bits and not the lower LSBs in the 32-bit data element. >> So actually we don't support S24_LE. >> >> Ben do you need 24-bit support or 32-bit or both? I think the S24 should work unpacked. The packed just doesn't seem to be an option on tegra2/tegra3 hardware (the manual does not talk about it either). I will try and get this looked at again on Thursday 23rd and see if I can run some more tests with 24 sample data in the input format and a logic analyser on the output. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html