From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jakub.kicinski@netronome.com, andrew@lunn.ch, mlxsw@mellanox.com
Subject: Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names
Date: Wed, 23 Oct 2019 16:16:27 -0600 [thread overview]
Message-ID: <f1facd1c-00e4-e276-3898-b59e9d7281a2@gmail.com> (raw)
In-Reply-To: <20191022055945.GZ2185@nanopsycho>
On 10/21/19 11:59 PM, Jiri Pirko wrote:
> Mon, Oct 21, 2019 at 06:11:33PM CEST, dsahern@gmail.com wrote:
>> On 10/21/19 9:56 AM, Jiri Pirko wrote:
>>>
>>> I forgot to update the desc. Uppercase chars are now allowed as Andrew
>>> requested. Regarding dash, it could be allowed of course. But why isn't
>>> "_" enough. I mean, I think it would be good to maintain allowed chars
>>> within a limit.
>>
>> That's a personal style question. Is "fib-rules" less readable than
>> "fib_rules"? Why put such limitations in place if there is no
>> justifiable reason?
>
> You mean any limitation?
>
I mean why are you pushing a patch to limit what characters can be used
in names, and why are you deciding '-' is not ok but '_' is?
It just seems so random and not driven by some real limitation (e.g.,
entries in a filesystem).
next prev parent reply other threads:[~2019-10-23 22:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:26 [patch net-next v3 0/3] devlink: add format requirement for devlink object names Jiri Pirko
2019-10-21 14:26 ` [patch net-next v3 1/3] netdevsim: change name of fib rules resource Jiri Pirko
2019-10-21 14:26 ` [patch net-next v3 2/3] devlink: replace spaces in dpipe field names Jiri Pirko
2019-10-21 15:17 ` David Ahern
2019-10-21 14:26 ` [patch net-next v3 3/3] devlink: add format requirement for devlink object names Jiri Pirko
2019-10-21 15:20 ` David Ahern
2019-10-21 15:28 ` Andrew Lunn
2019-10-21 15:56 ` Jiri Pirko
2019-10-21 16:11 ` David Ahern
2019-10-22 5:59 ` Jiri Pirko
2019-10-23 22:16 ` David Ahern [this message]
2019-10-24 6:06 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1facd1c-00e4-e276-3898-b59e9d7281a2@gmail.com \
--to=dsahern@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.