From: "Orzel, Michal" <michal.orzel@amd.com>
To: Stewart Hildebrand <stewart.hildebrand@amd.com>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Ayan Kumar Halder <ayan.kumar.halder@amd.com>
Subject: Re: [PATCH 1/6] xen/arm: fix math in add_ext_regions
Date: Mon, 5 May 2025 09:52:36 +0200 [thread overview]
Message-ID: <f1fd915f-be80-4e89-8f75-aab3f79615ea@amd.com> (raw)
In-Reply-To: <20250505025631.207529-2-stewart.hildebrand@amd.com>
On 05/05/2025 04:56, Stewart Hildebrand wrote:
> In commit f37a59813979, the arguments to add_ext_regions() were switched
> from addresses to frame numbers. add_ext_regions() converts the frame
> numbers back to addresses, but the end address (e) is rounded down to
> page size alignment. The logic to calculate the size assumes e points to
> the last address, not page, effectively leading to the region size being
> erroneously calculated to be 2M smaller than the actual size of the
> region.
>
> Fix by adding 1 to the frame number before converting back to address.
>
> Fixes: f37a59813979 ("xen/arm: domain_build: Track unallocated pages using the frame number")
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
Acked-by: Michal Orzel <michal.orzel@amd.com>
~Michal
next prev parent reply other threads:[~2025-05-05 7:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 2:56 [PATCH 0/6] arm: extended regions fixes Stewart Hildebrand
2025-05-05 2:56 ` [PATCH 1/6] xen/arm: fix math in add_ext_regions Stewart Hildebrand
2025-05-05 7:52 ` Orzel, Michal [this message]
2025-05-05 2:56 ` [PATCH 2/6] xen/arm: fix math in add_hwdom_free_regions Stewart Hildebrand
2025-05-05 7:52 ` Orzel, Michal
2025-05-08 6:56 ` Orzel, Michal
2025-05-08 10:30 ` Stewart Hildebrand
2025-05-08 10:31 ` Orzel, Michal
2025-05-05 2:56 ` [PATCH 3/6] xen/arm: switch find_domU_holes to rangesets Stewart Hildebrand
2025-05-05 23:25 ` Stefano Stabellini
2025-05-05 2:56 ` [PATCH 4/6] rangeset: introduce rangeset_subtract Stewart Hildebrand
2025-05-05 2:56 ` [PATCH 5/6] xen/arm: exclude xen,reg{-cacheable} from domU extended regions Stewart Hildebrand
2025-05-05 23:31 ` Stefano Stabellini
2025-05-07 17:20 ` Stewart Hildebrand
2025-05-05 2:56 ` [PATCH 6/6] tools/arm: exclude iomem " Stewart Hildebrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1fd915f-be80-4e89-8f75-aab3f79615ea@amd.com \
--to=michal.orzel@amd.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=ayan.kumar.halder@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=stewart.hildebrand@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.