From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB8A3C4167B for ; Mon, 4 Dec 2023 16:50:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.647186.1009983 (Exim 4.92) (envelope-from ) id 1rAC9F-0004oU-Gj; Mon, 04 Dec 2023 16:50:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 647186.1009983; Mon, 04 Dec 2023 16:50:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rAC9F-0004oN-CG; Mon, 04 Dec 2023 16:50:21 +0000 Received: by outflank-mailman (input) for mailman id 647186; Mon, 04 Dec 2023 16:50:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rAC9E-0004oH-NE for xen-devel@lists.xenproject.org; Mon, 04 Dec 2023 16:50:20 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3546316b-92c5-11ee-98e5-6d05b1d4d9a1; Mon, 04 Dec 2023 17:50:19 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 49EC24EE0C8A; Mon, 4 Dec 2023 17:50:19 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3546316b-92c5-11ee-98e5-6d05b1d4d9a1 MIME-Version: 1.0 Date: Mon, 04 Dec 2023 17:50:19 +0100 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , =?UTF-8?Q?R?= =?UTF-8?Q?oger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 6/7] xen/x86: remove stale comment In-Reply-To: References: <48f44ee5-95c5-4656-97f1-7fa6d0fdc53c@suse.com> <528ef7334c091ad9acb0316cf4b5558b@bugseng.com> <5b48da47a91a8e339b202a78bc5fd1eb@bugseng.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2023-12-04 17:40, Jan Beulich wrote: > On 04.12.2023 17:26, Nicola Vetrini wrote: >> On 2023-12-01 17:57, Nicola Vetrini wrote: >>> On 2023-11-30 17:41, Jan Beulich wrote: >>>> On 29.11.2023 16:24, Nicola Vetrini wrote: >>>>> The comment referred to the declaration for do_mca, which >>>>> now is part of hypercall-defs.h, therefore the comment is stale. >>>> >>>> If the comments were stale, the #include-s should also be able to >>>> disappear? >> >>>>> --- a/xen/arch/x86/include/asm/hypercall.h >>>>> +++ b/xen/arch/x86/include/asm/hypercall.h >>>>> @@ -12,7 +12,7 @@ >>>>> #include >>>>> #include >>>>> #include >>>>> -#include /* for do_mca */ >>>>> +#include >>>>> #include >>>> >>>> Here otoh I'm not even sure this public header (or the others) is >>>> (are) >>>> really needed. >>>> >>> >>> I confirm this. It build even without this header. >> >> It does appear to be needed after all. I did two differential pipeline >> runs, and some jobs fail to compile when I remove the header (e.g., >> [1]). Looking trough the build log, it's not entirely clear what is >> the >> relationship, but it seems related to some use of this struct defined >> in >> xen-mca.h: >> >> typedef struct xen_mc xen_mc_t; >> DEFINE_XEN_GUEST_HANDLE(xen_mc_t); > > That do_mca()'s parameter type, so in a way the comment is still > correct > then. > > Jan Yeah, this patch can be dropped. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)