From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C465EC76196 for ; Fri, 31 Mar 2023 09:35:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232020AbjCaJfH (ORCPT ); Fri, 31 Mar 2023 05:35:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232292AbjCaJeR (ORCPT ); Fri, 31 Mar 2023 05:34:17 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E5517296 for ; Fri, 31 Mar 2023 02:34:02 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id k37so28154596lfv.0 for ; Fri, 31 Mar 2023 02:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680255240; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ai/1YpnrQGMFVrnQJeZGVLCmWTY7Fz7OsSb9rllfA/A=; b=bXr2Xm5tyW+sglpq+sV+BJ/VlJIXrkWrlavLQftfI12wsd+i87DDKbAWpw4fLK6JJu TuQxBQoXbC1FkMaIY+osrvcF3Uo0DCrkn3YlroowTyOUQG/JSyf6j/Qz+I362/qyYvpb vW6KmvooSBlZETfBQhFqLfrwMnKhsD6CKuXTJSHMyLqfhVSWqUkipTrRX4+H1aIBby9R GQjkOO6fVn/Uj6ZYHIQ1W2VZ/5THM/Di45QsRBw5En6fFKaqB4iH78ULxJoSB9XUuBWD ZoCGLcg00OVTS5tUOQj+fKV4Bn5a+6UTbGLmfWBY8vvvv/UVBZm72g6kMFqLpvHwPGXK i2iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680255240; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ai/1YpnrQGMFVrnQJeZGVLCmWTY7Fz7OsSb9rllfA/A=; b=WW27LFmB0FuwrrqaQuLTPU6dV8stbl22trNpCSrwxjei6FgeuELXacSWDkJ7R4foTB QIi1atVsbweOVNBjyJTbmySbBH5yfUyKceGSYlquzmCxEGIEjOu5bsPniA8fKn1it5Rc eUHEbkm/xBHnjI18nx/Z+3WZQvflHxLlG54oTQ285IRIeWK5bQo00XrigM+fxkOzsVGV AgP3mBRF2GbvIKBFDvGbFxMFihrOx+cgajV4l/1MoR3jqcGoPbsO4b0NbeLPPqHVXu6e k0nk4WRzMuVqZxWV0PRFzlpQQswBnwO48DFuB7PrvHAbIH99KkL9sYagnvt2JJrq1J1J y99Q== X-Gm-Message-State: AAQBX9fsxOiTDIMjEiWnqDsG3QsNj9QWk6pMhL+pz/vvfThfEZvy+SJl ja654w0HcTovwwjaSscfQ/F12w== X-Google-Smtp-Source: AKy350Zw3AEl/l1nQ2UFiIHwCfWmha0LEvbnsktucmxS1dk8XV4DbUPsuRtguW7IZ5SHImNMhoNXQw== X-Received: by 2002:ac2:5318:0:b0:4e9:b64a:b87d with SMTP id c24-20020ac25318000000b004e9b64ab87dmr8522538lfh.9.1680255240307; Fri, 31 Mar 2023 02:34:00 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id l14-20020a2e99ce000000b0029f7d27b78bsm285041ljj.110.2023.03.31.02.33.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 02:33:59 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 11:33:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Content-Language: en-US To: Francesco Dolcini Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, Rob Herring , Krzysztof Kozlowski , Peter Ujfalusi , devicetree@vger.kernel.org, Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org References: <20230330095941.428122-1-francesco@dolcini.it> <20230330095941.428122-3-francesco@dolcini.it> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/03/2023 11:30, Francesco Dolcini wrote: > On Fri, Mar 31, 2023 at 10:42:40AM +0200, Krzysztof Kozlowski wrote: >> On 30/03/2023 11:59, Francesco Dolcini wrote: >>> From: Francesco Dolcini >>> >>> Add TC9594, from the software point of view this is identical to >>> TC358768 with the main difference being automotive qualified. >>> >>> Signed-off-by: Francesco Dolcini >>> --- >>> .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> index d6dac186ac59..8f22093b61ae 100644 >>> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> @@ -4,19 +4,20 @@ >>> $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# >>> $schema: http://devicetree.org/meta-schemas/core.yaml# >>> >>> -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge >>> +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge >>> >>> maintainers: >>> - Peter Ujfalusi >>> >>> description: | >>> - The TC358768/TC358778 is bridge device which converts RGB to DSI. >>> + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. >>> >>> properties: >>> compatible: >>> enum: >>> - toshiba,tc358768 >>> - toshiba,tc358778 >>> + - toshiba,tc9594 >> >> If it is the same, why they are not compatible? > > I assume I am not understanding something very basic ... > > The register description and SW functionality of all these 3 parts is > identical. > > How should be the compatible described in the DT schema in this case? Look at any board compatibles for example. > > >> I got only three patches out of six, thus I cannot check by myself. > > Here the whole series: https://lore.kernel.org/all/20230330095941.428122-1-francesco@dolcini.it/ > > Do you want to me to send the whole series and not just the DT binding > next time? Happy to do it, if you prefer. So NAK on 4th patch. Don't grow device ID tables needlessly. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09FFAC6FD18 for ; Fri, 31 Mar 2023 09:34:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A783510F158; Fri, 31 Mar 2023 09:34:03 +0000 (UTC) Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1196310F150 for ; Fri, 31 Mar 2023 09:34:02 +0000 (UTC) Received: by mail-lf1-x134.google.com with SMTP id c29so28122037lfv.3 for ; Fri, 31 Mar 2023 02:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680255240; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ai/1YpnrQGMFVrnQJeZGVLCmWTY7Fz7OsSb9rllfA/A=; b=bXr2Xm5tyW+sglpq+sV+BJ/VlJIXrkWrlavLQftfI12wsd+i87DDKbAWpw4fLK6JJu TuQxBQoXbC1FkMaIY+osrvcF3Uo0DCrkn3YlroowTyOUQG/JSyf6j/Qz+I362/qyYvpb vW6KmvooSBlZETfBQhFqLfrwMnKhsD6CKuXTJSHMyLqfhVSWqUkipTrRX4+H1aIBby9R GQjkOO6fVn/Uj6ZYHIQ1W2VZ/5THM/Di45QsRBw5En6fFKaqB4iH78ULxJoSB9XUuBWD ZoCGLcg00OVTS5tUOQj+fKV4Bn5a+6UTbGLmfWBY8vvvv/UVBZm72g6kMFqLpvHwPGXK i2iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680255240; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ai/1YpnrQGMFVrnQJeZGVLCmWTY7Fz7OsSb9rllfA/A=; b=tRYaUR4aqWCY+YOzn/1SjhVStRXO+uMDThUesPDZZNKaVs5lR2v6v3QmwHeoxxtH46 Lz12+eddJKHxQzh5OuSXkAaoLWn50JMw4CSnkXpAr5P3QyCqrSWHcR8GOSP+5WLWKMbS HlRw1FEO19qozbt63D0IH+RhcE/5WMitmPEzjuImnR2KEuyTioBE3nC171oFsX/qg7zr GXhYNG5wL0ULHNsxV+vXl+ySxpiBcToS6OEj4POx2tvdVrmA7vl0FSShxeCfL+grcAwQ bq//7DZuooWL0W3mWkD18z2tAWFkK7Pwz8eDh1FAiHwMkx84Q/RIFBYD1gBoIsRwcZxC A5mg== X-Gm-Message-State: AAQBX9c+ivnwvVa3c8Cedobm9xurWUoDjmczTZm02aVBdoxTHEAGHxVE Urd66okeOhm/KndITjhrA/Tz3w== X-Google-Smtp-Source: AKy350Zw3AEl/l1nQ2UFiIHwCfWmha0LEvbnsktucmxS1dk8XV4DbUPsuRtguW7IZ5SHImNMhoNXQw== X-Received: by 2002:ac2:5318:0:b0:4e9:b64a:b87d with SMTP id c24-20020ac25318000000b004e9b64ab87dmr8522538lfh.9.1680255240307; Fri, 31 Mar 2023 02:34:00 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id l14-20020a2e99ce000000b0029f7d27b78bsm285041ljj.110.2023.03.31.02.33.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 02:33:59 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 11:33:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Content-Language: en-US To: Francesco Dolcini References: <20230330095941.428122-1-francesco@dolcini.it> <20230330095941.428122-3-francesco@dolcini.it> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Krzysztof Kozlowski , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Peter Ujfalusi , devicetree@vger.kernel.org, Rob Herring , Laurent Pinchart , Andrzej Hajda , Francesco Dolcini Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 31/03/2023 11:30, Francesco Dolcini wrote: > On Fri, Mar 31, 2023 at 10:42:40AM +0200, Krzysztof Kozlowski wrote: >> On 30/03/2023 11:59, Francesco Dolcini wrote: >>> From: Francesco Dolcini >>> >>> Add TC9594, from the software point of view this is identical to >>> TC358768 with the main difference being automotive qualified. >>> >>> Signed-off-by: Francesco Dolcini >>> --- >>> .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> index d6dac186ac59..8f22093b61ae 100644 >>> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> @@ -4,19 +4,20 @@ >>> $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# >>> $schema: http://devicetree.org/meta-schemas/core.yaml# >>> >>> -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge >>> +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge >>> >>> maintainers: >>> - Peter Ujfalusi >>> >>> description: | >>> - The TC358768/TC358778 is bridge device which converts RGB to DSI. >>> + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. >>> >>> properties: >>> compatible: >>> enum: >>> - toshiba,tc358768 >>> - toshiba,tc358778 >>> + - toshiba,tc9594 >> >> If it is the same, why they are not compatible? > > I assume I am not understanding something very basic ... > > The register description and SW functionality of all these 3 parts is > identical. > > How should be the compatible described in the DT schema in this case? Look at any board compatibles for example. > > >> I got only three patches out of six, thus I cannot check by myself. > > Here the whole series: https://lore.kernel.org/all/20230330095941.428122-1-francesco@dolcini.it/ > > Do you want to me to send the whole series and not just the DT binding > next time? Happy to do it, if you prefer. So NAK on 4th patch. Don't grow device ID tables needlessly. Best regards, Krzysztof