From: Pavel Skripkin <paskripkin@gmail.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v3 1/2] staging: r8188eu: Use usb_control_msg_recv/send() in usbctrl_vendorreq()
Date: Thu, 26 Aug 2021 21:18:23 +0300 [thread overview]
Message-ID: <f2360c8c-e001-70d6-daeb-03ca5b718d84@gmail.com> (raw)
In-Reply-To: <20210825035311.8910-2-fmdefrancesco@gmail.com>
On 8/25/21 6:53 AM, Fabio M. De Francesco wrote:
> Replace usb_control_msg() with the new usb_control_msg_recv() and
> usb_control_msg_send() API of USB Core in usbctrl_vendorreq().
> Remove no more needed variables. Move out of an if-else block
> some code that it is no more dependent on status < 0. Remove
> redundant code depending on status > 0 or status == len.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
FYI, I've tested this patch with TP-Link TL-WN722N v3 + qemu :)
Tested-by: Pavel Skripkin <paskripkin@gmail.com>
NOTE: I am still not able to apply 2/2, so tested tag is only for 1/2
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-08-26 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 3:53 [PATCH v3 0/2] staging: r8188eu: Use new usb_control_msg_recv/send() Fabio M. De Francesco
2021-08-25 3:53 ` [PATCH v3 1/2] staging: r8188eu: Use usb_control_msg_recv/send() in usbctrl_vendorreq() Fabio M. De Francesco
2021-08-25 9:01 ` Pavel Skripkin
2021-08-26 10:48 ` Greg Kroah-Hartman
2021-08-26 14:24 ` Fabio M. De Francesco
2021-08-26 14:45 ` Greg Kroah-Hartman
2021-08-26 15:43 ` Fabio M. De Francesco
2021-08-26 18:18 ` Pavel Skripkin [this message]
2021-08-26 18:56 ` Fabio M. De Francesco
2021-08-26 19:12 ` Pavel Skripkin
2021-08-25 3:53 ` [PATCH v3 2/2] staging: r8188eu: Make clean-ups " Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2360c8c-e001-70d6-daeb-03ca5b718d84@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.