From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42D1BC433FE for ; Mon, 22 Nov 2021 17:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jCMkxD+Cvq/pU0kU3arOfxPv/q3Muiii6EtDdIxqQNs=; b=0pxn1Y037ypLsuPllE9ceEA5nX En1nniZiEIgimDntQfVHN+Y1Xmxs6A6Um/KgJXQzGa9JBg+nKhIjH1bNDgnD7sikSbcmT6ziIOiRr oJQlCy3/8ChO0uiNsZzx3Hx8yZpp42Q8C0uuBx9pekhreqH8xA4sIEtafbVTAob+sc57/j96wNsUF wWyYrwfQ/Y2LXyLUesn1LMUGeLFjG/Bb9uCXztZFAgPT23xjN5VdfzwhWLE+doUwLHbm2eIoz6d61 /wo2TuA+PsjoAgXqLooVw5i2q/o9/Gf4TX71Ey1aMlvaezylb7bb+Z/f4fipezxJJCqq5+gKTT4RM /c/Kj/jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpDat-00HI8k-Bf; Mon, 22 Nov 2021 17:59:07 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpDar-00HI7w-AY for ath11k@lists.infradead.org; Mon, 22 Nov 2021 17:59:06 +0000 Received: by mail-lf1-x134.google.com with SMTP id bu18so84417194lfb.0 for ; Mon, 22 Nov 2021 09:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Gko20DS1AZDMNnuAhnKTds8S3OUfVzVKr6Ai4EtHDgY=; b=od268HEAyAG6omdAhFW36mjc+TQ3DOz2cZ8OcvJm1lKz/WouAcejdRomllgHKMaZRi PdDmbb9RFd+SRMWfqH0wjG9RFdRqg/ba7WI5A9vpJQkKAMO4vpSBFi9R1pL7Xq8vh/ps 0+bLK4rKKizIU3ewRtyWAuTo0KiifRnXSHzFh1IWltuJvQqfo1EG48WKJdqG6aipbeOj 34lYIQ+vrgGXv1GLgDfgOzVvGRp7D04rSYgpg3RP64F1UWUyoGX4uW2Hzxghxbd83FJf wwrvjlZxgE0MrSD4UdnNPh4puVamS1iI8OL0jXtZTzR48k9gUV21fE7K8MpuBVMt+rNX 6NNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Gko20DS1AZDMNnuAhnKTds8S3OUfVzVKr6Ai4EtHDgY=; b=enoGsmF2tOzzZky9cF+INhhJJg4kqa6/leMY1+ecJPcAEmDEEz1p6AaGvVbWolCNCl YErRVZvFsEWo28bfEhH66IUH25fQ2O+0HF+1TVmDvc49xdm3L3liBSzKxfc14nuOJ/Y/ F5qSjHaIFFbE8gghtEibPNZG1CqbdHC5AJEBMvZS1PvisMcrrGDudlAEWUw6divYvIZP WMPogd2uQnyTOVrDpJ0ktH4FbB7Sr/iE4e7nyPadT0HqYwHu3ki2ZSl6+7EyE3KgpQWq 9PfHu48uXHHKLsZAPwIj1oIWhHtbfYPYmoil4xdl9ZFpGZORChtLSbtRW7XRtRzoudLZ ylMg== X-Gm-Message-State: AOAM533ip8yLvgjFFhbw/Wq/ykX+89OYZJWkF8a1WU3Il63rrajfJKIg pzfH2JU8vlHD9ETn6tTRAkdBK/LHbbVs3g== X-Google-Smtp-Source: ABdhPJyGxpAfOgl9P8QMQ82zXTMzVAq8nHh2+R7/htbbbXz33Hxw+Mec7Zc6ARRsZxV2tIqb0XPoOQ== X-Received: by 2002:ac2:4d29:: with SMTP id h9mr58142252lfk.633.1637603942278; Mon, 22 Nov 2021 09:59:02 -0800 (PST) Received: from [192.168.8.100] ([176.59.41.199]) by smtp.gmail.com with ESMTPSA id c34sm1036390lfv.83.2021.11.22.09.59.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Nov 2021 09:59:01 -0800 (PST) Subject: Re: [PATCH v2] ath11k: add read variant from SMBIOS for download board data To: Kalle Valo , Wen Gong Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org References: <20211118100033.8384-1-quic_wgong@quicinc.com> <163759171706.17469.3004620526954131593.kvalo@codeaurora.org> From: Mark Herbert Message-ID: Date: Mon, 22 Nov 2021 20:58:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <163759171706.17469.3004620526954131593.kvalo@codeaurora.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_095905_389501_F1C47F70 X-CRM114-Status: GOOD ( 12.28 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org VHJpZWQgdGhpcyBvbiBEZWxsIFhQUyAxMyA5MzEwCgpNYXliZSB0aGlzIHBhdGNoIGlzIGdvb2Qg Zm9yIDY4NTUsIGJ1dCA2MzkwIGluIERlbGwgc2VlbXMgdG8gYmUga2lsbGVkIApjb21wbGV0ZWx5 IHdpdGggaXQuIFJldmVydGluZyBpdCBtYWtlcyB0aGluZ3Mgd29yayBhZ2Fpbi4KClvCoMKgwqAg NS41MzcwMzRdIGF0aDExa19wY2kgMDAwMDo3MjowMC4wOiBjaGlwX2lkIDB4MCBjaGlwX2ZhbWls eSAweGIgCmJvYXJkX2lkIDB4ZmYgc29jX2lkIDB4ZmZmZmZmZmYKW8KgwqDCoCA1LjUzNzAzOF0g YXRoMTFrX3BjaSAwMDAwOjcyOjAwLjA6IGZ3X3ZlcnNpb24gMHgxMDFjMDZjYyAKZndfYnVpbGRf dGltZXN0YW1wIDIwMjAtMDYtMjQgMTk6NTAgZndfYnVpbGRfaWQKW8KgwqDCoCA1LjUzNzIzNl0g YXRoMTFrX3BjaSAwMDAwOjcyOjAwLjA6IGZhaWxlZCB0byBmZXRjaCBib2FyZCBkYXRhIGZvciAK YnVzPXBjaSxxbWktY2hpcC1pZD0wLHFtaS1ib2FyZC1pZD0yNTUsdmFyaWFudD1ERV8xOTAxIGZy b20gCmF0aDExay9RQ0E2MzkwL2h3Mi4wL2JvYXJkLTIuYmluClvCoMKgwqAgNS41MzcyNTVdIGF0 aDExa19wY2kgMDAwMDo3MjowMC4wOiBmYWlsZWQgdG8gZmV0Y2ggYm9hcmQtMi5iaW4gb3IgCmJv YXJkLmJpbiBmcm9tIFFDQTYzOTAvaHcyLjAKW8KgwqDCoCA1LjUzNzI1N10gYXRoMTFrX3BjaSAw MDAwOjcyOjAwLjA6IHFtaSBmYWlsZWQgdG8gZmV0Y2ggYm9hcmQgZmlsZTogLTIKW8KgwqDCoCA1 LjUzNzI1OF0gYXRoMTFrX3BjaSAwMDAwOjcyOjAwLjA6IGZhaWxlZCB0byBsb2FkIGJvYXJkIGRh dGEgZmlsZTogLTIKCk9uIDIyLjExLjIwMjEgMTc6MzUsIEthbGxlIFZhbG8gd3JvdGU6Cj4gV2Vu IEdvbmcgPHF1aWNfd2dvbmdAcXVpY2luYy5jb20+IHdyb3RlOgo+Cj4+IFRoaXMgaXMgdG8gcmVh ZCB2YXJpYW50IGZyb20gU01CSU9TIHN1Y2ggYXMgcmVhZCBmcm9tIERULCB0aGUgdmFyaWFudAo+ PiBzdHJpbmcgd2lsbCBiZSB1c2VkIHRvIG9uZSBwYXJ0IG9mIHN0cmluZyB3aGljaCB1c2VkIHRv IHNlYXJjaCBib2FyZAo+PiBkYXRhIGZyb20gYm9hcmQtMi5iaW4uCj4+Cj4+IFRlc3RlZC1vbjog V0NONjg1NSBodzIuMCBQQ0kgV0xBTi5IU1AuMS4xLTAxNzIwLjEtUUNBSFNQU1dQTF9WMV9WMl9T SUxJQ09OWl9MSVRFLTEKPj4KPj4gU2lnbmVkLW9mZi1ieTogV2VuIEdvbmcgPHF1aWNfd2dvbmdA cXVpY2luYy5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IEthbGxlIFZhbG8gPGt2YWxvQGNvZGVhdXJv cmEub3JnPgo+IFBhdGNoIGFwcGxpZWQgdG8gYXRoLW5leHQgYnJhbmNoIG9mIGF0aC5naXQsIHRo YW5rcy4KPgo+IDQ2ZTQ2ZGIzMTNhMiBhdGgxMWs6IGFkZCByZWFkIHZhcmlhbnQgZnJvbSBTTUJJ T1MgZm9yIGRvd25sb2FkIGJvYXJkIGRhdGEKPgoKLS0gCmF0aDExayBtYWlsaW5nIGxpc3QKYXRo MTFrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9hdGgxMWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3646BC433F5 for ; Mon, 22 Nov 2021 17:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233819AbhKVSCL (ORCPT ); Mon, 22 Nov 2021 13:02:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbhKVSCL (ORCPT ); Mon, 22 Nov 2021 13:02:11 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4463EC061574 for ; Mon, 22 Nov 2021 09:59:04 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id l22so83913660lfg.7 for ; Mon, 22 Nov 2021 09:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Gko20DS1AZDMNnuAhnKTds8S3OUfVzVKr6Ai4EtHDgY=; b=od268HEAyAG6omdAhFW36mjc+TQ3DOz2cZ8OcvJm1lKz/WouAcejdRomllgHKMaZRi PdDmbb9RFd+SRMWfqH0wjG9RFdRqg/ba7WI5A9vpJQkKAMO4vpSBFi9R1pL7Xq8vh/ps 0+bLK4rKKizIU3ewRtyWAuTo0KiifRnXSHzFh1IWltuJvQqfo1EG48WKJdqG6aipbeOj 34lYIQ+vrgGXv1GLgDfgOzVvGRp7D04rSYgpg3RP64F1UWUyoGX4uW2Hzxghxbd83FJf wwrvjlZxgE0MrSD4UdnNPh4puVamS1iI8OL0jXtZTzR48k9gUV21fE7K8MpuBVMt+rNX 6NNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Gko20DS1AZDMNnuAhnKTds8S3OUfVzVKr6Ai4EtHDgY=; b=wkEouTvD42qAt1IfFaBXvHWdm5GHYFycyMfi5AbyolZfHgOAWS30CuVwJrj2Pxf+JY 0o3mKubTkI0lJ0DQc5rACVeLkfUldzoYSImfkVvnarcsjTNdbIUIaBFuOIMFf5FiC8GB Pq9fE7ldHnHi3L7tM1RjnBekb8VHMM06G6erHGF0I0YerPGyv+etw4ptZMLxfyaIIEjg UC5UxrOOXGQmNCgtFZvk3SVti/B2ASWP083YKpcL3xHv2Md0mBd2dCuhR2aXYFMnho9c yf2wfUvZSeeCB8sBJHVT3DvdILoAoR76I17D2z7+ieji8VmmrQMV/9Coz7eZn+Qv+Bwd gOsw== X-Gm-Message-State: AOAM532dSYlZ8MvSAgsOn2z0acfrGKC6pA6kyO0p4barfCi4DgU6thCm 2wzsztg8W7CSmLDd8BeKTj9VskclYKptkQ== X-Google-Smtp-Source: ABdhPJyGxpAfOgl9P8QMQ82zXTMzVAq8nHh2+R7/htbbbXz33Hxw+Mec7Zc6ARRsZxV2tIqb0XPoOQ== X-Received: by 2002:ac2:4d29:: with SMTP id h9mr58142252lfk.633.1637603942278; Mon, 22 Nov 2021 09:59:02 -0800 (PST) Received: from [192.168.8.100] ([176.59.41.199]) by smtp.gmail.com with ESMTPSA id c34sm1036390lfv.83.2021.11.22.09.59.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Nov 2021 09:59:01 -0800 (PST) Subject: Re: [PATCH v2] ath11k: add read variant from SMBIOS for download board data To: Kalle Valo , Wen Gong Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org References: <20211118100033.8384-1-quic_wgong@quicinc.com> <163759171706.17469.3004620526954131593.kvalo@codeaurora.org> From: Mark Herbert Message-ID: Date: Mon, 22 Nov 2021 20:58:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <163759171706.17469.3004620526954131593.kvalo@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tried this on Dell XPS 13 9310 Maybe this patch is good for 6855, but 6390 in Dell seems to be killed completely with it. Reverting it makes things work again. [    5.537034] ath11k_pci 0000:72:00.0: chip_id 0x0 chip_family 0xb board_id 0xff soc_id 0xffffffff [    5.537038] ath11k_pci 0000:72:00.0: fw_version 0x101c06cc fw_build_timestamp 2020-06-24 19:50 fw_build_id [    5.537236] ath11k_pci 0000:72:00.0: failed to fetch board data for bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=DE_1901 from ath11k/QCA6390/hw2.0/board-2.bin [    5.537255] ath11k_pci 0000:72:00.0: failed to fetch board-2.bin or board.bin from QCA6390/hw2.0 [    5.537257] ath11k_pci 0000:72:00.0: qmi failed to fetch board file: -2 [    5.537258] ath11k_pci 0000:72:00.0: failed to load board data file: -2 On 22.11.2021 17:35, Kalle Valo wrote: > Wen Gong wrote: > >> This is to read variant from SMBIOS such as read from DT, the variant >> string will be used to one part of string which used to search board >> data from board-2.bin. >> >> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 >> >> Signed-off-by: Wen Gong >> Signed-off-by: Kalle Valo > Patch applied to ath-next branch of ath.git, thanks. > > 46e46db313a2 ath11k: add read variant from SMBIOS for download board data >