From: abhinavk@codeaurora.org
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Jonathan Marek <jonathan@marek.ca>,
Stephen Boyd <sboyd@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Subject: Re: [Freedreno] [PATCH 02/11] drm/msm/dpu: remove pipe_qos_cfg from struct dpu_plane
Date: Thu, 21 Oct 2021 15:24:17 -0700 [thread overview]
Message-ID: <f2625a3f82f535fd544f72c53a0033ff@codeaurora.org> (raw)
In-Reply-To: <20210930140002.308628-3-dmitry.baryshkov@linaro.org>
On 2021-09-30 06:59, Dmitry Baryshkov wrote:
> The pipe_qos_cfg is used only in _dpu_plane_set_qos_ctrl(), so remove
> it
> from the dpu_plane struct and allocate it on stack when necessary.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 30 ++++++++++++-----------
> 1 file changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 5e0d06f26e53..88d726133b8b 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -105,7 +105,6 @@ struct dpu_plane {
>
> struct dpu_hw_pipe *pipe_hw;
> struct dpu_hw_pipe_cfg pipe_cfg;
> - struct dpu_hw_pipe_qos_cfg pipe_qos_cfg;
> uint32_t color_fill;
> bool is_error;
> bool is_rt_pipe;
> @@ -422,38 +421,41 @@ static void _dpu_plane_set_qos_ctrl(struct
> drm_plane *plane,
> bool enable, u32 flags)
> {
> struct dpu_plane *pdpu = to_dpu_plane(plane);
> + struct dpu_hw_pipe_qos_cfg pipe_qos_cfg;
> +
> + memset(&pipe_qos_cfg, 0, sizeof(pipe_qos_cfg));
>
> if (flags & DPU_PLANE_QOS_VBLANK_CTRL) {
> - pdpu->pipe_qos_cfg.creq_vblank = pdpu->pipe_sblk->creq_vblank;
> - pdpu->pipe_qos_cfg.danger_vblank =
> + pipe_qos_cfg.creq_vblank = pdpu->pipe_sblk->creq_vblank;
> + pipe_qos_cfg.danger_vblank =
> pdpu->pipe_sblk->danger_vblank;
> - pdpu->pipe_qos_cfg.vblank_en = enable;
> + pipe_qos_cfg.vblank_en = enable;
> }
>
> if (flags & DPU_PLANE_QOS_VBLANK_AMORTIZE) {
> /* this feature overrules previous VBLANK_CTRL */
> - pdpu->pipe_qos_cfg.vblank_en = false;
> - pdpu->pipe_qos_cfg.creq_vblank = 0; /* clear vblank bits */
> + pipe_qos_cfg.vblank_en = false;
> + pipe_qos_cfg.creq_vblank = 0; /* clear vblank bits */
> }
>
> if (flags & DPU_PLANE_QOS_PANIC_CTRL)
> - pdpu->pipe_qos_cfg.danger_safe_en = enable;
> + pipe_qos_cfg.danger_safe_en = enable;
>
> if (!pdpu->is_rt_pipe) {
> - pdpu->pipe_qos_cfg.vblank_en = false;
> - pdpu->pipe_qos_cfg.danger_safe_en = false;
> + pipe_qos_cfg.vblank_en = false;
> + pipe_qos_cfg.danger_safe_en = false;
> }
>
> DPU_DEBUG_PLANE(pdpu, "pnum:%d ds:%d vb:%d pri[0x%x, 0x%x]
> is_rt:%d\n",
> pdpu->pipe - SSPP_VIG0,
> - pdpu->pipe_qos_cfg.danger_safe_en,
> - pdpu->pipe_qos_cfg.vblank_en,
> - pdpu->pipe_qos_cfg.creq_vblank,
> - pdpu->pipe_qos_cfg.danger_vblank,
> + pipe_qos_cfg.danger_safe_en,
> + pipe_qos_cfg.vblank_en,
> + pipe_qos_cfg.creq_vblank,
> + pipe_qos_cfg.danger_vblank,
> pdpu->is_rt_pipe);
>
> pdpu->pipe_hw->ops.setup_qos_ctrl(pdpu->pipe_hw,
> - &pdpu->pipe_qos_cfg);
> + &pipe_qos_cfg);
> }
>
> /**
next prev parent reply other threads:[~2021-10-21 22:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 13:59 [PATCH 00/11] drm/msm/dpu: cleanup plane state Dmitry Baryshkov
2021-09-30 13:59 ` [PATCH 01/11] drm/msm/dpu: move LUT levels out of QOS config Dmitry Baryshkov
2021-10-21 22:22 ` [Freedreno] " abhinavk
2021-09-30 13:59 ` [PATCH 02/11] drm/msm/dpu: remove pipe_qos_cfg from struct dpu_plane Dmitry Baryshkov
2021-10-21 22:24 ` abhinavk [this message]
2021-09-30 13:59 ` [PATCH 03/11] drm/msm/dpu: drop pipe_name " Dmitry Baryshkov
2021-10-21 22:25 ` [Freedreno] " abhinavk
2021-09-30 13:59 ` [PATCH 04/11] drm/msm/dpu: remove stage_cfg from struct dpu_crtc Dmitry Baryshkov
2021-10-21 22:30 ` [Freedreno] " abhinavk
2021-09-30 13:59 ` [PATCH 05/11] drm/msm/dpu: move dpu_hw_pipe_cfg out of struct dpu_plane Dmitry Baryshkov
2021-10-21 22:35 ` [Freedreno] " abhinavk
2021-09-30 13:59 ` [PATCH 06/11] drm/msm/dpu: drop scaler config from plane state Dmitry Baryshkov
2021-10-21 22:41 ` [Freedreno] " abhinavk
2021-09-30 13:59 ` [PATCH 07/11] drm/msm/dpu: drop dpu_csc_cfg from dpu_plane Dmitry Baryshkov
2021-10-21 23:17 ` [Freedreno] " abhinavk
2021-09-30 13:59 ` [PATCH 08/11] drm/msm/dpu: remove dpu_hw_pipe_cdp_cfg " Dmitry Baryshkov
2021-10-21 23:19 ` [Freedreno] " abhinavk
2021-09-30 14:00 ` [PATCH 09/11] drm/msm/dpu: don't cache pipe->cap->features in dpu_plane Dmitry Baryshkov
2021-10-21 23:24 ` [Freedreno] " abhinavk
2021-09-30 14:00 ` [PATCH 10/11] drm/msm/dpu: don't cache pipe->cap->sblk " Dmitry Baryshkov
2021-10-21 23:29 ` [Freedreno] " abhinavk
2021-09-30 14:00 ` [PATCH 11/11] drm/msm/dpu: rip out debugfs support from dpu_plane Dmitry Baryshkov
2021-10-21 23:53 ` [Freedreno] " abhinavk
2021-10-22 11:35 ` Dmitry Baryshkov
2021-11-18 21:43 ` Rob Clark
2021-11-18 21:43 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2625a3f82f535fd544f72c53a0033ff@codeaurora.org \
--to=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.