Re: [PATCH] ALSA: ac97: drop stale CMI9738 PCM-volume quirk

["Cássio Gabriel Monteiro Pires" <cassiogabrielcontato@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 972 bytes --]

On 4/29/26 09:39, Takashi Iwai wrote:
> On Wed, 29 Apr 2026 14:05:31 +0200,
> Cássio Gabriel wrote:
>>
>> patch_cm9738() still carries an old comment claiming that CMI9738
>> has no PCM volume although AC97_PCM reacts, and then forces
>> AC97_HAS_NO_PCM_VOL.
>>
>> The CMI9738 datasheet documents register 0x18 as "PCM Out Vol"
>> with mute and left/right volume fields, so that old assumption is
>> not justified.
> 
> Well, that's actually the part the FIXME points to.  Although the spec
> shows the register is available and the chip reads out, the volume
> didn't seem reacting properly on the real hardware, as far as I
> remember correctly.
> 
> So, it's really doubtful whether it's safe to cut off this workaround
> just by reading the data sheet.

Yes, that matches what I suspected at first glance; I wanted to confirm
whether the datasheet was enough to revisit the old workaround.

> thanks,
> 
> Takashi

-- 
Thanks,
Cássio


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]