From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence Date: Wed, 6 May 2020 20:05:27 +0300 Message-ID: References: <20200418170703.1583-1-digetx@gmail.com> <20200418170703.1583-3-digetx@gmail.com> <20200506164133.GB19296@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200506164133.GB19296-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sam Ravnborg Cc: Thierry Reding , Laurent Pinchart , Rob Herring , Frank Rowand , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-tegra@vger.kernel.org 06.05.2020 19:41, Sam Ravnborg пишет: > On Sat, Apr 18, 2020 at 08:06:59PM +0300, Dmitry Osipenko wrote: >> When graph isn't defined in a device-tree, the of_graph_get_remote_node() >> prints a noisy error message, telling that port node is not found. This is >> undesirable behaviour in our case because absence of a panel/bridge graph >> is a valid case. Let's check presence of the local port in a device-tree >> before proceeding with parsing the graph. >> >> Signed-off-by: Dmitry Osipenko > Reviewed-by: Sam Ravnborg Thank you again for taking a look at these patches! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3085CC4724C for ; Wed, 6 May 2020 17:05:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00FC52080D for ; Wed, 6 May 2020 17:05:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nJ/sVN4k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729939AbgEFRFb (ORCPT ); Wed, 6 May 2020 13:05:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729414AbgEFRFb (ORCPT ); Wed, 6 May 2020 13:05:31 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3E2FC061A0F; Wed, 6 May 2020 10:05:30 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id f11so3206517ljp.1; Wed, 06 May 2020 10:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i6DgO5+TRdDJq45v1B/zETVA5zYOWCANdfi6IDZAE08=; b=nJ/sVN4kSr6t9IdoSsZPyyOmbUtLWQu7s5b311BEDJvl06V1lFO2Wk5poGrlIbZsWG G8EybU7nSnwfFfkbvCXPrcZUZQIqm16wZ+rPp0O3hQE0JEcsYsFTb3O3J/N12j9y2gzY RBKwbVGcFBA26M8N0u/dDpO8IVTP26eaMkcKJ0052VehWgaqhfAqoGIcUzS/bm+YkiGh Ky74G8aJ+0xjJNlTypLKNlTCx+b/tYENL6cUTpTDZwR/eERinbs/nmOg/5KfmgeHFH8G DQemBq3wpqRb34Ade7odH7pdEztMk6j5BPSz1mhgc2rrp7b5WDgNZtw5mGMw6mWcU5J2 Vzgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i6DgO5+TRdDJq45v1B/zETVA5zYOWCANdfi6IDZAE08=; b=X/DJ7g8LVCJd9Mwys2iRezV9obV/srv9ag8+BsKWBCQ1c0MvG/9ou3Gm0YYFWDUShY tvOzxj1Gm1U3URAnukF+bFuWqE6qYdwV0xnuOnH4/KfXstGMWaXd0740ajC41xLhNOoc V1WdeBKgyzR14OeHpwYkl43vCTSl5/8Wf+XISW3nCl9JiQPgKuhQ1tw5adl3DUki6Suw 8QTVfpCM+yAOF6K6iN5hlXcWA1pFmDBWj3ZdfvNdEfRPmKwIDOiEggduIbs6BdmwErlU Fshge/A99aQifaAsHxAFCPGB3p2V+NJ1LEaZDdkoPUt/3NZ+6MkN33yku5cUjD39CmId PKsQ== X-Gm-Message-State: AGi0PuaNgC34bypz34amyowUGNL1187KFnR0e/KNZR15JGCFA5R4BA+8 vSlykkGs70s0mVuUGf3m0CA3doJg X-Google-Smtp-Source: APiQypKTUTxtYqnFPuX+HwJKBbGWBlPEj9Ko1LNSd7vmorqXwvlYb84XnkdhwewUOEpEiJLOYMc43Q== X-Received: by 2002:a2e:80c1:: with SMTP id r1mr5389478ljg.227.1588784729261; Wed, 06 May 2020 10:05:29 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id d9sm1971851lfa.77.2020.05.06.10.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2020 10:05:28 -0700 (PDT) Subject: Re: [PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence To: Sam Ravnborg Cc: Thierry Reding , Laurent Pinchart , Rob Herring , Frank Rowand , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20200418170703.1583-1-digetx@gmail.com> <20200418170703.1583-3-digetx@gmail.com> <20200506164133.GB19296@ravnborg.org> From: Dmitry Osipenko Message-ID: Date: Wed, 6 May 2020 20:05:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200506164133.GB19296@ravnborg.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 06.05.2020 19:41, Sam Ravnborg пишет: > On Sat, Apr 18, 2020 at 08:06:59PM +0300, Dmitry Osipenko wrote: >> When graph isn't defined in a device-tree, the of_graph_get_remote_node() >> prints a noisy error message, telling that port node is not found. This is >> undesirable behaviour in our case because absence of a panel/bridge graph >> is a valid case. Let's check presence of the local port in a device-tree >> before proceeding with parsing the graph. >> >> Signed-off-by: Dmitry Osipenko > Reviewed-by: Sam Ravnborg Thank you again for taking a look at these patches! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 118A1C38A24 for ; Thu, 7 May 2020 07:05:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB249208CA for ; Thu, 7 May 2020 07:05:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nJ/sVN4k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB249208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4EA66E93A; Thu, 7 May 2020 07:05:24 +0000 (UTC) Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E90B6E8B7 for ; Wed, 6 May 2020 17:05:31 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id g4so3194657ljl.2 for ; Wed, 06 May 2020 10:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i6DgO5+TRdDJq45v1B/zETVA5zYOWCANdfi6IDZAE08=; b=nJ/sVN4kSr6t9IdoSsZPyyOmbUtLWQu7s5b311BEDJvl06V1lFO2Wk5poGrlIbZsWG G8EybU7nSnwfFfkbvCXPrcZUZQIqm16wZ+rPp0O3hQE0JEcsYsFTb3O3J/N12j9y2gzY RBKwbVGcFBA26M8N0u/dDpO8IVTP26eaMkcKJ0052VehWgaqhfAqoGIcUzS/bm+YkiGh Ky74G8aJ+0xjJNlTypLKNlTCx+b/tYENL6cUTpTDZwR/eERinbs/nmOg/5KfmgeHFH8G DQemBq3wpqRb34Ade7odH7pdEztMk6j5BPSz1mhgc2rrp7b5WDgNZtw5mGMw6mWcU5J2 Vzgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i6DgO5+TRdDJq45v1B/zETVA5zYOWCANdfi6IDZAE08=; b=e8dhcX1dFs4MLqQ9KnwUf9GLqf2tB2cd4OqZgr133ifaPCoRA3lCh5dU50+5DpgmVx iLp0cLUtMxFE9Nb34NeoOUWieK4sQmlV8BlU3duJIhvV6Vm39j4JYmy1c0KRLbQnWWjg XSBb2oAZ6qZyRo+ecvteF3x01Pv0qCqXfiALMq1SbvGoVZoJwLYhbwGVSuiZbPFm6wNn fIh2IpxJFwlYMSOV4hTcnZ2Ij2oFmj58a3lv56ryx3YsgcrgRLkaFsilqwRw++wpd6Ou GlKGl29772r9uGnvNPGIBtcdUM3YfN4CgSeZAy5h4wgjfn3GT+6UAT/QPFInV7brXrX1 u+Lw== X-Gm-Message-State: AGi0Pua+l9mzvF0OxQAALyWeD3K1cKn+i02fvbQAOgEs7hDogxXy9PI2 DvOtC0Z+Rs4mFjCNiwcZipscuvpu X-Google-Smtp-Source: APiQypKTUTxtYqnFPuX+HwJKBbGWBlPEj9Ko1LNSd7vmorqXwvlYb84XnkdhwewUOEpEiJLOYMc43Q== X-Received: by 2002:a2e:80c1:: with SMTP id r1mr5389478ljg.227.1588784729261; Wed, 06 May 2020 10:05:29 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id d9sm1971851lfa.77.2020.05.06.10.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2020 10:05:28 -0700 (PDT) Subject: Re: [PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence To: Sam Ravnborg References: <20200418170703.1583-1-digetx@gmail.com> <20200418170703.1583-3-digetx@gmail.com> <20200506164133.GB19296@ravnborg.org> From: Dmitry Osipenko Message-ID: Date: Wed, 6 May 2020 20:05:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200506164133.GB19296@ravnborg.org> Content-Language: en-US X-Mailman-Approved-At: Thu, 07 May 2020 07:05:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Laurent Pinchart , linux-tegra@vger.kernel.org, Frank Rowand Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MDYuMDUuMjAyMCAxOTo0MSwgU2FtIFJhdm5ib3JnINC/0LjRiNC10YI6Cj4gT24gU2F0LCBBcHIg MTgsIDIwMjAgYXQgMDg6MDY6NTlQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+PiBX aGVuIGdyYXBoIGlzbid0IGRlZmluZWQgaW4gYSBkZXZpY2UtdHJlZSwgdGhlIG9mX2dyYXBoX2dl dF9yZW1vdGVfbm9kZSgpCj4+IHByaW50cyBhIG5vaXN5IGVycm9yIG1lc3NhZ2UsIHRlbGxpbmcg dGhhdCBwb3J0IG5vZGUgaXMgbm90IGZvdW5kLiBUaGlzIGlzCj4+IHVuZGVzaXJhYmxlIGJlaGF2 aW91ciBpbiBvdXIgY2FzZSBiZWNhdXNlIGFic2VuY2Ugb2YgYSBwYW5lbC9icmlkZ2UgZ3JhcGgK Pj4gaXMgYSB2YWxpZCBjYXNlLiBMZXQncyBjaGVjayBwcmVzZW5jZSBvZiB0aGUgbG9jYWwgcG9y dCBpbiBhIGRldmljZS10cmVlCj4+IGJlZm9yZSBwcm9jZWVkaW5nIHdpdGggcGFyc2luZyB0aGUg Z3JhcGguCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWls LmNvbT4KPiBSZXZpZXdlZC1ieTogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPgoKVGhh bmsgeW91IGFnYWluIGZvciB0YWtpbmcgYSBsb29rIGF0IHRoZXNlIHBhdGNoZXMhCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=