From: Bagas Sanjaya <bagasdotme@gmail.com>
To: David Cantrell via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: David Cantrell <david@cantrell.org.uk>
Subject: Re: [PATCH v2 2/2] if a file has been staged we don't want to list it
Date: Wed, 16 Mar 2022 18:45:20 +0700 [thread overview]
Message-ID: <f2913941-7475-c28e-22b2-8acea041b5bb@gmail.com> (raw)
In-Reply-To: <16aa4d0b2e4fdf4d807723a9aeb64ca7efb43233.1647305547.git.gitgitgadget@gmail.com>
On 15/03/22 07.52, David Cantrell via GitGitGadget wrote:
> From: David Cantrell <david@cantrell.org.uk>
>
> The previous use of --committable would include files that
> had been `git add`ed, but for which a simple `git restore filename`
> doesn't work. --modifed only lists those whose modifications have
> not been staged.
>
The patch title you wrote descriptive mood instead of imperative
one. It should have been "don't list staged files".
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-03-16 11:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 21:07 [PATCH] tab completion of filenames for 'git restore' David Cantrell via GitGitGadget
2022-03-13 6:45 ` Junio C Hamano
2022-03-14 23:45 ` David Cantrell
2022-03-15 10:23 ` Junio C Hamano
2022-03-15 0:52 ` [PATCH v2 0/2] Improved bash tab completion for 'git restore' - adds support for auto-completing filenames David Cantrell via GitGitGadget
2022-03-15 0:52 ` [PATCH v2 1/2] tab completion of filenames for 'git restore' David Cantrell via GitGitGadget
2022-03-15 0:52 ` [PATCH v2 2/2] if a file has been staged we don't want to list it David Cantrell via GitGitGadget
2022-03-16 11:45 ` Bagas Sanjaya [this message]
2022-03-15 11:23 ` [PATCH v2 0/2] Improved bash tab completion for 'git restore' - adds support for auto-completing filenames Junio C Hamano
2022-03-15 16:27 ` Junio C Hamano
2022-03-15 22:13 ` [PATCH v3] tab completion of filenames for 'git restore' David Cantrell via GitGitGadget
2022-03-16 0:44 ` Junio C Hamano
2022-03-17 22:16 ` David Cantrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2913941-7475-c28e-22b2-8acea041b5bb@gmail.com \
--to=bagasdotme@gmail.com \
--cc=david@cantrell.org.uk \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.