From: Jan Beulich <jbeulich@suse.com>
To: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Shawn Anastasio" <sanastasio@raptorengineering.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Bob Eshleman" <bobbyeshleman@gmail.com>,
"Connor Davis" <connojdavis@gmail.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1] xen/config.h: Move BITS_PER_* definitions from asm/config.h to xen/config.h
Date: Thu, 27 Mar 2025 14:37:12 +0100 [thread overview]
Message-ID: <f294e2b1-db03-46b2-b46d-61e89b55cef3@suse.com> (raw)
In-Reply-To: <34c4ba5e-3d06-45af-9c73-e4f160f6d74e@gmail.com>
On 27.03.2025 13:51, Oleksii Kurochko wrote:
>
> On 3/27/25 9:18 AM, Jan Beulich wrote:
>> On 26.03.2025 18:47, Oleksii Kurochko wrote:
>>> --- a/xen/include/xen/config.h
>>> +++ b/xen/include/xen/config.h
>>> @@ -98,4 +98,13 @@
>>> #define ZERO_BLOCK_PTR ((void *)-1L)
>>> #endif
>>>
>>> +#define BYTES_PER_LONG __SIZEOF_LONG__
>>> +
>>> +#define BITS_PER_BYTE __CHAR_BIT__
>>> +#define BITS_PER_INT (__SIZEOF_INT__ << 3)
>>> +#define BITS_PER_LONG (BYTES_PER_LONG << 3)
>>> +#define BITS_PER_LLONG (__SIZEOF_LONG_LONG__ << 3)
>>> +
>>> +#define POINTER_ALIGN __SIZEOF_POINTER__
>> Just one remark here: Imo this needs to come with a comment, as alignment and
>> size aren't necessarily tied together. It's merely that we assume that
>> sizeof(void *) == __alignof(void *).
>
> I will added the following comment then:
> /* it is assumed that sizeof(void *) == __alignof(void *) */
Ftaod - starting with a capital letter, to be in line with ./CODING_STYLE.
Jan
prev parent reply other threads:[~2025-03-27 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 17:47 [PATCH v1] xen/config.h: Move BITS_PER_* definitions from asm/config.h to xen/config.h Oleksii Kurochko
2025-03-27 0:44 ` Andrew Cooper
2025-03-27 8:21 ` Jan Beulich
2025-03-27 12:53 ` Andrew Cooper
2025-03-27 13:36 ` Jan Beulich
2025-03-27 12:50 ` Oleksii Kurochko
2025-03-27 13:16 ` Jan Beulich
2025-03-27 16:12 ` Oleksii Kurochko
2025-03-27 16:14 ` Jan Beulich
2025-03-27 8:18 ` Jan Beulich
2025-03-27 12:51 ` Oleksii Kurochko
2025-03-27 13:37 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f294e2b1-db03-46b2-b46d-61e89b55cef3@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=bertrand.marquis@arm.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sanastasio@raptorengineering.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.