From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/8] mhi: pci-generic: Increase number of hardware events
Date: Fri, 13 Nov 2020 08:56:28 -0800 [thread overview]
Message-ID: <f295df264af652d2b093e7b5ab7057d9@codeaurora.org> (raw)
In-Reply-To: <1605279602-18749-2-git-send-email-loic.poulain@linaro.org>
On 2020-11-13 06:59, Loic Poulain wrote:
> If the IPA (IP hardware accelerator) is starved of event ring elements,
> the modem is crashing (SDX55). That can be prevented by setting a
> larger number of events (i.e 2 x number of channel ring elements).
>
> Tested with FN980m module.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
> drivers/bus/mhi/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c
> b/drivers/bus/mhi/pci_generic.c
> index e3df838..13a7e4f 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -91,7 +91,7 @@ struct mhi_pci_dev_info {
>
> #define MHI_EVENT_CONFIG_HW_DATA(ev_ring, ch_num) \
> { \
> - .num_elements = 128, \
> + .num_elements = 256, \
> .irq_moderation_ms = 5, \
> .irq = (ev_ring) + 1, \
> .priority = 1, \
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-11-13 16:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:59 [PATCH 0/8] mhi: pci_generic: Misc improvements Loic Poulain
2020-11-13 14:59 ` [PATCH 1/8] mhi: pci-generic: Increase number of hardware events Loic Poulain
2020-11-13 16:56 ` Bhaumik Bhatt [this message]
2020-11-18 3:54 ` Hemant Kumar
2020-11-18 8:26 ` Loic Poulain
2020-11-19 1:50 ` Hemant Kumar
2020-11-19 9:42 ` Loic Poulain
2020-11-13 14:59 ` [PATCH 2/8] mhi: pci-generic: Perform hard reset on remove Loic Poulain
2020-11-19 1:46 ` Hemant Kumar
2020-11-19 9:21 ` Loic Poulain
2020-11-25 17:41 ` Jeffrey Hugo
2020-11-27 16:21 ` Loic Poulain
2020-12-02 1:54 ` Bhaumik Bhatt
2020-11-13 14:59 ` [PATCH 3/8] mhi: pci_generic: Enable burst mode for hardware channels Loic Poulain
2020-11-13 17:06 ` Bhaumik Bhatt
2020-11-13 14:59 ` [PATCH 4/8] mhi: pci_generic: Add support for reset Loic Poulain
2020-11-13 17:12 ` Bhaumik Bhatt
2020-11-13 17:42 ` Loic Poulain
2020-11-13 17:44 ` Bhaumik Bhatt
2020-11-13 14:59 ` [PATCH 5/8] mhi: pci_generic: Add suspend/resume/recovery procedure Loic Poulain
2020-11-19 2:21 ` Hemant Kumar
2020-11-19 9:54 ` Loic Poulain
2020-11-13 15:00 ` [PATCH 6/8] mhi: pci_generic: Add PCI error handlers Loic Poulain
2020-11-13 15:00 ` [PATCH 7/8] mhi: pci_generic: Add health-check Loic Poulain
2020-11-13 15:00 ` [PATCH 8/8] mhi: pci_generic: Increase controller timeout value Loic Poulain
2020-11-13 17:08 ` Bhaumik Bhatt
2020-11-25 20:23 ` Hemant Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f295df264af652d2b093e7b5ab7057d9@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.