All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
	"ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"hch@infradead.org" <hch@infradead.org>,
	"tom81094@gmail.com" <tom81094@gmail.com>,
	"paolo.valente@linaro.org" <paolo.valente@linaro.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
	"john.garry@huawei.com" <john.garry@huawei.com>,
	"osandov@fb.com" <osandov@fb.com>,
	"loberman@redhat.com" <loberman@redhat.com>
Subject: Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops
Date: Fri, 13 Oct 2017 10:33:40 -0600	[thread overview]
Message-ID: <f2a74e2c-31ac-e366-83d1-9837531daddf@kernel.dk> (raw)
In-Reply-To: <1507912260.13345.0.camel@wdc.com>

On 10/13/2017 10:31 AM, Bart Van Assche wrote:
> On Sat, 2017-10-14 at 00:07 +0800, Ming Lei wrote:
>> Actually it is in hot path, for example, lpfc and qla2xx's queue depth is 3,
> 
> Sorry but I doubt whether that is correct. More in general, I don't know any modern
> storage HBA for which the default queue depth is so low.

That does seem insanely low. BTW, even a low depth isn't an issue, as long as
we know what it roughly is.


-- 
Jens Axboe

  reply	other threads:[~2017-10-13 16:33 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 18:36 [PATCH V7 0/6] blk-mq-sched: improve sequential I/O performance Ming Lei
2017-10-12 18:36 ` [PATCH V7 1/6] blk-mq-sched: fix scheduler bad performance Ming Lei
2017-10-12 18:37 ` [PATCH V7 2/6] blk-mq-sched: move actual dispatching into one helper Ming Lei
2017-10-12 18:37 ` [PATCH V7 3/6] sbitmap: introduce __sbitmap_for_each_set() Ming Lei
2017-10-12 18:37 ` [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops Ming Lei
2017-10-12 18:46   ` Jens Axboe
2017-10-13  0:19     ` Ming Lei
2017-10-13 14:44       ` Jens Axboe
2017-10-13 16:07         ` Ming Lei
2017-10-13 16:19           ` Jens Axboe
2017-10-13 16:21             ` Ming Lei
2017-10-13 16:28               ` Jens Axboe
2017-10-13 16:31           ` Bart Van Assche
2017-10-13 16:31             ` Bart Van Assche
2017-10-13 16:33             ` Jens Axboe [this message]
2017-10-13 16:45             ` Ming Lei
2017-10-13 17:08               ` Bart Van Assche
2017-10-13 17:08                 ` Bart Van Assche
2017-10-13 17:29                 ` Ming Lei
2017-10-13 17:47                   ` Bart Van Assche
2017-10-13 17:47                     ` Bart Van Assche
2017-10-16 11:30                   ` Hannes Reinecke
2017-10-16 16:06                     ` Bart Van Assche
2017-10-16 16:06                       ` Bart Van Assche
2017-10-17  1:29                     ` Ming Lei
2017-10-17  6:38                       ` Hannes Reinecke
2017-10-17  9:36                         ` Ming Lei
2017-10-17 18:09                         ` Bart Van Assche
2017-10-13 16:17         ` Ming Lei
2017-10-13 16:20           ` Jens Axboe
2017-10-13 16:22             ` Ming Lei
2017-10-13 16:28               ` Jens Axboe
2017-10-12 18:37 ` [PATCH V7 5/6] blk-mq-sched: improve dispatching from sw queue Ming Lei
2017-10-12 18:48   ` Bart Van Assche
2017-10-13  0:20     ` Ming Lei
2017-10-12 18:37 ` [PATCH V7 6/6] SCSI: implement .get_budget and .put_budget for blk-mq Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2a74e2c-31ac-e366-83d1-9837531daddf@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Bart.VanAssche@wdc.com \
    --cc=hch@infradead.org \
    --cc=john.garry@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=ming.lei@redhat.com \
    --cc=oleksandr@natalenko.name \
    --cc=osandov@fb.com \
    --cc=paolo.valente@linaro.org \
    --cc=tom81094@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.