From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Chao Yu <chao@kernel.org>, xiang@kernel.org
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Yue Hu <zbestahu@gmail.com>,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Sandeep Dhavale <dhavale@google.com>,
Hongbo Li <lihongbo22@huawei.com>
Subject: Re: [PATCH] erofs: fix to add missing tracepoint in erofs_readahead()
Date: Mon, 7 Jul 2025 19:33:59 +0800 [thread overview]
Message-ID: <f2b5d473-7ca0-4800-bcd7-0049fcd9b717@linux.alibaba.com> (raw)
In-Reply-To: <0b45c2d9-a610-4839-baa6-75041a6c37d5@kernel.org>
On 2025/7/7 19:22, Chao Yu wrote:
> On 7/7/25 18:17, Gao Xiang wrote:
>>
>>
>> On 2025/7/7 16:48, Chao Yu wrote:
>>> Commit 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
>>> converts to use iomap interface, it removed trace_erofs_readahead()
>>> tracepoint in the meantime, let's add it back.
>>>
>>> Fixes: 771c994ea51f ("erofs: convert all uncompressed cases to iomap")
>>
>> Thanks Chao, btw, should we add tracepoint to erofs_read_folio() too?
>
> Xiang, I guess it is useful for debug if we can add it, let me figure out
> a patch for that?
Yes, it's up to you if you'd like to submit anothe patch for this.
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
prev parent reply other threads:[~2025-07-07 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 8:48 [PATCH] erofs: fix to add missing tracepoint in erofs_readahead() Chao Yu
2025-07-07 10:17 ` Gao Xiang
2025-07-07 11:22 ` Chao Yu
2025-07-07 11:33 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2b5d473-7ca0-4800-bcd7-0049fcd9b717@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=dhavale@google.com \
--cc=jefflexu@linux.alibaba.com \
--cc=lihongbo22@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.