From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout
Date: Mon, 6 May 2024 16:30:30 +0200 [thread overview]
Message-ID: <f2dc6c0b-c4cf-49c0-947b-3330469c78f7@linux.intel.com> (raw)
In-Reply-To: <20240506133216.wuklmj5g7yshj6uu@zkempczy-mobl2>
Hey,
Den 2024-05-06 kl. 15:32, skrev Zbigniew Kempczyński:
> On Mon, May 06, 2024 at 02:08:27PM +0200, Maarten Lankhorst wrote:
>> Any wait timeouts are currently ignored, which might cause silent
>> failures in test. Be more noisy about them.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> lib/intel_ctx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/intel_ctx.c b/lib/intel_ctx.c
>> index b43dd6391..30325b906 100644
>> --- a/lib/intel_ctx.c
>> +++ b/lib/intel_ctx.c
>> @@ -450,7 +450,7 @@ int __intel_ctx_xe_exec(const intel_ctx_t *ctx, uint64_t ahnd, uint64_t bb_offse
>> goto err;
>>
>> if (!ctx->sync_bind || !ctx->sync_out)
>> - syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
>> + ret = syncobj_wait_err(ctx->fd, &sync_out, 1, INT64_MAX, 0);
>>
>> err:
>> if (!ctx->sync_bind)
>> --
>> 2.43.0
>>
> Yes, you're definitely right:
>
> Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Thanks, pushed!
next prev parent reply other threads:[~2024-05-06 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 12:08 [PATCH i-g-t] lib/intel_ctx: Propagate error from __intel_ctx_xe_exec wait timeout Maarten Lankhorst
2024-05-06 12:17 ` ✗ CI.Patch_applied: failure for " Patchwork
2024-05-06 12:59 ` ✗ CI.xeBAT: " Patchwork
2024-05-06 16:48 ` Kamil Konieczny
2024-05-06 13:14 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-06 13:32 ` [PATCH i-g-t] " Zbigniew Kempczyński
2024-05-06 14:30 ` Maarten Lankhorst [this message]
2024-05-06 13:54 ` ✗ CI.xeFULL: failure for " Patchwork
2024-05-06 17:13 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2dc6c0b-c4cf-49c0-947b-3330469c78f7@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.