From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929D3823CC for ; Wed, 13 Mar 2024 17:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710350773; cv=none; b=IbrfpgcYgzi5r2uzBL0cTmZ52iDUNSgPyA27aJfln80KDncy0d6rpN/KIu9p3JAu/+/M7iNFtaXuYQ/d3vppn/GlXjhKoUo7W0B6kqOp/u+bJUZOrHApPfCV4V7gi8lDIwXmrHjAq09HeHK3knnm+E1pmHpYdrjCHDOLivjWtcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710350773; c=relaxed/simple; bh=pHdBbxIGCsn6bga9ZUWJIdqQzQ/NGDwpmOuAP2belZo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ibx26gv1Mj/Xtquvv7wHvPBXz5wvd8YFw3V3kOrcyUFWvUaSNViukZ8tVe4T48raWir0bxeJI+57M6veZCmYC5WBpO2canfvevzHGlXwyTkRNg2Uux0DyZ9aPux8ChVDUYdyBYrm0CPLH+DF+TszTr2cXpYBCdJeUHHZ6pf3Yao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NSGY+AXi; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NSGY+AXi" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-78850ab4075so4100485a.1 for ; Wed, 13 Mar 2024 10:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710350770; x=1710955570; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/xlPdDv6yvSDgUYLn/3ttkYWsR7atQ5kgTqz8H924Zg=; b=NSGY+AXiEYzkEty2qEK/QLKn4WYRbFi0AtKj+A/9pyOL8Lju6i70CoLZymzX9o1KDr fn/vL2S0jGa8L2LCjlgDXOaYfVLeqcoNWu6ysRe/WjSVA9711pwP5BzTDAwL5FHAO0ok 6DOFx0e8VoLtMegKAInLRtWkfVrB/Xu0unB6eLBEdavyWku7OnPFKmINd3ShlKCANbQe ZAKRlb86fG6yVmjNnnCk+ZugO793ecQKqxFHVm2kWnox7+RjTlGJH0wKDdwY/NTa7jY2 vOetD1Hk5RRy65b1MXsbDmEk38bz/NxPQcXImzqLq3o9T7vSHmcuUMsiUVhXpe9LWceV jZ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710350770; x=1710955570; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/xlPdDv6yvSDgUYLn/3ttkYWsR7atQ5kgTqz8H924Zg=; b=EvckD0mZf3GPxG36v++gTBo+vjJ1PqiHP9PwbuWSXIDL1KI0dq0yRP8hH7TDj0CSCk 08+bc6VBpgIAUg5qPSFXM7Mm21/TZU875njDLc9Myo2GqEl4eywpe3tvJ3cBTS87FGfp +GZro5tYOLVhtk1+TPgFPjhP5wM/kn9aUtdhPz3vz05nGEET0Y4dCvm709yLyP0NGQZN DJNObRvEfE4UXGgMB0CEzOL0ve6r+V8yxN1HssZI7iySPWrHPL+b/zzoqY/Y5P71IM+f WA0EFZPTnP9NXlRieJvLZ1/vwUd+xNS8xY0Lmr/MOqk5YAvOOgGC158kMrpkqd+29CFj Vpvg== X-Forwarded-Encrypted: i=1; AJvYcCWgaXqbeNhcY0T1APidI+R4sqTK6Hk77XKQ1zj2RnN/vGDDq8LIu3fZ7wP/HqXobEm/ETv96J8D3ABcT0dA0H4MIF29 X-Gm-Message-State: AOJu0YzLsix7l55hvFK3Z8iQ1C+JnwEYDpKAEYy7e/Bo/quIMYg3pYIO msoKGBWWxCDAxfR4wRFF0+uu64kywHVUNdl2e6RejW8y8ZUVAXxl X-Google-Smtp-Source: AGHT+IFyyiGiWin6XQHjnKeLqB0dBkLVo4kmfRKf8luDrrfr/cY3NN2DX7JZ46wiVXxtXIKQSkqJLg== X-Received: by 2002:a05:620a:178e:b0:787:a83a:cfed with SMTP id ay14-20020a05620a178e00b00787a83acfedmr607731qkb.70.1710350770507; Wed, 13 Mar 2024 10:26:10 -0700 (PDT) Received: from [10.102.4.159] ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id yf23-20020a05620a3bd700b007884b14b0b4sm4888800qkn.51.2024.03.13.10.26.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 10:26:10 -0700 (PDT) Message-ID: Date: Wed, 13 Mar 2024 10:26:06 -0700 Precedence: bulk X-Mailing-List: iwd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support To: Johannes Berg , Karel Balej , dimitri.ledkov@canonical.com Cc: alexandre.torgue@foss.st.com, davem@davemloft.net, dhowells@redhat.com, herbert@gondor.apana.org.au, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcgrof@kernel.org, mcoquelin.stm32@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, iwd@lists.linux.dev References: <005f998ec59e27633b1b99fdf929e40ccfd401c1.camel@sipsolutions.net> Content-Language: en-US From: James Prestwood In-Reply-To: <005f998ec59e27633b1b99fdf929e40ccfd401c1.camel@sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 3/13/24 1:56 AM, Johannes Berg wrote: > Not sure why you're CC'ing the world, but I guess adding a few more > doesn't hurt ... > > On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: >> and I use iwd > This is your problem, the wireless stack in the kernel doesn't use any > kernel crypto code for 802.1X. Yes, the wireless stack has zero bearing on the issue. I think that's what you meant by "problem". IWD has used the kernel crypto API forever which was abruptly broken, that is the problem. The original commit says it was to remove support for sha1 signed kernel modules, but it did more than that and broke the keyctl API. > > I suppose iwd wants to use the kernel infrastructure but has no > fallbacks to other implementations. > johannes > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E656CC54791 for ; Wed, 13 Mar 2024 17:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+7FWP7q20x/LsXZBrhuSGMO5r22veflt9muuwAd+2kQ=; b=QSUqL2dGymeTt0 4mxhchVHN3H34dEvmU1XV8Onlg1MlN+tE37xR+n3OnLg8sn5D2/qOXpjCAGM/+aePGRLUXk4qInzR ROORMSScSv7cbCxHYpOuxXxgOJ4fQwXZaadi1QUJ44GahwiBov3ORDe1/4V+901JiaEaS41P7Axa3 RKfg2yp91dahb1X9y2Hp6GuKbSSTT/ESEujNsg+a+XMRVz35wOImlcIe1h+zAW+qaGwNb8+eWOkqD eRgWDSK3HOumBRYOPLSGfldcdaQtKWFfNae8ZYwDmbWZzAkfOmK2mfFXstkICLyNkiJHR7WTCpRab 6GxqpHsb5kccj4lXH5XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkSMq-0000000B1c2-3Ueg; Wed, 13 Mar 2024 17:26:16 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkSMn-0000000B1Zr-42SM for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 17:26:15 +0000 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-78850ab4075so4100285a.1 for ; Wed, 13 Mar 2024 10:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710350770; x=1710955570; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/xlPdDv6yvSDgUYLn/3ttkYWsR7atQ5kgTqz8H924Zg=; b=M/JSxpBz4Vc0wW+SIfPgoa6K09XIjtkuDQ+p31pOWMxJ/hWKjljdcq0AitWM0Dd9ZV QajU9WiedAd61wWCYdHcEpOuk2yl4SO2j+zz95nZGInS9w2QBW9jkaKaLGe6fW9cLLzH xiiBXKiF5qLMULmF53ZaLXU4e8yz8cnuZ4mX1eqA93kfVD++wAjsl/eUvdSUpxoqrC5b /f6a+geswvP4cINx/+dkJGrKBO5d4jltMJsNJTV9KzBGkMdtJg6wKMS4mmRgzAc4xGvF OVcZv3Dkh/H9MWWzOrX/mvH520n+AaHqWEYxd8NKvtarJj04+Rgx+Ok/D8kwE0YsjBeA t/MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710350770; x=1710955570; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/xlPdDv6yvSDgUYLn/3ttkYWsR7atQ5kgTqz8H924Zg=; b=UFtWbK1FInD3HdzBjh/6j6UaWAgv6YR9qKrzqH7PKQG8xOvZTHcuy7xbpAkufkigZE Zz5/6rxlltjclLEfuVfodlzTUyND/Hrh/f94D1lYGEcBoSsoyMlzZSylIW77Fcrw+6um WtXRQMEclb5Qy2Ed3ahuxdZVQFZn08YjkSfagoupr2p3XFxQaGMfZY0BKWXltZlcpGTt 5V8HiEdc65zXiuI1BOnn55nd3V0ppqXcOjT5s2Bf3T9Wccc3h7XQXTJ9aGrirRfhk3L7 XvtfN1QydfqmHdTWL3T4PhiljFAe0gjJK26IgLiu36LRVWfWptTlWZP3ySZLxmEJ+/XR FWuw== X-Forwarded-Encrypted: i=1; AJvYcCUOZ+gkwm0IRHqT1m8bmc6cNGN+JmfcTsVWhFu8rBNXa2DzyTH9ZIL//L7LMcg/osUqZx2j8/ZYAAFL0ErtnTciPhApX8H5zbxIGa2WbuHEnypSdG0= X-Gm-Message-State: AOJu0YyBG8I68matSt3LyQ9yEjnd78Trf/maBwaasNJN3OMojsvjCBd+ H3JlvmZOqf36sR7ybxCnQ8Uwwj6vGfrwzHiUM4qP5Kr5gB7lmw/X X-Google-Smtp-Source: AGHT+IFyyiGiWin6XQHjnKeLqB0dBkLVo4kmfRKf8luDrrfr/cY3NN2DX7JZ46wiVXxtXIKQSkqJLg== X-Received: by 2002:a05:620a:178e:b0:787:a83a:cfed with SMTP id ay14-20020a05620a178e00b00787a83acfedmr607731qkb.70.1710350770507; Wed, 13 Mar 2024 10:26:10 -0700 (PDT) Received: from [10.102.4.159] ([208.195.13.130]) by smtp.gmail.com with ESMTPSA id yf23-20020a05620a3bd700b007884b14b0b4sm4888800qkn.51.2024.03.13.10.26.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 10:26:10 -0700 (PDT) Message-ID: Date: Wed, 13 Mar 2024 10:26:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REGRESSION] Re: [PATCH] crypto: pkcs7: remove sha1 support To: Johannes Berg , Karel Balej , dimitri.ledkov@canonical.com Cc: alexandre.torgue@foss.st.com, davem@davemloft.net, dhowells@redhat.com, herbert@gondor.apana.org.au, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcgrof@kernel.org, mcoquelin.stm32@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, iwd@lists.linux.dev References: <005f998ec59e27633b1b99fdf929e40ccfd401c1.camel@sipsolutions.net> Content-Language: en-US From: James Prestwood In-Reply-To: <005f998ec59e27633b1b99fdf929e40ccfd401c1.camel@sipsolutions.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_102614_039695_98A2FEF6 X-CRM114-Status: GOOD ( 14.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 3/13/24 1:56 AM, Johannes Berg wrote: > Not sure why you're CC'ing the world, but I guess adding a few more > doesn't hurt ... > > On Wed, 2024-03-13 at 09:50 +0100, Karel Balej wrote: >> and I use iwd > This is your problem, the wireless stack in the kernel doesn't use any > kernel crypto code for 802.1X. Yes, the wireless stack has zero bearing on the issue. I think that's what you meant by "problem". IWD has used the kernel crypto API forever which was abruptly broken, that is the problem. The original commit says it was to remove support for sha1 signed kernel modules, but it did more than that and broke the keyctl API. > > I suppose iwd wants to use the kernel infrastructure but has no > fallbacks to other implementations. > johannes > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel