All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sarthak Sharma <sarthak.sharma@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R . Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@suse.com>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	John Hubbard <jhubbard@nvidia.com>,
	Kalesh Singh <kaleshsingh@google.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Park Tae-sun <ts930@dgu.ac.kr>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 00/12] improve mremap_test
Date: Wed, 11 Nov 2026 15:43:44 +0530	[thread overview]
Message-ID: <f2df3351-ccc8-44c6-bcfc-d380264fb8fd@arm.com> (raw)
In-Reply-To: <20261102100211.141831-1-sarthak.sharma@arm.com>



On 11/2/26 3:31 PM, Sarthak Sharma wrote:
> This series fixes correctness issues in mremap_test, simplifies its
> test infrastructure and strengthens validation of remapped mappings.
> 
> Patches 1-3 remove unused command line handling, unnecessary cleanup
> checks and redundant errno handling. Patch 4 converts the test to use
> kselftest helpers and removes manual failure tracking.
> 
> Patches 5-8 fix handling of unavailable userfaultfd support, unexpected
> mremap() successes, data-corruption failures and cleanup after mmap()
> failures. Patch 9 removes perf tests and timing infrastructure.
> 
> Patches 10 and 11 replace threshold-based random-data validation with
> sampled validation and a deterministic data pattern. Patch 12
> strengthens multi VMA validation by also checking the mapping state
> of holes after remapping.
> 
> This is a resend of v2 without any changes.

Hi,

It has been some time since I've posted this series (v1 posted around 2 
months back :)) but it hasn't been reviewed enough. Requesting for some 
review on this series, if someone has some time to look at it.

> 
> Changes in v2:
> - Add a first patch to remove command-line options (David)
> - Add a second patch to remove munmap() checks from cleanup paths (David)
> - Add a third patch to simplify errno handling
> - Drop the "correct multiple VMA range size" patch
> - Add an eighth patch to fix cleanup after target mmap() failures
> - Replace fully populating and validating large mappings with
>    populating and validating 10 pages each from the start, middle
>    and end (David)
> - Extend multi VMA strengthening to userfaultfd multi VMA test
> - Fix minor formatting issues
> 
> Previous versions:
> v2: https://lore.kernel.org/all/20261006092511.145776-1-sarthak.sharma@arm.com/
> v1: https://lore.kernel.org/all/20260924050009.19974-1-sarthak.sharma@arm.com/
> 
> ---
> Sarthak Sharma (12):
>    selftests/mm: mremap_test: remove command line options
>    selftests/mm: mremap_test: drop munmap() checks from cleanup paths
>    selftests/mm: mremap_test: simplify errno handling
>    selftests/mm: mremap_test: use kselftest helpers
>    selftests/mm: mremap_test: skip test when userfaultfd is unavailable
>    selftests/mm: mremap_test: fail unexpected mremap successes
>    selftests/mm: mremap_test: fail on data corruption
>    selftests/mm: mremap_test: handle cleanup after mmap failures
>    selftests/mm: mremap_test: remove perf tests and timing
>    selftests/mm: mremap_test: replace validation threshold with sampled
>      checks
>    selftests/mm: mremap_test: replace random data with deterministic
>      pattern
>    selftests/mm: mremap_test: strengthen multi VMA validation
> 
>   tools/testing/selftests/mm/mremap_test.c | 701 ++++++++++-------------
>   1 file changed, 291 insertions(+), 410 deletions(-)
> 


  parent reply	other threads:[~2026-11-11 10:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 10:01 [PATCH RESEND v2 00/12] improve mremap_test Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 01/12] selftests/mm: mremap_test: remove command line options Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 02/12] selftests/mm: mremap_test: drop munmap() checks from cleanup paths Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 03/12] selftests/mm: mremap_test: simplify errno handling Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 04/12] selftests/mm: mremap_test: use kselftest helpers Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 05/12] selftests/mm: mremap_test: skip test when userfaultfd is unavailable Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 06/12] selftests/mm: mremap_test: fail unexpected mremap successes Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 07/12] selftests/mm: mremap_test: fail on data corruption Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 08/12] selftests/mm: mremap_test: handle cleanup after mmap failures Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 09/12] selftests/mm: mremap_test: remove perf tests and timing Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 10/12] selftests/mm: mremap_test: replace validation threshold with sampled checks Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 11/12] selftests/mm: mremap_test: replace random data with deterministic pattern Sarthak Sharma
2026-11-02 10:02 ` [PATCH RESEND v2 12/12] selftests/mm: mremap_test: strengthen multi VMA validation Sarthak Sharma
2026-11-11 10:13 ` Sarthak Sharma [this message]
2026-11-16 15:51 ` [PATCH RESEND v2 00/12] improve mremap_test Lorenzo Stoakes (ARM)
2026-11-17 10:12   ` Sarthak Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2df3351-ccc8-44c6-bcfc-d380264fb8fd@arm.com \
    --to=sarthak.sharma@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=david@kernel.org \
    --cc=jhubbard@nvidia.com \
    --cc=kaleshsingh@google.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=ts930@dgu.ac.kr \
    --cc=vbabka@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.