From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH] fix the kernel panic due to wrong use the dev memory API Date: Mon, 5 Nov 2018 11:01:38 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by alsa0.perex.cz (Postfix) with ESMTP id 25EAA2678F7 for ; Mon, 5 Nov 2018 18:01:42 +0100 (CET) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "He, Bo" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Cc: "kuninori.morimoto.gx@renesas.com" , "Periyasamy, SriramX" , "Diwakar, Praveen" , "Zhang, Yanmin" , "Singh, Guneshwor O" , "tiwai@suse.com" , "Prakash, Divya1" , "liam.r.girdwood@linux.intel.com" , "guruprasadx.pawse@intel.com" , "Ughreja, Rakesh A" , "Kesapragada, Pardha Saradhi" , "Kale, Sanyog R" List-Id: alsa-devel@alsa-project.org Ck9uIDExLzUvMTggMjoyOSBBTSwgSGUsIEJvIHdyb3RlOgo+IHNrbC0+ZGFpcyBpcyBhbGxvY2F0 ZWQgd2l0aCBkZXZtX2tjYWxsb2MsIGNhbid0IGZyZWUgd2l0aAo+IHRoZSBrcmVhbGxvYy4gTWVt b3J5IGFsbG9jYXRlZCB3aXRoIGRldm0gQVBJIGlzIGF1dG9tYXRpY2FsbHkgZnJlZWQKPiBvbiBk cml2ZXIgZGV0YWNoLCBMaWtlIGFsbCBvdGhlciBkZXZyZXMgcmVzb3VyY2VzLgo+Cj4gUmVmZXIg dG8gZHJpdmVycy9iYXNlL2RldnJlcy5jIGRldm1fa21hbGxvYyBmb3IgbW9yZSBkZXRhaWxzLgoK V2hhdCBjb2RlIGFyZSB5b3UgbG9va2luZyBhdD8KCkkgc2VlIHRoaXMgaW4gdGhlIE1hcmsncyB0 cmVlCgppbnQgc2tsX3BsYXRmb3JtX3JlZ2lzdGVyKHN0cnVjdCBkZXZpY2UgKmRldikKewogwqDC oMKgIGludCByZXQ7CiDCoMKgwqAgc3RydWN0IHNuZF9zb2NfZGFpX2RyaXZlciAqZGFpczsKIMKg wqDCoCBpbnQgbnVtX2RhaXMgPSBBUlJBWV9TSVpFKHNrbF9wbGF0Zm9ybV9kYWkpOwogwqDCoMKg IHN0cnVjdCBoZGFjX2J1cyAqYnVzID0gZGV2X2dldF9kcnZkYXRhKGRldik7CiDCoMKgwqAgc3Ry dWN0IHNrbCAqc2tsID0gYnVzX3RvX3NrbChidXMpOwoKIMKgwqDCoCBJTklUX0xJU1RfSEVBRCgm c2tsLT5wcGxfbGlzdCk7CiDCoMKgwqAgSU5JVF9MSVNUX0hFQUQoJnNrbC0+YmluZF9saXN0KTsK CiDCoMKgwqAgc2tsLT5kYWlzID0ga21lbWR1cChza2xfcGxhdGZvcm1fZGFpLCBzaXplb2Yoc2ts X3BsYXRmb3JtX2RhaSksCiDCoMKgwqAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgR0ZQX0tFUk5FTCk7 CiDCoMKgwqAgaWYgKCFza2wtPmRhaXMpIHsKIMKgwqDCoCDCoMKgwqAgcmV0ID0gLUVOT01FTTsK IMKgwqDCoCDCoMKgwqAgZ290byBlcnI7CiDCoMKgwqAgfQoKIMKgwqDCoCBpZiAoIXNrbC0+dXNl X3RwbGdfcGNtKSB7CiDCoMKgwqAgwqDCoMKgIGRhaXMgPSBrcmVhbGxvYyhza2wtPmRhaXMsIHNp emVvZihza2xfZmVfZGFpKSArCiDCoMKgwqAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgc2l6ZW9mKHNr bF9wbGF0Zm9ybV9kYWkpLCBHRlBfS0VSTkVMKTsKCgpObyB0cmFjZSBvZiBkZXZtIGFzIHlvdSBt ZW50aW9uIGl0PyBJIGNoZWNrZWQgdGhlIENocm9tZSB0cmVlIGFzIHdlbGwgCmFuZCBpdCdzIG5v dCB0aGVyZS4KCldoYXQgYW0gSSBtaXNzaW5nPwoKCj4KPiBTaWduZWQtb2ZmLWJ5OiBoZSwgYm8g PGJvLmhlQGludGVsLmNvbT4KPiAtLS0KPiAgIHNvdW5kL3NvYy9pbnRlbC9za3lsYWtlL3NrbC1w Y20uYyB8IDUgKystLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvc291bmQvc29jL2ludGVsL3NreWxha2Uvc2tsLXBj bS5jIGIvc291bmQvc29jL2ludGVsL3NreWxha2Uvc2tsLXBjbS5jCj4gaW5kZXggODIzZTM5MS4u OTI4ZDMxNCAxMDA2NDQKPiAtLS0gYS9zb3VuZC9zb2MvaW50ZWwvc2t5bGFrZS9za2wtcGNtLmMK PiArKysgYi9zb3VuZC9zb2MvaW50ZWwvc2t5bGFrZS9za2wtcGNtLmMKPiBAQCAtMTQzOCw3ICsx NDM4LDggQEAgaW50IHNrbF9wbGF0Zm9ybV9yZWdpc3RlcihzdHJ1Y3QgZGV2aWNlICpkZXYpCj4g ICAJfQo+ICAgCj4gICAJaWYgKCFza2wtPnVzZV90cGxnX3BjbSkgewo+IC0JCWRhaXMgPSBrcmVh bGxvYyhza2wtPmRhaXMsIHNpemVvZihza2xfZmVfZGFpKSArCj4gKwkJZGV2bV9rZnJlZShkZXYs IHNrbC0+ZGFpcyk7Cj4gKwkJZGFpcyA9IGRldm1fa2NhbGxvYyhkZXYsIHNrbC0+ZGFpcywgc2l6 ZW9mKHNrbF9mZV9kYWkpICsKPiAgIAkJCQlzaXplb2Yoc2tsX3BsYXRmb3JtX2RhaSksIEdGUF9L RVJORUwpOwo+ICAgCQlpZiAoIWRhaXMpIHsKPiAgIAkJCXJldCA9IC1FTk9NRU07Cj4gQEAgLTE0 NzIsNyArMTQ3Myw1IEBAIGludCBza2xfcGxhdGZvcm1fdW5yZWdpc3RlcihzdHJ1Y3QgZGV2aWNl ICpkZXYpCj4gICAJCX0KPiAgIAl9Cj4gICAKPiAtCWtmcmVlKHNrbC0+ZGFpcyk7Cj4gLQo+ICAg CXJldHVybiAwOwo+ICAgfQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5v cmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2Et ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE2CC46475 for ; Mon, 5 Nov 2018 17:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDD7C2081D for ; Mon, 5 Nov 2018 17:01:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDD7C2081D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387692AbeKFCWZ (ORCPT ); Mon, 5 Nov 2018 21:22:25 -0500 Received: from mga06.intel.com ([134.134.136.31]:13575 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387458AbeKFCWZ (ORCPT ); Mon, 5 Nov 2018 21:22:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 09:01:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,468,1534834800"; d="scan'208";a="93821049" Received: from patelp1x-mobl3.amr.corp.intel.com (HELO [10.252.130.246]) ([10.252.130.246]) by FMSMGA003.fm.intel.com with ESMTP; 05 Nov 2018 09:01:39 -0800 Subject: Re: [alsa-devel] [PATCH] fix the kernel panic due to wrong use the dev memory API To: "He, Bo" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Cc: "liam.r.girdwood@linux.intel.com" , "perex@perex.cz" , "tiwai@suse.com" , "Singh, Guneshwor O" , "Periyasamy, SriramX" , "Kale, Sanyog R" , "Kesapragada, Pardha Saradhi" , "kuninori.morimoto.gx@renesas.com" , "guruprasadx.pawse@intel.com" , "Ughreja, Rakesh A" , "Prakash, Divya1" , "Diwakar, Praveen" , "Zhang, Yanmin" References: From: Pierre-Louis Bossart Message-ID: Date: Mon, 5 Nov 2018 11:01:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/18 2:29 AM, He, Bo wrote: > skl->dais is allocated with devm_kcalloc, can't free with > the krealloc. Memory allocated with devm API is automatically freed > on driver detach, Like all other devres resources. > > Refer to drivers/base/devres.c devm_kmalloc for more details. What code are you looking at? I see this in the Mark's tree int skl_platform_register(struct device *dev) {     int ret;     struct snd_soc_dai_driver *dais;     int num_dais = ARRAY_SIZE(skl_platform_dai);     struct hdac_bus *bus = dev_get_drvdata(dev);     struct skl *skl = bus_to_skl(bus);     INIT_LIST_HEAD(&skl->ppl_list);     INIT_LIST_HEAD(&skl->bind_list);     skl->dais = kmemdup(skl_platform_dai, sizeof(skl_platform_dai),                 GFP_KERNEL);     if (!skl->dais) {         ret = -ENOMEM;         goto err;     }     if (!skl->use_tplg_pcm) {         dais = krealloc(skl->dais, sizeof(skl_fe_dai) +                 sizeof(skl_platform_dai), GFP_KERNEL); No trace of devm as you mention it? I checked the Chrome tree as well and it's not there. What am I missing? > > Signed-off-by: he, bo > --- > sound/soc/intel/skylake/skl-pcm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c > index 823e391..928d314 100644 > --- a/sound/soc/intel/skylake/skl-pcm.c > +++ b/sound/soc/intel/skylake/skl-pcm.c > @@ -1438,7 +1438,8 @@ int skl_platform_register(struct device *dev) > } > > if (!skl->use_tplg_pcm) { > - dais = krealloc(skl->dais, sizeof(skl_fe_dai) + > + devm_kfree(dev, skl->dais); > + dais = devm_kcalloc(dev, skl->dais, sizeof(skl_fe_dai) + > sizeof(skl_platform_dai), GFP_KERNEL); > if (!dais) { > ret = -ENOMEM; > @@ -1472,7 +1473,5 @@ int skl_platform_unregister(struct device *dev) > } > } > > - kfree(skl->dais); > - > return 0; > }