From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF81FC19F32 for ; Thu, 6 Mar 2025 00:06:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B69410E877; Thu, 6 Mar 2025 00:06:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="vrhre1ul"; dkim-atps=neutral Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id 611CF10E876 for ; Thu, 6 Mar 2025 00:06:01 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Su4W+otfJi0ERYMfet1gVWhJP1YKYIzil2NnqVfx+Ohq4Esddtt0mw1Ul5m3zmGMWnQNvvkBaa9Chw7BVFl4Fcl9qeHBM/pN/fuBzaabajR2iMe8PqWQUCxRNQIB5X1GJvhTFTbRg+/z2YpgNWMDEMt3ZGW+jhoe8NLsVWPnTuL87Fd/YQfY0zcrcEyG+zaZchV0Nbhlrvxg7EAkSk38BWiJcC+o4yulXXfF+DJ9P23s4j48f6aa5Okjz9tbL3JZxP9Vj+o9nN6ZAh5kiE0MYKpduPf0xkrLIqG9Mf47sCPutMdpZNcgB6GZqC2q0sOxKQF5gCqUCcnRChQAxJ+V/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hbiWh8UHS8PVW3il93Mn/pT9eT5EPuYe7BAFRmZL9lI=; b=psYWxnxBecDwf0kM9lmTJuKjjILIQkB45NR6iKEypnZAB7NQ7QdS6wP0YiJDBUw9jH0i+Iic4YXxcGr7s7f/pACDNbK6hpnsI5rF7k5qRqr0KOjx8M5HYy3zx/n7Zm7Hk0NeHcO7CszdIyKxS3qFGdpBez/5K5KwFGutXq6NnkuChlhRyF1RTGPXQFhInCWIvlTaRFvkImS8BboJgHxz9QZrHkmUbYDIvIwfjc1ztAVYX4kp/iEJqO0riBkvHq7FxlETm1xxBOxVSGPLlyMl1h3RPTDyRlryP0SMsjCRBYW746v2ikbwCSaOybC+xCgZ2c0SoRy2KtRTBLIf4gh9Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hbiWh8UHS8PVW3il93Mn/pT9eT5EPuYe7BAFRmZL9lI=; b=vrhre1ulxC8d9Dm3yvN3PLJ+i0m+4eoDEuXkMOIEAcKfd2Ohh6+htj4XEDDAHMIFiFfjKRGsmdDtx7IwkyW9PQTpGrz/keRRPhzdUT2Kbt6o79o2sxV8f2miGYA7rduFo8gVQvjmZ+vIB1Z7WrKYcCVtl9ziaIoWri4eHCZ/puc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) by LV3PR12MB9412.namprd12.prod.outlook.com (2603:10b6:408:211::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Wed, 5 Mar 2025 23:51:19 +0000 Received: from DM4PR12MB6566.namprd12.prod.outlook.com ([fe80::31b:5d31:8ba6:abd7]) by DM4PR12MB6566.namprd12.prod.outlook.com ([fe80::31b:5d31:8ba6:abd7%4]) with mapi id 15.20.8489.028; Wed, 5 Mar 2025 23:51:19 +0000 Content-Type: multipart/alternative; boundary="------------p7XK99dQTA9RFjKjM0WFxwm0" Message-ID: Date: Wed, 5 Mar 2025 17:51:18 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/amdgpu: Fix missing drain retry fault the last entry To: Emily Deng , amd-gfx@lists.freedesktop.org References: <20250305035409.3204812-1-Emily.Deng@amd.com> Content-Language: en-US From: "Chen, Xiaogang" In-Reply-To: <20250305035409.3204812-1-Emily.Deng@amd.com> X-ClientProxiedBy: SA1P222CA0075.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2c1::22) To DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6566:EE_|LV3PR12MB9412:EE_ X-MS-Office365-Filtering-Correlation-Id: c20963a6-1770-41bf-145d-08dd5c40a052 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TkloS0tIckdYNlhpRXJHc2lmYjM0dDV5cmhjUFpiS1hoa1dDbkcvUk1VdnNR?= =?utf-8?B?V1UwQnpuVHF5MmdENkpiQWliQjdDVGdkZXJTbXExTGdXcUlZUElqR3RNaU14?= =?utf-8?B?MTE3WVlDMmRjekdQcHJQMjVkVjNWVlJ0WnVxV293V2tETTlkdGFON2I5d0Z6?= =?utf-8?B?YVNlOHpCd2treFd3K2xTMnlqbk9ZeDYvREtsZ1RUR3YraXhjTEtBc25Xai8w?= =?utf-8?B?TFU2aFpPaFR6aEg0TmRpT3ZIdzBLNUFNckk4Z1o0MW5VYmRtWTdsRXh0Zk1m?= =?utf-8?B?NUM2MzlVaTZzN1BMN0VJK2d1S04rV2NhaHlJbUpWQ2QyaVFJR3NITEtxeklZ?= =?utf-8?B?UDd5Ykt2T2xVSVFKaTZvZGFjbmxidGdpYjRGMmZIZkxlSVVLOGdQaFZvRzc3?= =?utf-8?B?WmhuTkRpSlRYUHN0czFBOStNem9zNUhkR0FObXcrZi9XS3FjODNIZjBKdHVu?= =?utf-8?B?d1dqUm8yZ1ExZkU0MWxiYWo5YVF1WEZEQUdOYTl5c09LMldtbEZ4UWZta3JN?= =?utf-8?B?aE1ENVIzaXFlWGdqSUJkKzhjTXQ5WkVMTnQyTmdlZFk0Tkt4MklkMjlJbWZN?= =?utf-8?B?OXdnTTNDUEltUjlIYytjd0JObzZrenlyTlkvd3hBMVJQUTVjQUFpVzVkVU41?= =?utf-8?B?QnBNbmNpZ0JVc0ZVUVA1bFlWNWZQZExCRUdvOGQxQ1V6VURjZHZaNndCWlNI?= =?utf-8?B?V3k5MlhsajJxTzVBcFB1WnlPakNORVFVM3pkY2RFemlwcVhoRU5PejZ4M1NH?= =?utf-8?B?S0V0S3crbmhZTEt3ZGZ4ME1yN0F4TnhQQTlKeVI1Q2FYNEo1TUVFTVpXV0lp?= =?utf-8?B?ZFhmM0oyek5SSUJFZXBaWFdQM25UL1RNSk8rZkRDR0FDL1grdEh3aTlVQnd2?= =?utf-8?B?RThtQmgvY2VtRVV6Qzl5b0VESTZJQ2JPalk3V2QwRXA4Y21nTkpSenFBRWZH?= =?utf-8?B?TGlqTGc0WUNoYVVHYlhpTGNSQ2paNStuaTJSUmZkYW1yNlBhTmgzeVVEVG4x?= =?utf-8?B?b3lrSmx1Q2VCMkJXdUI3WnVBSG9weFR0SkV2MVV2Y016SHZsaHI5WEFaemJa?= =?utf-8?B?UEUxc0tDOXRpQVU4cU5ZWGd1a0VOQUZKcXdoaW5WUm5iamRRQTZlZlVBdGI1?= =?utf-8?B?TE5SUm5VQnQ3WGExUVB6ZTVTVXV0aEJQRXdIRHdqbmhWcXVNY2taRDNZdG92?= =?utf-8?B?R1Z3Z0x6eWpITVkwdjYxQTg4NkxwZVJ5NmllTHZ0aThJQmMrYUp1MkIyUnk2?= =?utf-8?B?YUlJdlVDWk1wZGdScU9rUjhGYUZhOG9HWVRzcXMvcURkY25xb1RoVXdOVmg1?= =?utf-8?B?THNCbkdMNGFFeTMyQzVOcTQvYitxZ2RmTmV6eTNZSWVIMkFBQlJpUDlIaGpP?= =?utf-8?B?ckRhWTB4QjVwSlJ2WlNJNW5DcVg3OHE0YVNuRDRhamx2UGxQTFQrZm1hRTlM?= =?utf-8?B?Q01yR0hvelp2Yms0ZVNuMWNFaGtpRDJqNnZwYTRYc0w1VmNpNzRkQzBvMStk?= =?utf-8?B?aStQbDBrUUdCZ2cweGkwQ0hscXRwZk1idUlnRnVrbURvTmdnV3daazM4cnhh?= =?utf-8?B?dmFJV1RaYzhEZ2t5bitYQ2VLMFV3RlFnYW9VSEhXcWpyRjZGR1lHWS9ndWFW?= =?utf-8?B?UjIwalBwQUJRS3lManFVek05dkJ0ZDFOWmw1dmRjaEN6aG9KdXBxU3FCRTdO?= =?utf-8?B?ZDg4VmxyVm9RM2p6U2FoTmQ3Zjc2bFVidi92cGVQM20wOXlUTURzY2hSR1dM?= =?utf-8?B?OGVLTVdVQlNjRG9CS2h1MS94c3pHbnVpTFp6anI0MGpmaEtjQzV1VjlDWk9n?= =?utf-8?B?UjdGa3JkU0QwSnNEMEZUNkZGalBmRkNCZnVmMGM0djVndHVEdEpDVTY5Z3Ja?= =?utf-8?Q?jWEoF8yDQyaT/?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB6566.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0lVS3FLOWhxZDZ5eE9WZm15dmllNWxnWWtiTEg0YjV6VHJLN01DbUxZd29O?= =?utf-8?B?UkN6NGp2RHZUNEtoU3JnNnNRdTBwcWV1VWxHRW9pSnBweStYMkxTRUxGakx4?= =?utf-8?B?TU5TUTQvVGtnYVpBZGI0UXlrWEMwR1VuK3lOaHZnYVRSa2x5VUhuZ3dRcE12?= =?utf-8?B?TVZwSlVVVXRmTUJ2WExRTGd0bW1IODQ4RmE4L2szNWVTQXJJQ0pzOFo3U1NS?= =?utf-8?B?OU9iTGZtRURSTXQrcWwwdllxM1hQNHoxZVdRdWNDYUM0ZWdBUE43WE9rWFVP?= =?utf-8?B?U0J3UEs0NnNuTitMTGhSb2JFZkZVbE9TWW9NSDg5cHZhTEpreHg0YThvR1J0?= =?utf-8?B?aVBmVlhBSjBCSDBPZldtejVMMWdGeHBWbkVtekNXdFFDNXV3RW0vRzJtNHZC?= =?utf-8?B?ZU5nOFVmdHZaajVrT0JnM202d21GY3NHRWdjRU5aOGxWSHBJdjdXNk5MVlVR?= =?utf-8?B?emJ0M1JpVkk0Vzh5azR6anUrQkRUNFRRcGxaclRha25FVHFURFc3RkV2QVA4?= =?utf-8?B?bUJvSmYvS2dZZFZvQit3T1Awa2dJMElRQ3NzNzRLTHJKYStaUnpLRXpFd3NB?= =?utf-8?B?YUk1dGJ0ZnNuUkI2UXM1S0ZNLzIvZjZPeUd1T1RtNjVOUUw2aUR3MFM1cHgr?= =?utf-8?B?MWVXYmNTc2wrekpIZ3BnNEtUNkc4MDE0eTBGSGRidzlCaUttMERDbC9zc1Mx?= =?utf-8?B?enN4aFFXTkpFTSsrOFkvMDdhcGJVSysxNllhcWROb1hqZVkyb2swSGhINjl1?= =?utf-8?B?MlBTSEJtN1dGMC9XVWliYmpScEpHT01TNjRFMzdYNEFDY3V5aFRUanBMb3hX?= =?utf-8?B?T3BRQjlTR21RSXZhTE5QbEJSY3ZKTUNpczlWdlFPdjVPVW43RjFNdkgvbVpU?= =?utf-8?B?OHdOU1BmbE1yNi81QXVnRURNYnpYdkxqMVJuUGVBWHpxejgxTVFmQ1U2STlu?= =?utf-8?B?QzY3d1hhRVlNVS9mMlRSMlpBVnBTczZESU9aNWFkQ252SmhLU3F5bmx6bVJY?= =?utf-8?B?RDBaTjhLcXk2TTVRUWt4TTBwWUR5eDFwRmJPR1EzdkNKQ0FwSVZHM29seXlJ?= =?utf-8?B?UGVrb1hmNWlRaHVzRGNLYXhPZ1l2WmxBVXJsM1IzK0JvN3pubmE5bVA2dVBn?= =?utf-8?B?eDBuaVpXUytGVW9FeUdET1JjdFE0UFlmUHZSRmYrVG11UDhnSlo4MktsMzVB?= =?utf-8?B?amErc09tVUM1WTFDZ0hOS1FVVXNhb1BON0JjVlhTdWgwSHAwOU1DajhEM0lU?= =?utf-8?B?aHRwRzNwMTQ1VzZIMDJvQjhrcEhzQnJTcDJicXN5OWU3Wk5LblJpTkNlcTh6?= =?utf-8?B?ZUNPRGwvcjh5Vk02aWRwWGpidmRXYW5YVG9pb0YyaHNsS0xNQ2VicnB4bXNr?= =?utf-8?B?ZS9lcjFCVE9scVAydS9kQXo1dmc4SnJuWnRVem90cno0SWltMUxBVUNjdGtv?= =?utf-8?B?N3ZGaUpVbWQ2RlpLczEzR1pXWHhUSmg1Rmwwb2NtRlZBMUdwcEZ2QXhYZ2Fk?= =?utf-8?B?ZjFWaWFyUjR0bmxYSUFST0M5KzNnTFhqc015ak5WQU9ITTRGdXRRSzFISW9S?= =?utf-8?B?UTBCMDVjOENQSFhlRXJDcUVBUGMvWmlUQnIvZXBGalprYVRDU3UvY1FwU2Vh?= =?utf-8?B?UDh0K1l4eFdhbXRWeWV4WkhEQjVOeFJScU8zdjBWdnVPYWQ5Z0NPQ3VrKzlH?= =?utf-8?B?eEwva0p1NlA2VjlLRFJ4U2M2WFNPclRHSEE5dXZnMk9UUHdYbk9ZaEdnTzF1?= =?utf-8?B?Q3hwNk1qeElMYldvUmhkaENRMFFTa20wSmM2SkJVRHRtYTk2M2F1MUIxWi9J?= =?utf-8?B?aWoxNksxejl2QkFhWFgvMDZweWM5YjE2R2xvaGJta3pVaUV1b2Z4cFFJZkRY?= =?utf-8?B?d3FHSzFaL0ptbjJ0QlFzQ0ZQYWJNdFp6YUpueG9UMWdkQmJ5MVFmZFQ4L2VB?= =?utf-8?B?Q1NjUDRsMVZRdERlanI3MHpTUHNoQ0tNSlJZMzVGaHdXaUc0Y1FsWEFuRXQ3?= =?utf-8?B?QUFFVFE4aFZBYmZUaFByV1FXWU10QU0vQURNMnNsK2cranNManhLWTFQNy81?= =?utf-8?B?c0M4UWEwRFp1cjV5ckN3QVlQeWE0S09XdEsxbU9xaCtvcTgxclBXKytZWkVP?= =?utf-8?Q?0P+k=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c20963a6-1770-41bf-145d-08dd5c40a052 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6566.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 23:51:19.6126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rhjW3ZKdVEpWUY43wuHER+LtF3opqmW6ANW8bQJ8H4G7kWd1yDEHnCIZ22KlitIZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9412 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --------------p7XK99dQTA9RFjKjM0WFxwm0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Xiaogang Chen On 3/4/2025 9:54 PM, Emily Deng wrote: > While the entry get in svm_range_unmap_from_cpu is the last entry, and > the entry is page fault, it also need to be dropped. So for equal case, > it also need to be dropped. > > v2: > Only modify the svm_range_restore_pages. > > Signed-off-by: Emily Deng > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 3 +++ > drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h > index 7d4395a5d8ac..b0a88f92cd82 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h > @@ -78,6 +78,9 @@ struct amdgpu_ih_ring { > #define amdgpu_ih_ts_after(t1, t2) \ > (((int64_t)((t2) << 16) - (int64_t)((t1) << 16)) > 0LL) > > +#define amdgpu_ih_ts_after_or_equal(t1, t2) \ > + (((int64_t)((t2) << 16) - (int64_t)((t1) << 16)) >= 0LL) > + > /* provided by the ih block */ > struct amdgpu_ih_funcs { > /* ring read/write ptr handling, called from interrupt context */ > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c > index bd3e20d981e0..d04725583f19 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c > @@ -3010,7 +3010,7 @@ svm_range_restore_pages(struct amdgpu_device *adev, unsigned int pasid, > > /* check if this page fault time stamp is before svms->checkpoint_ts */ > if (svms->checkpoint_ts[gpuidx] != 0) { > - if (amdgpu_ih_ts_after(ts, svms->checkpoint_ts[gpuidx])) { > + if (amdgpu_ih_ts_after_or_equal(ts, svms->checkpoint_ts[gpuidx])) { > pr_debug("draining retry fault, drop fault 0x%llx\n", addr); > r = 0; > goto out; --------------p7XK99dQTA9RFjKjM0WFxwm0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


Reviewed-by: Xiaogang Chen<xiaogang.chen@amd.com>

On 3/4/2025 9:54 PM, Emily Deng wrote:
While the entry get in svm_range_unmap_from_cpu is the last entry, and
the entry is page fault, it also need to be dropped. So for equal case,
it also need to be dropped.

v2:
Only modify the svm_range_restore_pages.

Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 3 +++
 drivers/gpu/drm/amd/amdkfd/kfd_svm.c   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h
index 7d4395a5d8ac..b0a88f92cd82 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h
@@ -78,6 +78,9 @@ struct amdgpu_ih_ring {
 #define amdgpu_ih_ts_after(t1, t2) \
 		(((int64_t)((t2) << 16) - (int64_t)((t1) << 16)) > 0LL)
 
+#define amdgpu_ih_ts_after_or_equal(t1, t2) \
+		(((int64_t)((t2) << 16) - (int64_t)((t1) << 16)) >= 0LL)
+
 /* provided by the ih block */
 struct amdgpu_ih_funcs {
 	/* ring read/write ptr handling, called from interrupt context */
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index bd3e20d981e0..d04725583f19 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -3010,7 +3010,7 @@ svm_range_restore_pages(struct amdgpu_device *adev, unsigned int pasid,
 
 	/* check if this page fault time stamp is before svms->checkpoint_ts */
 	if (svms->checkpoint_ts[gpuidx] != 0) {
-		if (amdgpu_ih_ts_after(ts,  svms->checkpoint_ts[gpuidx])) {
+		if (amdgpu_ih_ts_after_or_equal(ts,  svms->checkpoint_ts[gpuidx])) {
 			pr_debug("draining retry fault, drop fault 0x%llx\n", addr);
 			r = 0;
 			goto out;
--------------p7XK99dQTA9RFjKjM0WFxwm0--