All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Checking redundant variable initialisations with SmPL?
Date: Sat, 22 Jun 2019 16:16:54 +0200	[thread overview]
Message-ID: <f3189fec-390f-54a8-ea8b-459ab34ce793@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1906221555220.3253@hadrien>

>>> In that case, it would also be beneficial to remove the *
>>
>> I find the asterisk required here
>
> Yu can do whatever you want, but you will get lotsof false positives if
> you keep it.  If you really want a star on the declaration

I would prefer to use a minus character for the specification
that an unused value should be deleted if corresponding change confidence
can be achieved for the discussed source code analysis pattern
also by the means of the semantic patch language.


> then you need to make two rules.  The first that finds the positions of the places
> that match and the second that only puts a * when there is both a matched
> declaration and a matched reinitialization.  But I wold imagine that from
> the reinitialization, it would be easy to find the declaration, so it
> doesn't seem worth further complicating the rule.

This explanation sounds promising.

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2019-06-22 14:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 12:30 [Cocci] Checking redundant variable initialisations with SmPL? Markus Elfring
2019-06-21 20:52 ` Julia Lawall
2019-06-22 13:15   ` Markus Elfring
2019-06-22 13:19     ` Julia Lawall
2019-06-22 13:35       ` Markus Elfring
2019-06-22 13:58         ` Julia Lawall
2019-06-22 14:16           ` Markus Elfring [this message]
2019-06-23  7:48           ` Markus Elfring
2019-06-23 12:48           ` Markus Elfring
2019-06-23 12:48           ` Markus Elfring
2019-06-23 12:55             ` Julia Lawall
2019-06-23 13:05               ` Markus Elfring
2019-06-23 13:05               ` Markus Elfring
2019-06-23 13:13                 ` Julia Lawall
2019-06-23 14:17                   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3189fec-390f-54a8-ea8b-459ab34ce793@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.