From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 880CB3B14BD for ; Wed, 17 Jun 2026 06:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781676019; cv=none; b=V+ouCmPTOyBFc1aC8p4zmQfWunYDQ5xHa7cmFhsOWpPN60nmBVFQ3PGY+NMqCOgitAT704y8/tPuVOsZEt71IUKettApZ6tGobaWfxXuKygSIeJ7Y88HfAqSm3dr2afu+US6MNGCK+p7VkD7gnMwYbvobwVvjmcKSvjnjAIKjZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781676019; c=relaxed/simple; bh=EPp3+y8U+wDZQ2t1aRvjrkpD6kQKVPXuQaessSYJEI8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IT+99OpHRXOP17C0MK1g15t0DgRi3p+AfxEAHDbAsn3s9ZrtSCHmpIX9ZjOTQWYQRDgu5n6kht3njY2efk97s3kSPcv0CoBwCf834XR6WDfBbqa+Nh40eGhUJojvb/cBQ2Jb79vqtgXS86A3QpVg9QsP/N1EhqHRzZdEEqwetVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eBc2S9g/; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eBc2S9g/" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-396779b9a7fso47193761fa.3 for ; Tue, 16 Jun 2026 23:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781676016; x=1782280816; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Cs8qvTgnQoJy3gVauu2STPsPcaY4YlG12CSyBpLnw6c=; b=eBc2S9g/WVG1RAN4zKzecPQNVMmioA1GaCYMMDOdguMwD/2cQFoW6bPJN2KhjPicoX QR5GwyYGZmDU5P67emxguityVFNvwywFhKcSKbqj95lbibNMfgub8QC9g94uyqD+OqEa rZaH69EBdQIcw/lHlab+TtPSlUigQQa0Z1GrfbuXbvfEgUyqCklT3cAynbTDui17z7sE WnbISAMY4AJqWfSFo6EpdZ/1S2AqTPP3PJ2Q6cUimiDaRf7Czo8o/lUDHl8BIAWDe/7k h66gm+xo16DHTetu5lV26LuC6eMZndolcyJvQyQX1tD7ZIckG493fwwDQbwzGptjS/aB sYng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781676016; x=1782280816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cs8qvTgnQoJy3gVauu2STPsPcaY4YlG12CSyBpLnw6c=; b=mYK2Th/drS0rgEXD05KDnVvb8LM5h4FZu4RPAV34/zMF6Y3jNHZVERPqL8x7Itc6UW rXElDbU3VqHa20Xro+rsztGNbOXjGLpmdC3vXZIQ9e1YojMX8omtrFvl1Zz9qCbWbk73 Hpncfb6EWVIRdKhVGGzPF2v4ogrbC5bUIMXRG87NEvWXRDdfEYCWtON8CrlVntw4/hSE WhZHyxYhMHfTJxFIdZtgUdVN+sIEdGfp6b2F/KSyuSxfnjqTZPlELQiL13jGOOEuobtp NtL1r7WcjGG1UCRy6+0Qai5I/7OS0ZJ4XYetNxmF6TorLasFCTjiQjGuAuEmESZsYWF4 rfbQ== X-Forwarded-Encrypted: i=1; AFNElJ8q6I6RuaFc8riSDx37WfXLdBqtF19syF8bYm90TGtO7nfGxxJMRhXWDU4fjiyM6xRulL0kOZ8O2TBqpA==@vger.kernel.org X-Gm-Message-State: AOJu0YyGQWoUtta5UbgIEFJJPd725euhbd5gBe9qnfoZKO5jPdb7j/NK u+mcLQlGb6zfyfj5WWM9a2Snv/0LuINJuhlGCOCeD6ehogN8cMAF9N3N X-Gm-Gg: Acq92OFxtIc6QJDBqpCR+XRXJPWF5e+gmHHrI3FbF1pSkaDR+dGmotlYq+iobkIdX9X s2ekH2xKWJKC3fLHM+89A4wCZUpEkuUAbVnCcAY+RCvjawWpgMHBicfIkmF2ZA5cYpPCtt1mEtA V3XjHDopmi0K3rEwLEWsgsjHV17RVOa06ndk9dPAQU1S9WlbvEAiaQlCvyC1hdOiPi/TrCbuRQR MWoSA2uLxkkrPal0D8ODgeD1ukywjXW7beCKdgGXwB9BZxlFRhn5nC32Bje3RqrD7oDDNGyBR/D ZUcJzuEhU9Oo4uffuMjU33tT4yzqFLc/3FcySvGYtCkIudZ81KuOFLnv79IThj5AKciqVj15Izs M1Ipz5mwMkxYuOSuWwFLBZFs2qMkZejLgNFeblkPj64gY0kVGOD6O7rYtJg6BSTDOOxLNCoSVx3 TFHGMWbE7tJN9njU4r07qNi/1B0QTzsKPVKRXje+3JDdWYRSTslLKT9s1HmB7NE5DrER4poA== X-Received: by 2002:a05:651c:2124:b0:38b:e464:f047 with SMTP id 38308e7fff4ca-39969ad94b1mr4694531fa.12.1781676015350; Tue, 16 Jun 2026 23:00:15 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3995c04d8b2sm12250531fa.2.2026.06.16.23.00.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 23:00:13 -0700 (PDT) Message-ID: Date: Wed, 17 Jun 2026 09:00:12 +0300 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] hwmon: adm1275: Support module auto-loading To: Guenter Roeck , Matti Vaittinen , Matti Vaittinen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Wensheng Wang , Ashish Yadav , Kim Seer Paller , Cedric Encarnacion , Chris Packham , Yuxi Wang , Charles Hsu , ChiShih Tsai , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <634e76680ed93e58ebeb35db080138b791cb6c27.1781591132.git.mazziesaccount@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/06/2026 17:04, Guenter Roeck wrote: > On 6/15/26 23:47, Matti Vaittinen wrote: >> From: Matti Vaittinen >> >> Populating the spi_device_id -table is not enough to make the >> driver module automatically load when device-tree node for the bd12780 >> is parsed at boot. >> >> Adding the of_device_id tables causes the driver module to be >> automatically load at boot. Testing has been done with rather old Debian >> system. >> >> When inspecting the generated module-aliases with the insmod, following >> entries seem to be the difference: >> >> alias:          of:N*T*Crohm,bd12780C* >> alias:          of:N*T*Crohm,bd12780 >> >> I suspect these are required for the module loading to work. >> >> Signed-off-by: Matti Vaittinen >> >> --- >> >> I did not add of_device_ids for other supported ICs as I can't verify it >> doesn't cause side-effects. Please let me know if you think those IDs >> should be added as well. I would be glad if I got more educated opinion >> on adding the of-IDs :) (I can squash this to 3/7 and 6/7 in next >> revision, and add own patch for adding of-IDs for other ICs if >> required). >> > > I don't know what those side effects might be. I am much more concerned > about side effects of having some of the devices in adm1275_of_match > and some in adm1275_id. So, yes, please add a patch to provide > adm1275_of_match for all chips supported by the driver. It's nice to have an opinion on this as I was really unsure what is the right way forward. Thanks for all the help this far. I'll do that in v2. Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~