All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sidharth Saha <ssaha2000@gmail.com>
To: Matheus Alves de Almeida <matheus.aalmeida@inf.ufrgs.br>,
	Louis Chauvet <louis.chauvet@bootlin.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	Melissa Wen <melissa.srw@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] drm/vkms: support more formats and fix RGB565 regression
Date: Thu, 12 Nov 2026 17:18:56 -0700	[thread overview]
Message-ID: <f3707b72-07f2-41ae-aefa-c46ef84de3e3@gmail.com> (raw)
In-Reply-To: <20260928005301.367977-1-matheus.aalmeida@inf.ufrgs.br>

Hi Matheus,

Following up on my earlier report: I've now written KUnit tests for
the conversions in this series - argb_u16_to_RGB565(),
argb_u16_to_BGR565(), the RGB565/BGR565 read paths, and both the read
and write paths for RGB332 and BGR233 - against hand-computed values:
zero, max, single channels, the midpoint, values either side of each
rounding step, distinct per-channel values, and a read/write round
trip.

All pass with the series applied. Without it, the RGB565 writeback
midpoint and rounding-step cases fail (truncated instead of rounded),
and the RGB565/BGR565 read tests give identical results with and
without the series, so the helper conversion in 3/5 doesn't change
behavior.

For the series:

Tested-by: Sidharth Saha ssaha2000@gmail.com

I'm happy to send the tests as a follow-up series once this lands, or
you're welcome to fold them into a v2.

Thanks,
Sidharth

On 9/27/2026 5:52 PM, Matheus Alves de Almeida wrote:
> Hi,
> 
> This series adds support for RGB332, BGR233 and BGR565 writeback. This
> is done with new helpers added to make conversion easier. It also fixes
> a regression in the RGB565 write conversion.


  parent reply	other threads:[~2026-11-13  0:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  0:52 [PATCH 0/5] drm/vkms: support more formats and fix RGB565 regression Matheus Alves de Almeida
2026-09-28  0:52 ` [PATCH 1/5] drm/vkms: make argb_u16_to_RGB565 round resulting values Matheus Alves de Almeida
2026-11-08  3:12   ` Sidharth Saha
2026-09-28  0:52 ` [PATCH 2/5] drm/vkms: support BGR565 writeback Matheus Alves de Almeida
2026-09-28  0:52 ` [PATCH 3/5] drm/vkms: add a helper for channel to argb_u16 conversion Matheus Alves de Almeida
2026-09-28  0:53 ` [PATCH 4/5] drm/vkms: add support for RGB332 Matheus Alves de Almeida
2026-09-28  0:53 ` [PATCH 5/5] drm/vkms: add support for BGR233 Matheus Alves de Almeida
2026-10-12 19:18 ` [PATCH 0/5] drm/vkms: support more formats and fix RGB565 regression Matheus Alves de Almeida
2026-11-08  3:08 ` Sidharth Saha
2026-11-13  0:18 ` Sidharth Saha [this message]
2026-11-13  1:51   ` Matheus Alves de Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3707b72-07f2-41ae-aefa-c46ef84de3e3@gmail.com \
    --to=ssaha2000@gmail.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matheus.aalmeida@inf.ufrgs.br \
    --cc=melissa.srw@gmail.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.