All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring <io-uring@vger.kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH RFC] io_uring: extend io_uring_sqe flags bits
Date: Fri, 1 Nov 2024 16:59:10 +0000	[thread overview]
Message-ID: <f375e5d0-e870-47cd-b3c0-7a0a7ce99657@gmail.com> (raw)
In-Reply-To: <e60a3dd3-3a74-4181-8430-90c106a202f6@kernel.dk>

On 10/31/24 21:22, Jens Axboe wrote:
> In hindsight everything is clearer, but it probably should've been known
> that 8 bits of ->flags would run out sooner than later. Rather than
> gobble up the last bit for a random use case, add a bit that controls
> whether or not ->personality is used as a flags2 argument. If that is
> the case, then there's a new IOSQE2_PERSONALITY flag that tells io_uring
> which personality field to read.
> 
> While this isn't the prettiest, it does allow extending with 15 extra
> flags, and retains being able to use personality with any kind of
> command. The exception is uring cmd, where personality2 will overlap
> with the space set aside for SQE128. If they really need that, then that
> would have to be done via a uring cmd flag.

Interesting, I was just experimenting using the personality bits for
similar purposes I mentioned but in a different way, and I even thought
if anything it could be used to extend sqe flags though I'm not a huge
fan of that.

-- 
Pavel Begunkov

  parent reply	other threads:[~2024-11-01 16:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 21:22 [PATCH RFC] io_uring: extend io_uring_sqe flags bits Jens Axboe
2024-11-01  2:12 ` Ming Lei
2024-11-01  2:42   ` Ming Lei
2024-11-01 13:59     ` Jens Axboe
2024-11-01 14:34       ` Ming Lei
2024-11-01 14:42         ` Jens Axboe
2024-11-01 15:01           ` Ming Lei
2024-11-01 15:04             ` Jens Axboe
2024-11-01 16:55           ` Pavel Begunkov
2024-11-01 16:58             ` Jens Axboe
2024-11-01 13:58   ` Jens Axboe
2024-11-01 16:59 ` Pavel Begunkov [this message]
2024-11-01 17:05   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f375e5d0-e870-47cd-b3c0-7a0a7ce99657@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.