From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF307C4332F for ; Tue, 15 Nov 2022 08:43:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232808AbiKOInu (ORCPT ); Tue, 15 Nov 2022 03:43:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236567AbiKOInh (ORCPT ); Tue, 15 Nov 2022 03:43:37 -0500 Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E95AF205EA; Tue, 15 Nov 2022 00:43:21 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0VUsd9r0_1668501796; Received: from 30.221.131.168(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VUsd9r0_1668501796) by smtp.aliyun-inc.com; Tue, 15 Nov 2022 16:43:18 +0800 Message-ID: Date: Tue, 15 Nov 2022 16:43:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 To: John Garry , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> From: Jing Zhang In-Reply-To: <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org 在 2022/11/14 下午8:59, John Garry 写道: > On 14/11/2022 07:41, Jing Zhang wrote: >> The calculation formula of topdown L1 is from the document: >> https://urldefense.com/v3/__https://documentation-service.arm.com/static/60250c7395978b529036da86?token=__;!!ACWV5N9M2RV99hQ!Ll-Jgvfs0LitTCU-hC6i6BKBVJfhke-pbQq2VoO-gmuSAcglQ3ZqMVMd2r0An_5a3ZDPYmn8zXuCrpUbehwnLHplVQ$  > > So since this is a from "standard" document, did you consider putting these as an arch std event? I think arch std events would work for metrics, like they do for regular events. > I didn't find out how to put the metric as an arch std event, it would be best if you could provide me with an example in the upstream code, thank you very much. >> >> However, due to the wrong count of stall_slot and stall_slot_frontend >> in neoverse-n2, the real stall_slot and real stall_slot_frontend need >> to subtract cpu_cycles, so when calculating the topdownL1 metrics, >> stall_slot and stall_slot_frontend are corrected. > > Is there a reference to this? It would be indeed useful to pass a link to the n2 doc as these metrics are not part of the arm64 arm. At least I assume that they are not there. > You are right, I need to add a doc link. ARM has released the n2 ERRATA document about the incorrect count of stall_slot and stall_slot_frontend, and provides a workaround to get the correct value. Link: https://developer.arm.com/documentation/SDEN1982442/1200/?lang=en >> >> Since neoverse-n2 does not yet support topdown L2, metricgroups such >> as Cache, TLB, Branch, InstructionsMix, and PEutilization will be >> added to further analysis of performance bottlenecks in the following >> patches. >> > > > Thanks, > John Best Regards, Jing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 184B1C4332F for ; Tue, 15 Nov 2022 08:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZRbUpMtDE7VT3lEyflY4KSxNXXHcXa5dRS80Bu0NI/8=; b=ZlInnD9QexCman Xtc3Onoh2KgoXtoHdTv45AGW9rjRtH6+rJ1uEvemjHagPqTgZli6mWvwUi5r4q5euxTRuRahEyX9P YwGNBiFhRc9rn7G/CqgSFWdEQLYMUftSQWchNddHbcl7wa3ngHyohSwfQN1ofHPZG/iPthLMBZSsu RalhTtSQtzCbOK3kxAqeXyCQVyVlmvWuLPCxg2yTEqYNunB4NewWp0MsOdri1cvRRrkLHWMh8dwtl MHSkue7ZTwVAxcQnq+pd48ulBPRWCaERWm72Hm5LuaP2KsIQcub2ZvTBmkFfl5pdE18NBDeVnJt9C tdkylEoRNHid34DbD24A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ourXW-0090IO-Dk; Tue, 15 Nov 2022 08:43:30 +0000 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ourXS-0090FW-DY for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 08:43:28 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0VUsd9r0_1668501796; Received: from 30.221.131.168(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VUsd9r0_1668501796) by smtp.aliyun-inc.com; Tue, 15 Nov 2022 16:43:18 +0800 Message-ID: Date: Tue, 15 Nov 2022 16:43:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 To: John Garry , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> From: Jing Zhang In-Reply-To: <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_004326_648601_5DD55B4D X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgrlnKggMjAyMi8xMS8xNCDkuIvljYg4OjU5LCBKb2huIEdhcnJ5IOWGmemBkzoKPiBPbiAxNC8x MS8yMDIyIDA3OjQxLCBKaW5nIFpoYW5nIHdyb3RlOgo+PiBUaGUgY2FsY3VsYXRpb24gZm9ybXVs YSBvZiB0b3Bkb3duIEwxIGlzIGZyb20gdGhlIGRvY3VtZW50Ogo+PiBodHRwczovL3VybGRlZmVu c2UuY29tL3YzL19faHR0cHM6Ly9kb2N1bWVudGF0aW9uLXNlcnZpY2UuYXJtLmNvbS9zdGF0aWMv NjAyNTBjNzM5NTk3OGI1MjkwMzZkYTg2P3Rva2VuPV9fOyEhQUNXVjVOOU0yUlY5OWhRIUxsLUpn dmZzMExpdFRDVS1oQzZpNkJLQlZKZmhrZS1wYlFxMlZvTy1nbXVTQWNnbFEzWnFNVk1kMnIwQW5f NWEzWkRQWW1uOHpYdUNycFViZWh3bkxIcGxWUSTCoCAKPiAKPiBTbyBzaW5jZSB0aGlzIGlzIGEg ZnJvbSAic3RhbmRhcmQiIGRvY3VtZW50LCBkaWQgeW91IGNvbnNpZGVyIHB1dHRpbmcgdGhlc2Ug YXMgYW4gYXJjaCBzdGQgZXZlbnQ/IEkgdGhpbmsgYXJjaCBzdGQgZXZlbnRzIHdvdWxkIHdvcmsg Zm9yIG1ldHJpY3MsIGxpa2UgdGhleSBkbyBmb3IgcmVndWxhciBldmVudHMuCj4gCgpJIGRpZG4n dCBmaW5kIG91dCBob3cgdG8gcHV0IHRoZSBtZXRyaWMgYXMgYW4gYXJjaCBzdGQgZXZlbnQsIGl0 IHdvdWxkIGJlIGJlc3QgaWYgeW91IGNvdWxkIHByb3ZpZGUgbWUgd2l0aCBhbiBleGFtcGxlIGlu IHRoZSB1cHN0cmVhbSBjb2RlLAp0aGFuayB5b3UgdmVyeSBtdWNoLgoKPj4KPj4gSG93ZXZlciwg ZHVlIHRvIHRoZSB3cm9uZyBjb3VudCBvZiBzdGFsbF9zbG90IGFuZCBzdGFsbF9zbG90X2Zyb250 ZW5kCj4+IGluIG5lb3ZlcnNlLW4yLCB0aGUgcmVhbCBzdGFsbF9zbG90IGFuZCByZWFsIHN0YWxs X3Nsb3RfZnJvbnRlbmQgbmVlZAo+PiB0byBzdWJ0cmFjdCBjcHVfY3ljbGVzLCBzbyB3aGVuIGNh bGN1bGF0aW5nIHRoZSB0b3Bkb3duTDEgbWV0cmljcywKPj4gc3RhbGxfc2xvdCBhbmQgc3RhbGxf c2xvdF9mcm9udGVuZCBhcmUgY29ycmVjdGVkLgo+IAo+IElzIHRoZXJlIGEgcmVmZXJlbmNlIHRv IHRoaXM/IEl0IHdvdWxkIGJlIGluZGVlZCB1c2VmdWwgdG8gcGFzcyBhIGxpbmsgdG8gdGhlIG4y IGRvYyBhcyB0aGVzZSBtZXRyaWNzIGFyZSBub3QgcGFydCBvZiB0aGUgYXJtNjQgYXJtLiBBdCBs ZWFzdCBJIGFzc3VtZSB0aGF0IHRoZXkgYXJlIG5vdCB0aGVyZS4KPiAKCllvdSBhcmUgcmlnaHQs IEkgbmVlZCB0byBhZGQgYSBkb2MgbGluay4gQVJNIGhhcyByZWxlYXNlZCB0aGUgbjIgRVJSQVRB IGRvY3VtZW50IGFib3V0IHRoZSBpbmNvcnJlY3QgY291bnQgb2Ygc3RhbGxfc2xvdCBhbmQgc3Rh bGxfc2xvdF9mcm9udGVuZCwKYW5kIHByb3ZpZGVzIGEgd29ya2Fyb3VuZCB0byBnZXQgdGhlIGNv cnJlY3QgdmFsdWUuCkxpbms6IGh0dHBzOi8vZGV2ZWxvcGVyLmFybS5jb20vZG9jdW1lbnRhdGlv bi9TREVOMTk4MjQ0Mi8xMjAwLz9sYW5nPWVuCgo+Pgo+PiBTaW5jZSBuZW92ZXJzZS1uMiBkb2Vz IG5vdCB5ZXQgc3VwcG9ydCB0b3Bkb3duIEwyLCBtZXRyaWNncm91cHMgc3VjaAo+PiBhcyBDYWNo ZSwgVExCLCBCcmFuY2gsIEluc3RydWN0aW9uc01peCwgYW5kIFBFdXRpbGl6YXRpb24gd2lsbCBi ZQo+PiBhZGRlZCB0byBmdXJ0aGVyIGFuYWx5c2lzIG9mIHBlcmZvcm1hbmNlIGJvdHRsZW5lY2tz IGluIHRoZSBmb2xsb3dpbmcKPj4gcGF0Y2hlcy4KPj4KPiAKPiAKPiBUaGFua3MsCj4gSm9obgpC ZXN0IFJlZ2FyZHMsCkppbmcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK