From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1DFC248893 for ; Tue, 11 Aug 2026 07:06:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786431991; cv=none; b=X8oTo/qWHNHhv24R47jIngJumBcd70fq6L5q5pV9Umli4VfGGK5HJO+4z4u9xy1JlOtPLgOIvBh7Bpn0kS7YLYTXxRcq9+E8WxwD3sfmW4uz7sPSLvKjAy57hxQh+HWXxvv6YwqAkhfg+OJ1Xcwrrza+Lm20rXyj5nz99YZDO4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786431991; c=relaxed/simple; bh=vjVmWLf86eZvrbcu/MxECkVeyEygPgA7OxaEVDQZDJs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fAxnORi0ZItcwAltid6esU5nDxdH+mwLnsYgONlzouqCjueZC+TpIRZyDWQX4ypiWwA9W+UcrexAGPXGOGXQvb/U4d5LEZ1CHKdhw22jgvtd/oK8CT4PBjLEOX8Y/LMuDoO1nU1/MyiVkfOaimcvCvwvXkFIv6ffKZusqO6T1yI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=QSVBtNXr; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="QSVBtNXr" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AN1cr62878860; Tue, 11 Aug 2026 07:06:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=tug1GR H9aW37dU+R0CaXrLLMIIAYu9AyDGwIbwZrY7I=; b=QSVBtNXr5+3NtXvbkwBw3N iz75/7OspnR89sGXi1r9qgrliJ05WzFd5WkvqUnKfNzajVBYMeFQjntGReG4bJJg oZrAHXAV4qJONyX41mVnBdHVl9xQhi8RrGqxSoS1U46YN2zykwl9NcNXkeisG4dQ IqCHDmzQnWz4QkDdNaGJaNcpIZcZYrVVYjNZxpG5tirmPgLyY1erBnk3HxeoM2gx W+WFPCa8+uCS7F4fJxgUOr4GkwdU7uH2Z1dNx0o/Agp5ZvzhTiU4QWacr1zvz831 D7dMdG8pV7NXpJERC8FYEO1KTxRLmz/3WMFBIZPhMmSqTuhTjdaPYxgejmX7EITw == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fwvp2u59c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Aug 2026 07:05:59 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67B6uEb8022681; Tue, 11 Aug 2026 07:05:59 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4fxhfxyr6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Aug 2026 07:05:58 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67B75toE36045188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Aug 2026 07:05:55 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53F6A20040; Tue, 11 Aug 2026 07:05:55 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9ECB820043; Tue, 11 Aug 2026 07:05:51 +0000 (GMT) Received: from [9.123.14.142] (unknown [9.123.14.142]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 11 Aug 2026 07:05:51 +0000 (GMT) Message-ID: Date: Tue, 11 Aug 2026 12:35:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc/kexec_file: Use inclusive range checks for excluded memory To: Thorsten Blum , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Hari Bathini , Aditya Gupta , Jinjie Ruan , Andrew Morton Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260810145827.157972-3-thorsten.blum@linux.dev> Content-Language: en-US From: Sourabh Jain In-Reply-To: <20260810145827.157972-3-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=AMtp2X5w c=1 sm=1 tr=0 ts=6a7ac9d8 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=c92rfblmAAAA:8 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=nbPvJ5SdgmQPYtCXlAsA:9 a=QEXdDO2ut3YA:10 a=GvGzcOZaWPEFPQC_NcjD:22 X-Proofpoint-GUID: vaQxq8X2pSi4GGQSI5Y1AECtjvtAx9UD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODExMDA1NyBTYWx0ZWRfX1jqkow1i3dQC kOFd+HbbdjXzLI0keM5oyIMWqWOXjxG/5Dc75IdRgTkYrOyy1EA9DdZy0PPhfOZkMGu6pkhzVkx HWqfwC14NfuO95TqHp//Dueu0svxCDw3zLiIKO3q4MKGbYw7pOl02Ty8RHosX0+4fD0podOT/sy rBw4so4ixVFofyecRNXi9cnZDq8Ct2a47beEltF+NIRsUalp/hQXNKrucP7izbO9d0CTwwaSfzs dt/AlxB62zHU4lARBJYQLzFuWjNMHaFOXA/AWe1Q8hotnJWBJhy4s8ldUV/NwxQ71tj+tgX6Jbn KlGTPMzjxiAhSDKezYj4cWODjlC7YhGv3M7ilS9l0BUUb30yskWVGNdrNZCT3Frys9u/Ek9yajc fKJAKbArmXT2oQLHOReVo0z3vrdO09ZBc8c8j3LcuIOjPF9fcwMYAvb+SY+58VSJEyIWwxBZBOn azcSqSUWMwYbwSgEwtA== X-Proofpoint-ORIG-GUID: eggWLUutUGyj67VcShAvdRclPQKAuhbJ X-Proofpoint-Spam-Info: AW1haW4tMjYwODExMDA1NyBTYWx0ZWRfXw4nH2mVnrpP4 X6FitTA/QgrFKli8h4Vvy/8I3rKcbub5F+SNg31d4iMvjSNl31rEm4Xp5ggUwWJVU6MycrF7w8O mhwRB49ymyv5CDq7bo2KDadWZkwPlTY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_06,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608110057 On 10/08/26 20:28, Thorsten Blum wrote: > arch_check_excluded_range() checks if a kexec segment overlaps an > excluded memory range. > > Both ranges use inclusive end addresses, but the overlap check uses > exclusive comparisons. This skips ranges with start == ->ranges[i].end > or end == ->ranges[i].start. Use inclusive comparisons instead. > > Fixes: 6e5250eaa665 ("powerpc/crash: use generic APIs to locate memory hole for kdump") > Signed-off-by: Thorsten Blum > --- > Sashiko found this issue when reviewing another patch: > https://sashiko.dev/#/patchset/20260809162403.18142-2-thorsten.blum%40linux.dev > --- > arch/powerpc/kexec/file_load_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c > index 40b74cc4ed3e..32e2b7412a9f 100644 > --- a/arch/powerpc/kexec/file_load_64.c > +++ b/arch/powerpc/kexec/file_load_64.c > @@ -58,7 +58,7 @@ int arch_check_excluded_range(struct kimage *image, unsigned long start, > > emem = image->arch.exclude_ranges; > for (i = 0; i < emem->nr_ranges; i++) > - if (start < emem->ranges[i].end && end > emem->ranges[i].start) > + if (start <= emem->ranges[i].end && end >= emem->ranges[i].start) Like [1] this also extends the condition to check for a 1-byte overlap. It is unlikely to occur in practice, but I don't see any harm in doing so. Hence the changes looks good to me. Feel free to add. Reviewed-by: Sourabh Jain [1] https://lore.kernel.org/all/ee531113-5a56-4e6e-bc16-95941aa5bbfd@linux.ibm.com/ > return 1; > > return 0;