From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E19C5DF9E for ; Tue, 27 Oct 2020 19:20:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E022F20759 for ; Tue, 27 Oct 2020 19:20:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UScwURpx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1829634AbgJ0TTf (ORCPT ); Tue, 27 Oct 2020 15:19:35 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:33578 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1829620AbgJ0TTd (ORCPT ); Tue, 27 Oct 2020 15:19:33 -0400 Received: by mail-lf1-f68.google.com with SMTP id l2so3848479lfk.0; Tue, 27 Oct 2020 12:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/pIfDJ0AkidTbcRkJJnWMl8aJ4kgSl+CTCoDBuFpBc0=; b=UScwURpxgTZFS8xiQzfvvhi+CifiknqBp6iMvNs+6Wb0nNRNnC/zO0J9OaAsHDwEZT AQJCazQGt04Yo6sPjoxHdIsrvc+4mtm2MIpr/EsQqQ9AzCuHfILl9/kpzyROX9v/JMYh hXtkpgUdjMsyskYAoVVEgMI+bty9hBevb4OzTpddCLlrGqpxJDVcjsQVr2AyZTTrzOE9 KzIdDAACwwH3hsvPHxXp7Kth5lFvX9PR6NnbIPoKL8MjSpnBTdqR/EcRmXU8n7pH5oK6 l6PNRg2eUhOyB1zu0DnQwDhkNAchozPRXy1xsP3Elsx7h+RkngwlCaKL+TlX8jcE8jhB 06bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/pIfDJ0AkidTbcRkJJnWMl8aJ4kgSl+CTCoDBuFpBc0=; b=I+yHgcBTahmyr6f+SVfftLW+JMAJuhYv09uPYruAsIxg0g+Y22tIJlGjSilbJm3ihj BSqEYTUl+TbbT65p65xz8plk5E99kspdDyzWW3nR1uHpohhQzmSBuL5wMfMhlV13lZJy CAcJ3F9P8Ri6vNxOEhQNV6mQMLN2M5esPyriPVQK6OXDWU63ydlovYnLtBYhEJAlfTdA wGQ9C8pyxbnx6+iePs8Ap2IYDnXc9oHlqYjN9tEDy0XuhXE+jV+Hw7GlZqwqmMJQq+8F pVslAxyLt/rZiPFnMOz8+4BP6vfBBiKknhWR9HbH14FUDi8+0lJknmwGpXFbj5YYUjWd 4jPA== X-Gm-Message-State: AOAM530h28W+YZ0f6v6gptFZJbApUtra60nhJwdEqCF5x+RUjrn/qLJB zu4LR5cmvRXzCWhjshmsDxzarag8iNA= X-Google-Smtp-Source: ABdhPJzrLiSB7V8GZRxzvrHOF+cQNWPrcMqy1pZLxufDhMT9At8Xhhbg8y/oFfWB+HSFnV39X9bidw== X-Received: by 2002:a19:4ac1:: with SMTP id x184mr989056lfa.140.1603826370353; Tue, 27 Oct 2020 12:19:30 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-186.dynamic.spd-mgts.ru. [109.252.193.186]) by smtp.googlemail.com with ESMTPSA id q15sm260867lfb.231.2020.10.27.12.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 12:19:29 -0700 (PDT) Subject: Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property To: Krzysztof Kozlowski Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-14-digetx@gmail.com> <20201027102506.GB17089@kozik-lap> From: Dmitry Osipenko Message-ID: Date: Tue, 27 Oct 2020 22:19:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027102506.GB17089@kozik-lap> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org 27.10.2020 13:25, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:16:56AM +0300, Dmitry Osipenko wrote: >> External memory controller is interconnected with memory controller and >> with external memory. Document new interconnect property which turns >> External Memory Controller into interconnect provider. >> >> Signed-off-by: Dmitry Osipenko >> --- >> .../bindings/memory-controllers/nvidia,tegra124-emc.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml >> index 278549f9e051..ac00832ceac1 100644 >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml >> @@ -29,6 +29,9 @@ properties: >> items: >> - const: emc >> >> + "#interconnect-cells": >> + const: 0 >> + >> nvidia,memory-controller: >> $ref: /schemas/types.yaml#/definitions/phandle >> description: >> @@ -327,6 +330,7 @@ required: >> - clocks >> - clock-names >> - nvidia,memory-controller >> + - "#interconnect-cells" > > Another required property, what about all existing users of this binding? EMC/devfreq drivers check presence of the new properties and ask users to upgrade the DT. The kernel will continue to work fine using older DTBs, but devfreq driver won't load. >> additionalProperties: false >> >> @@ -345,6 +349,7 @@ examples: >> >> #iommu-cells = <1>; >> #reset-cells = <1>; >> + #interconnect-cells = <1>; > > You meant '0'? '1' is for the "mc" node in the example (not "emc" node). Anyways, I'll move this hunk to the previous patch in order to fix the kernel bot warning. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707C7C4363A for ; Wed, 28 Oct 2020 08:07:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0544122447 for ; Wed, 28 Oct 2020 08:07:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UScwURpx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0544122447 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C3FE6EB7D; Wed, 28 Oct 2020 08:06:34 +0000 (UTC) Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by gabe.freedesktop.org (Postfix) with ESMTPS id E36D26EC1B for ; Tue, 27 Oct 2020 19:19:31 +0000 (UTC) Received: by mail-lf1-x144.google.com with SMTP id 126so3774504lfi.8 for ; Tue, 27 Oct 2020 12:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/pIfDJ0AkidTbcRkJJnWMl8aJ4kgSl+CTCoDBuFpBc0=; b=UScwURpxgTZFS8xiQzfvvhi+CifiknqBp6iMvNs+6Wb0nNRNnC/zO0J9OaAsHDwEZT AQJCazQGt04Yo6sPjoxHdIsrvc+4mtm2MIpr/EsQqQ9AzCuHfILl9/kpzyROX9v/JMYh hXtkpgUdjMsyskYAoVVEgMI+bty9hBevb4OzTpddCLlrGqpxJDVcjsQVr2AyZTTrzOE9 KzIdDAACwwH3hsvPHxXp7Kth5lFvX9PR6NnbIPoKL8MjSpnBTdqR/EcRmXU8n7pH5oK6 l6PNRg2eUhOyB1zu0DnQwDhkNAchozPRXy1xsP3Elsx7h+RkngwlCaKL+TlX8jcE8jhB 06bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/pIfDJ0AkidTbcRkJJnWMl8aJ4kgSl+CTCoDBuFpBc0=; b=TxJ9nUxdiYdFx7EIign0Z4iCfiXaQ+3sejvRugIRxz2Jli40KhyIH7I9DuZ2arh9rq 8hPUBbI5VVzjS0Te/6sYDUey+aodRJPkRmkBTVz0fwZl8uYCVoLHledSxe3itVSgpdNN ATLWHLma/NGrRyHzQBAaZjhwAdxXmJxVrQeOy8ZDQt71Jim/qLQPca7A24kUv2CE+37/ 6SUINpI6CeVgxmNsd1PQFrvW9Oiuni30IGnRrt1Xp4pCjoUck+K/upVUGKtSqVxSC+gD +hcZqVpJ4wWFN2pSyYFKnKF68e8aCHdn4TKfERp39q8cvY4y1yfDZUBe03h2KtebMKwm zhzQ== X-Gm-Message-State: AOAM533MRWvdam5hm/tV2NFubXYgGWyVywHvGrwib+HRta8Azle/ws8o SHr+HAkX668o09FxGk4lzUQ= X-Google-Smtp-Source: ABdhPJzrLiSB7V8GZRxzvrHOF+cQNWPrcMqy1pZLxufDhMT9At8Xhhbg8y/oFfWB+HSFnV39X9bidw== X-Received: by 2002:a19:4ac1:: with SMTP id x184mr989056lfa.140.1603826370353; Tue, 27 Oct 2020 12:19:30 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-186.dynamic.spd-mgts.ru. [109.252.193.186]) by smtp.googlemail.com with ESMTPSA id q15sm260867lfb.231.2020.10.27.12.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 12:19:29 -0700 (PDT) Subject: Re: [PATCH v6 13/52] dt-bindings: memory: tegra124: emc: Document new interconnect property To: Krzysztof Kozlowski References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-14-digetx@gmail.com> <20201027102506.GB17089@kozik-lap> From: Dmitry Osipenko Message-ID: Date: Tue, 27 Oct 2020 22:19:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027102506.GB17089@kozik-lap> Content-Language: en-US X-Mailman-Approved-At: Wed, 28 Oct 2020 08:06:30 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjcuMTAuMjAyMCAxMzoyNSwgS3J6eXN6dG9mIEtvemxvd3NraSDQv9C40YjQtdGCOgo+IE9uIE1v biwgT2N0IDI2LCAyMDIwIGF0IDAxOjE2OjU2QU0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90 ZToKPj4gRXh0ZXJuYWwgbWVtb3J5IGNvbnRyb2xsZXIgaXMgaW50ZXJjb25uZWN0ZWQgd2l0aCBt ZW1vcnkgY29udHJvbGxlciBhbmQKPj4gd2l0aCBleHRlcm5hbCBtZW1vcnkuIERvY3VtZW50IG5l dyBpbnRlcmNvbm5lY3QgcHJvcGVydHkgd2hpY2ggdHVybnMKPj4gRXh0ZXJuYWwgTWVtb3J5IENv bnRyb2xsZXIgaW50byBpbnRlcmNvbm5lY3QgcHJvdmlkZXIuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6 IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPj4gLS0tCj4+ICAuLi4vYmluZGlu Z3MvbWVtb3J5LWNvbnRyb2xsZXJzL252aWRpYSx0ZWdyYTEyNC1lbWMueWFtbCAgIHwgNyArKysr KysrCj4+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQg YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL252 aWRpYSx0ZWdyYTEyNC1lbWMueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMTI0LWVtYy55YW1sCj4+IGluZGV4IDI3 ODU0OWY5ZTA1MS4uYWMwMDgzMmNlYWMxIDEwMDY0NAo+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL252aWRpYSx0ZWdyYTEyNC1lbWMu eWFtbAo+PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVtb3J5LWNv bnRyb2xsZXJzL252aWRpYSx0ZWdyYTEyNC1lbWMueWFtbAo+PiBAQCAtMjksNiArMjksOSBAQCBw cm9wZXJ0aWVzOgo+PiAgICAgIGl0ZW1zOgo+PiAgICAgICAgLSBjb25zdDogZW1jCj4+ICAKPj4g KyAgIiNpbnRlcmNvbm5lY3QtY2VsbHMiOgo+PiArICAgIGNvbnN0OiAwCj4+ICsKPj4gICAgbnZp ZGlhLG1lbW9yeS1jb250cm9sbGVyOgo+PiAgICAgICRyZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwj L2RlZmluaXRpb25zL3BoYW5kbGUKPj4gICAgICBkZXNjcmlwdGlvbjoKPj4gQEAgLTMyNyw2ICsz MzAsNyBAQCByZXF1aXJlZDoKPj4gICAgLSBjbG9ja3MKPj4gICAgLSBjbG9jay1uYW1lcwo+PiAg ICAtIG52aWRpYSxtZW1vcnktY29udHJvbGxlcgo+PiArICAtICIjaW50ZXJjb25uZWN0LWNlbGxz Igo+IAo+IEFub3RoZXIgcmVxdWlyZWQgcHJvcGVydHksIHdoYXQgYWJvdXQgYWxsIGV4aXN0aW5n IHVzZXJzIG9mIHRoaXMgYmluZGluZz8KCkVNQy9kZXZmcmVxIGRyaXZlcnMgY2hlY2sgcHJlc2Vu Y2Ugb2YgdGhlIG5ldyBwcm9wZXJ0aWVzIGFuZCBhc2sgdXNlcnMKdG8gdXBncmFkZSB0aGUgRFQu IFRoZSBrZXJuZWwgd2lsbCBjb250aW51ZSB0byB3b3JrIGZpbmUgdXNpbmcgb2xkZXIKRFRCcywg YnV0IGRldmZyZXEgZHJpdmVyIHdvbid0IGxvYWQuCgo+PiAgYWRkaXRpb25hbFByb3BlcnRpZXM6 IGZhbHNlCj4+ICAKPj4gQEAgLTM0NSw2ICszNDksNyBAQCBleGFtcGxlczoKPj4gIAo+PiAgICAg ICAgICAjaW9tbXUtY2VsbHMgPSA8MT47Cj4+ICAgICAgICAgICNyZXNldC1jZWxscyA9IDwxPjsK Pj4gKyAgICAgICAgI2ludGVyY29ubmVjdC1jZWxscyA9IDwxPjsKPiAKPiBZb3UgbWVhbnQgJzAn PwoKJzEnIGlzIGZvciB0aGUgIm1jIiBub2RlIGluIHRoZSBleGFtcGxlIChub3QgImVtYyIgbm9k ZSkuCgpBbnl3YXlzLCBJJ2xsIG1vdmUgdGhpcyBodW5rIHRvIHRoZSBwcmV2aW91cyBwYXRjaCBp biBvcmRlciB0byBmaXggdGhlCmtlcm5lbCBib3Qgd2FybmluZy4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==