From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
ak@linux.intel.com, eranian@google.com,
dapeng1.mi@linux.intel.com
Subject: Re: [PATCH V10 4/4] perf/x86/intel: Support PEBS counters snapshotting
Date: Tue, 4 Feb 2025 16:09:09 -0500 [thread overview]
Message-ID: <f3b71bfb-4e04-48a2-b606-bac81cd3f50e@linux.intel.com> (raw)
In-Reply-To: <20250127155107.GI16742@noisy.programming.kicks-ass.net>
Hi Peter,
On 2025-01-27 10:51 a.m., Peter Zijlstra wrote:
> On Tue, Jan 21, 2025 at 07:23:03AM -0800, kan.liang@linux.intel.com wrote:
>
>> @@ -471,6 +477,15 @@ struct pebs_xmm {
>>
>> #define IBS_CPUID_FEATURES 0x8000001b
>>
>> +struct pebs_cntr_header {
>> + u32 cntr;
>> + u32 fixed;
>> + u32 metrics;
>> + u32 reserved;
>> +};
>> +
>> +#define INTEL_CNTR_METRICS 0x3
>
> I've moved this up a little, so that all the adaptive pebs crud is
> together.
>
> Other than that, I've picked up these patches and will merge the lot
> past -rc1.
>
We found a bug when testing with some non-precise events in freq mode.
I've submitted a patch to fix it.
https://lore.kernel.org/lkml/20250204210514.4089680-1-kan.liang@linux.intel.com/
Could you please fold it into the patch ("perf/x86/intel: Support PEBS
counters snapshotting")?
Sorry for any inconvenience.
Thanks,
Kan
next prev parent reply other threads:[~2025-02-04 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 15:23 [PATCH V10 1/4] perf/x86/intel: Apply static call for drain_pebs kan.liang
2025-01-21 15:23 ` [PATCH V10 2/4] perf/x86/intel: Avoid disable PMU if !cpuc->enabled in sample read kan.liang
2025-02-03 12:48 ` [tip: perf/core] " tip-bot2 for Kan Liang
2025-02-05 9:38 ` tip-bot2 for Kan Liang
2025-01-21 15:23 ` [PATCH V10 3/4] perf: Avoid the read if the count is already updated kan.liang
2025-02-03 12:48 ` [tip: perf/core] " tip-bot2 for Peter Zijlstra (Intel)
2025-02-05 9:38 ` tip-bot2 for Peter Zijlstra (Intel)
2025-01-21 15:23 ` [PATCH V10 4/4] perf/x86/intel: Support PEBS counters snapshotting kan.liang
2025-01-27 15:51 ` Peter Zijlstra
2025-01-27 16:15 ` Liang, Kan
2025-02-04 21:09 ` Liang, Kan [this message]
2025-02-03 12:48 ` [tip: perf/core] " tip-bot2 for Kan Liang
2025-02-05 9:38 ` tip-bot2 for Kan Liang
2025-02-03 12:48 ` [tip: perf/core] perf/x86/intel: Apply static call for drain_pebs tip-bot2 for Peter Zijlstra (Intel)
2025-02-05 9:38 ` tip-bot2 for Peter Zijlstra (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b71bfb-4e04-48a2-b606-bac81cd3f50e@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.