Re: [Buildroot] [PATCH v3 1/3] package/python-yamllint: new package

[Romain Naour <romain.naour@smile.fr>]

Hello Heiko, Yann, All,

Le 12/04/2024 à 17:51, Yann E. MORIN a écrit :
> Heiko, All,
> 
> On 2024-04-12 17:43 +0200, Yann E. MORIN spake thusly:
>> Heiko, All,
>>
>> On 2024-04-12 07:53 +0200, Heiko Thiery spake thusly:
>>> This host package is needed since u-boot 2024.04 for building ti defconfigs.
>>>
>>> This is an requirement for using buildman/binman [1].
>>>
>>> [1] https://source.denx.de/u-boot/u-boot/-/blob/v2024.04/tools/buildman/requirements.txt?ref_type=tags#L3
>>>
>>> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
>>> ---
>> [--SNIP--]
>>> diff --git a/package/python-yamllint/Config.in b/package/python-yamllint/Config.in
>>> new file mode 100644
>>> index 0000000000..5c0962f09f
>>> --- /dev/null
>>> +++ b/package/python-yamllint/Config.in
>>> @@ -0,0 +1,8 @@
>>> +config BR2_PACKAGE_PYTHON_YAMLLINT
>>> +	bool "python-yamllint"
>>> +	select BR2_PACKAGE_PYTHON_PATHSPEC # runtime
>>
>>     $ ./utils/docker-run make check-package
>>     package/python-yamllint/Config.in:3: BR2_PACKAGE_PYTHON_PATHSPEC referenced but not defined
>>
>> OK, I'll go and apply that other patch of yours that introduces the
>> target variant for python-pathspec, but which is not in this patchset.

What if python-pathspec is not installed on the host?

make host-python-yamllint

./ouput/host/bin/python ./support/testing/tests/package/sample_python_yamllint.py

ModuleNotFoundError: No module named 'pathspec'

We must add host-python-pathspec (and all other runtime dependencies) in build
dependencies of host-python-yamllint

  # This is a runtime dependency, but we don't have the concept of
  # runtime dependencies for host packages.
  HOST_PYTHON_YAMLLINT_DEPENDENCIES += \
    host-python-pathspec \
    host-python-pyyaml

Actually, I'm not sure if every host-python packages really do this.

Best regards,
Romain


> 
> Applied to master, now, thanks.
> 
> Regards,
> Yann E. MORIN.
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot