From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH 04/10] net/virtio: optimize flags update for packed ring Date: Tue, 19 Mar 2019 13:50:47 +0100 Message-ID: References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-5-tiwei.bie@intel.com> <20190319085403.gnamedd5pz7jzwvj@jenstp.localdomain> <20190319093734.GA24818@dpdk-tbie.sh.intel.com> <20190319101154.loy5cmwbgnbnkxyg@jenstp.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: zhihong.wang@intel.com, dev@dpdk.org To: Jens Freimann , Tiwei Bie Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5D72211A4 for ; Tue, 19 Mar 2019 13:50:53 +0100 (CET) In-Reply-To: <20190319101154.loy5cmwbgnbnkxyg@jenstp.localdomain> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/19/19 11:11 AM, Jens Freimann wrote: >>> >>> same here. it's not really cached, it's pre-calculated. And here we >>> could also use a pre-calculated constand/define. >> >> For pre-calculated constant/define, do you mean VRING_DESC_F_AVAIL(1) >> and VRING_DESC_F_USED(1)? There is still little code in virtio-user >> using them without constantly passing 1. I planned to fully get rid >> of them in a separate patch later (but I can do it in this series if >> anyone wants). > > Yes, that's what I meant. And it's fine by me if you do it in a > follow-up. Agree, it can be done in a separate patch.