From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA4D7C48BDF for ; Tue, 15 Jun 2021 06:18:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C210613DA for ; Tue, 15 Jun 2021 06:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbhFOGUq convert rfc822-to-8bit (ORCPT ); Tue, 15 Jun 2021 02:20:46 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:4780 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbhFOGUp (ORCPT ); Tue, 15 Jun 2021 02:20:45 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G3ygS1mlNzXg41; Tue, 15 Jun 2021 14:13:40 +0800 (CST) Received: from dggpeml100017.china.huawei.com (7.185.36.161) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 14:18:39 +0800 Received: from dggema753-chm.china.huawei.com (10.1.198.195) by dggpeml100017.china.huawei.com (7.185.36.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 14:18:39 +0800 Received: from dggema753-chm.china.huawei.com ([10.9.48.84]) by dggema753-chm.china.huawei.com ([10.9.48.84]) with mapi id 15.01.2176.012; Tue, 15 Jun 2021 14:18:38 +0800 From: liweihang To: Andrew Lunn CC: "davem@davemloft.net" , "kuba@kernel.org" , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , Linuxarm , liangwenpeng Subject: Re: [PATCH net-next 2/8] net: phy: correct format of block comments Thread-Topic: [PATCH net-next 2/8] net: phy: correct format of block comments Thread-Index: AQHXXoyi+Gi0jL1eg0evkWPZtRqBxw== Date: Tue, 15 Jun 2021 06:18:38 +0000 Message-ID: References: <1623393419-2521-1-git-send-email-liweihang@huawei.com> <1623393419-2521-3-git-send-email-liweihang@huawei.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.100.165] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2021/6/11 22:36, Andrew Lunn wrote: > On Fri, Jun 11, 2021 at 02:36:53PM +0800, Weihang Li wrote: >> From: Wenpeng Liang >> >> Block comments should not use a trailing */ on a separate line and every >> line of a block comment should start with an '*'. >> >> Signed-off-by: Wenpeng Liang >> Signed-off-by: Weihang Li >> --- >> drivers/net/phy/lxt.c | 6 +++--- >> drivers/net/phy/national.c | 6 ++++-- >> drivers/net/phy/phy-core.c | 3 ++- >> drivers/net/phy/phylink.c | 9 ++++++--- >> drivers/net/phy/vitesse.c | 3 ++- >> 5 files changed, 17 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c >> index bde3356..5e00910 100644 >> --- a/drivers/net/phy/lxt.c >> +++ b/drivers/net/phy/lxt.c >> @@ -241,9 +241,9 @@ static int lxt973a2_read_status(struct phy_device *phydev) >> if (lpa < 0) >> return lpa; >> >> - /* If both registers are equal, it is suspect but not >> - * impossible, hence a new try >> - */ >> + /* If both registers are equal, it is suspect but not >> + * impossible, hence a new try >> + */ >> } while (lpa == adv && retry--); > > Please indicate in the commit message why you changed the indentation. > > Andrew > Sure, thanks. Weihang