From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB24D18A6D5 for ; Mon, 24 Feb 2025 08:54:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740387273; cv=none; b=RBueLids1NpU4KW/qBjiKgtMlum16xkYR9YuMZxRCE6LB5wLCIiKO1oRr2QCbJLyPzUXB2Mi9OYPdy3enYJLp42F58PawxWoqqqMoCO32cUKO4gJjDjEB3h7QgD6wVYJJpjkS9M/3uXfMYa35jJxsm6iRF9X2Ah8kjdrXFBcEGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740387273; c=relaxed/simple; bh=1eJzMiKovJMJ/I8B4J10Cplw3cgUcnYnE3qMl+v8IS0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mKKEVtMbO6RlnGm/lbj/UvaaCMe7kij5VGWZkEYbJo3P+nWpy2BQalRMB32CTVYYduj6xb6A8iGSYvDE6yw/mv1EVzZsxVqp/onMaYwYMyB0QL20G8wZTO+hcUQI1CdnG6XEXrAej+4SrR1HM0Sq9kRv3s8RkI0lEjaTa+zN6Ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K35+wNut; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K35+wNut" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95AFAC4CED6; Mon, 24 Feb 2025 08:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740387273; bh=1eJzMiKovJMJ/I8B4J10Cplw3cgUcnYnE3qMl+v8IS0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=K35+wNutHBFAFT8SLGc0+opvIYVsoYBq3y7iUCOAeGdlHiRvNUWK8P8mPJPH2pKXB A19lVyWXSInnU1FvMjAbzONjUlxflVikEstY5Dczw4FyIh3A55zGJaCaliGKRKIoFl BXnrzEbtIX14jNWA0+u7jkfoj07E0gg60f0ZODtBAJ3tU4CcNE6Lro4J5xbpjUt7l/ jS1YAUR7gewwZhd0rKVOf56QpKbQlNTo3bwHXPgYJP/GrY+6Hs8EpN7CoCgMMQ7Jbg BvLbF83TT1PdLRFd4Z+EpJUoYU5cOUbsAD6D7iY9rTJJyJbOk0cm3v8k77amYANPD2 ofnDiO6pzs3FA== Message-ID: Date: Mon, 24 Feb 2025 09:54:30 +0100 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next v1 5/6] sock: add sock_kmemdup helper To: Geliang Tang , mptcp@lists.linux.dev Cc: Geliang Tang References: <0a3f7a31983f0587ace333f349f3e630c49d075d.1740384564.git.tanggeliang@kylinos.cn> Content-Language: en-GB From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <0a3f7a31983f0587ace333f349f3e630c49d075d.1740384564.git.tanggeliang@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Geliang, On 24/02/2025 09:13, Geliang Tang wrote: > From: Geliang Tang > > This patch adds the sock version of kmemdup() helper, named sock_kmemdup(), > to duplicate a memory block using the socket's option memory buffer. > > Signed-off-by: Geliang Tang > --- > include/net/sock.h | 1 + > net/core/sock.c | 23 +++++++++++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/include/net/sock.h b/include/net/sock.h > index edbb870e3f86..ffd757e7e329 100644 > --- a/include/net/sock.h > +++ b/include/net/sock.h > @@ -1793,6 +1793,7 @@ static inline struct sk_buff *sock_alloc_send_skb(struct sock *sk, > } > > void *sock_kmalloc(struct sock *sk, int size, gfp_t priority); > +void *sock_kmemdup(struct sock *sk, const void *src, int size, gfp_t priority); > void sock_kfree_s(struct sock *sk, void *mem, int size); > void sock_kzfree_s(struct sock *sk, void *mem, int size); > void sk_send_sigurg(struct sock *sk); > diff --git a/net/core/sock.c b/net/core/sock.c > index 0d385bf27b38..d09bd697c120 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -2805,6 +2805,29 @@ void *sock_kmalloc(struct sock *sk, int size, gfp_t priority) > } > EXPORT_SYMBOL(sock_kmalloc); > > +/* > + * Duplicate a memory block using the socket's option memory buffer. > + */ > +void *sock_kmemdup(struct sock *sk, const void *src, int size, gfp_t priority) > +{ > + int optmem_max = READ_ONCE(sock_net(sk)->core.sysctl_optmem_max); > + > + if ((unsigned int)size <= optmem_max && > + atomic_read(&sk->sk_omem_alloc) + size < optmem_max) { > + void *mem; > + /* First do the add, to avoid the race if kmalloc > + * might sleep. > + */ > + atomic_add(size, &sk->sk_omem_alloc); > + mem = kmemdup(src, size, priority); > + if (mem) > + return mem; > + atomic_sub(size, &sk->sk_omem_alloc); I'm not really convinced by this helper: it is a duplication of sock_kmalloc(), and it is only used once in MPTCP code. Calling sock_kmalloc() + memset, and using this new helper in different places in the net code might help. But still, I don't know if this would be accepted, it is only saving one line (plus memcpy() will be used when it is not needed, same for the previous patch at the end). If you still want to propose that, I suggest sending a dedicated series to netdev, not to block MPTCP (only) patches. WDYT? Cheers, Matt -- Sponsored by the NGI0 Core fund.