All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
	matt@codeconstruct.com.au, esyr@redhat.com
Subject: Re: [PATCH net-next v5] mctp: Implement extended addressing
Date: Tue, 26 Oct 2021 09:55:08 +0800	[thread overview]
Message-ID: <f40cddba6f6fae5d3106da33a2968543d00d64e2.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20211025.161549.899716517054473254.davem@davemloft.net>

Hi David,

> putting a variably sized type in the skb control blocxk is not a good
> idea.  Overruns will be silent, nothing in the typing protects you
> from udsing more space han exists in skb->cb.

There is a check using MCTP_SKB_CB_HADDR_MAXLEN, but setting the size of
the struct member typing would allow for better enforcement, yes.

> Plrease find another way, thank you.

OK, we can use MAX_ADDR_LEN here; we currently have enough space in the
cb for the maximum possible addressing sizes (and can check that through
a BUILD_BUG_ON too).

v6 coming right up.

Cheers,


Jeremy


      parent reply	other threads:[~2021-10-26  1:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25  3:27 [PATCH net-next v5] mctp: Implement extended addressing Jeremy Kerr
2021-10-25 15:15 ` David Miller
2021-10-25 15:34   ` Eugene Syromiatnikov
2021-10-26  1:55   ` Jeremy Kerr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f40cddba6f6fae5d3106da33a2968543d00d64e2.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=davem@davemloft.net \
    --cc=esyr@redhat.com \
    --cc=kuba@kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.