All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>,
	 davem@davemloft.net, edumazet@google.com, kuba@kernel.org
Cc: dccp@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 syzbot+c71bc336c5061153b502@syzkaller.appspotmail.com
Subject: Re: [PATCH net] dccp: check for ccid in ccid_hc_tx_send_packet
Date: Thu, 02 Nov 2023 12:14:53 +0100	[thread overview]
Message-ID: <f41c06eafd983584647e7d61561ea6282cdb735e.camel@redhat.com> (raw)
In-Reply-To: <20231028144136.3462-1-bragathemanick0908@gmail.com>

On Sat, 2023-10-28 at 20:11 +0530, Bragatheswaran Manickavel wrote:
> ccid_hc_tx_send_packet might be called with a NULL ccid pointer
> leading to a NULL pointer dereference

You should describe how such event could happen.

> Below mentioned commit has similarly changes
> commit 276bdb82dedb ("dccp: check ccid before dereferencing")
> 
> Reported-by: syzbot+c71bc336c5061153b502@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=c71bc336c5061153b502

and add a suitable fixes here.

(beyond taking care of other critical code paths, as reported by Eric).

Thanks!

Paolo


      parent reply	other threads:[~2023-11-02 11:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-28 14:41 [PATCH net] dccp: check for ccid in ccid_hc_tx_send_packet Bragatheswaran Manickavel
2023-10-30  8:59 ` Eric Dumazet
2023-10-30 15:40   ` Bragatheswaran Manickavel
2023-10-30 15:49     ` Eric Dumazet
     [not found]       ` <4fffeb15-52b1-4f2c-93bb-c3988ddfbf43@gmail.com>
2023-10-30 16:24         ` Eric Dumazet
2023-11-02 11:14 ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f41c06eafd983584647e7d61561ea6282cdb735e.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=bragathemanick0908@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dccp@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+c71bc336c5061153b502@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.