RE: [PATCH] net:realtek:use sysfs_emit() instead of scnprintf() for sysfs consistency

[Ping-Ke Shih <pkshih@realtek.com>]

Zong-Zhe Yang <kevin_yang@realtek.com> wrote:
> Mande Imran Ahmed <immu.ahmed1905@gmail.com> wrote:
> >
> > Update the Realtek rtw89 wireless driver to replace scnprintf() with
> > sysfs_emit() for formatting sysfs attribute output, in line with the recommendations from
> > Documentation/filesystems/sysfs.rst.

This is for sysfs, no? But this patch is related to debugfs, which buffer
size isn't PAGE_SIZE. Please refer to implementation of sysfs_emit().

So NACK.

> >
> > This change enhances the safety and correctness of sysfs handling, promotes consistency
> > throughout the kernel, and aids long-term maintainability.
> >
> > Functionality verified using ping, iperf, and connection tests to ensure stability after the
> > change.
> >
> > Signed-off-by: Mande Imran Ahmed <immu.ahmed1905@gmail.com>

[...]

> 
> (1.) buffer might not just be allocated with PAGE_SIZE
> (2.) the pointer passed to leaf function might not point to the head of allocated buffer
> 
> Will the above cause some problems ?
> 
> For (2.), maybe need to tweak them with sysfs_emit_at() instead of sysfs_emit(). !?

The assumption of buffer size in sysfs_emit() is PAGE_SIZE, but this is
totally wrong in rtw89 debugfs.