From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 729BFC00528 for ; Fri, 4 Aug 2023 10:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbjHDKYW (ORCPT ); Fri, 4 Aug 2023 06:24:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbjHDKYV (ORCPT ); Fri, 4 Aug 2023 06:24:21 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34B642118; Fri, 4 Aug 2023 03:24:19 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b974031aeaso29675181fa.0; Fri, 04 Aug 2023 03:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691144657; x=1691749457; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=+5Eyds8AZOTIj7eaREkCJcNrdRKcn3mEpCyJAFE/k2o=; b=W2LLr/3DA539SuI2hMrjowb+HwvAs5rNWNx98+bCzT/02iOuwPjKE4M07arYKgcsi7 k0cYuPim2XRMEfvnCUIZPNOfxFNLbuuPR6KX0N/pX3wCMhCGA+4wlA7JjGQxM3GJT87j hXOUSBVxIQHbFWyjoaIYlEJ7gFifMCKyhWNz3AZ+OINpPDJpX8BKxP2aFJYeBzQG3J8T uDAi+NB46aFh52jvTgGC6xc/t367BHSOSFqbRrzRcz2fWJqA4CIHvipC9sK2CfV02iyn mV4X3gL1dE2k/CyEDYZ4APJp9p6eecQXRwRGcq1ukLj7LTH+zKbGZKNc8KJqGHWJw/K1 PVKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691144657; x=1691749457; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+5Eyds8AZOTIj7eaREkCJcNrdRKcn3mEpCyJAFE/k2o=; b=R6hhlLM1p/sbySym6MV4xoeQIJJ76Y0JLw1jAvryTOJRfdOn+2ceNZ9OUbS8IyJX50 uMfQBGpatOZtrA6AUoCHxKZvvmktJyMvdGH7vsPkjLGQIB8t/+jc2FTzSGce3PAlM7XD uaXkHLSoHBlt/PmioA5YacoVunu6gYCN0OT/8eDDhcHaoeLPdlAWuRl1M12NgKr8AXs5 51/1MJTr6S1ShNCOOQN/DaFUF7LZvZaiIKuav5y2BjUFdAyAlKM3BItw4R+Xch2I/f/l iRGqBow5YDR7FXKPAFckXF8XjBs9wBN+WIS8i9TbM5AOQg0r5nTm0d8x6uRZAvG/CohO FfIQ== X-Gm-Message-State: AOJu0Yy2NXWxoitoH8PFQsQgsVNim/NqpoO7MW2vfvmpWPamp82K4AfY X7q4AjTs8pPHZbINIO/9WiY= X-Google-Smtp-Source: AGHT+IHO1gQu885p8yGW8WtJQSum+ZZNaqje43m9tQFcfdVHopqpLFBIWr7JgK1jWKtK1ZoU2wtEXg== X-Received: by 2002:a2e:9819:0:b0:2b8:36d4:7b0a with SMTP id a25-20020a2e9819000000b002b836d47b0amr1408664ljj.29.1691144657060; Fri, 04 Aug 2023 03:24:17 -0700 (PDT) Received: from [192.168.26.149] (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.googlemail.com with ESMTPSA id u21-20020a2e8555000000b002b6ece2456csm389393ljj.121.2023.08.04.03.24.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Aug 2023 03:24:16 -0700 (PDT) Message-ID: Date: Fri, 4 Aug 2023 12:24:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: ARM board lockups/hangs triggered by locks and mutexes From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Russell King , Daniel Lezcano , Thomas Gleixner , Florian Fainelli , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Network Development , Linux Kernel Mailing List Cc: OpenWrt Development List , bcm-kernel-feedback-list References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2.08.2023 00:10, Rafał Miłecki wrote: > Reverting that extra commit from v5.4.238 allows me to run Linux for > hours again (currently 3 devices x 6 hours and counting). So I need in > total 10+1 reverts from 5.4 branch to get a stable kernel. I switched back to OpenWrt's kernel 5.4 and applied all those reverts I found. Nothing. I was still getting hangs / lockups + reboots. After more bisecting and I found out it's because OpenWrt backported commit ad9b10d1eaad ("mtd: core: introduce of support for dynamic partitions"): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ad9b10d1eaada169bd764abcab58f08538877e26 It didn't make any sense to me. That patch does nothing on my device and its code is only executed when booting. It makes even less sense to me. Why such changes that should not affect anything actually break stability for BCM53573? I narrowed above patch even furher. It's actually enough to apply below diff to break kernel stability: diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index f69c5b94e..f10dd3af1 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -590,6 +590,25 @@ static int mtd_nvmem_add(struct mtd_info *mtd) return 0; } +static void mtd_check_of_node(struct mtd_info *mtd) +{ + struct device_node *partitions, *parent_dn; + struct mtd_info *parent; + + /* Check if MTD already has a device node */ + if (dev_of_node(&mtd->dev)) + return; + + /* Check if a partitions node exist */ + parent = mtd_get_master(mtd); + parent_dn = dev_of_node(&parent->dev); + pr_info("[%s] mtd->name:%s parent_dn:%pOF\n", __func__, mtd->name, parent_dn); + if (!parent_dn) + return; + + of_node_put(parent_dn); +} + /** * add_mtd_device - register an MTD device * @mtd: pointer to new MTD device info structure @@ -673,6 +692,7 @@ int add_mtd_device(struct mtd_info *mtd) mtd->dev.devt = MTD_DEVT(i); dev_set_name(&mtd->dev, "mtd%d", i); dev_set_drvdata(&mtd->dev, mtd); + mtd_check_of_node(mtd); of_node_get(mtd_get_of_node(mtd)); error = device_register(&mtd->dev); if (error) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44060C001DB for ; Fri, 4 Aug 2023 10:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C+OPqgnoAwepwi8z7Y5ODrnDEANwonhLb0h20f+kvAQ=; b=Jq0V2Z8hCXsz+3 uuHRypkJVJgpxkyxBagsBP718r+oRpcl3AzjMRmyetKrqjGm+jTtiQlfquiuFOFlU/itIWodZJ827 eAfsjtAlNDOKqN+D2bEkOtczwjWx3glDwXhgC8AG8EZg5yQ8bJn3wlOOtHGvLel8OEU8Q0oGZmuc9 /T3pLSEpdIKleWInm94NRXueJbDNsfeUUXQ7YbS6KbQW8LWSs4IZMEIIwREfBjX3LwnDzHk6QDz3o 5Oz1GqzS3JtbsXJDwgNovzk7PeKR4NXUKulZhG7VPOOu5DxrZ44cqSIwfxAhDafDtl2UbXbeKgber SdiaDN1NjZn3HEYI/orA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRryq-00C7Tr-0s; Fri, 04 Aug 2023 10:24:24 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRrym-00C7TA-1q for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 10:24:22 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2ba1e9b1fa9so6553701fa.3 for ; Fri, 04 Aug 2023 03:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691144657; x=1691749457; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=+5Eyds8AZOTIj7eaREkCJcNrdRKcn3mEpCyJAFE/k2o=; b=W2LLr/3DA539SuI2hMrjowb+HwvAs5rNWNx98+bCzT/02iOuwPjKE4M07arYKgcsi7 k0cYuPim2XRMEfvnCUIZPNOfxFNLbuuPR6KX0N/pX3wCMhCGA+4wlA7JjGQxM3GJT87j hXOUSBVxIQHbFWyjoaIYlEJ7gFifMCKyhWNz3AZ+OINpPDJpX8BKxP2aFJYeBzQG3J8T uDAi+NB46aFh52jvTgGC6xc/t367BHSOSFqbRrzRcz2fWJqA4CIHvipC9sK2CfV02iyn mV4X3gL1dE2k/CyEDYZ4APJp9p6eecQXRwRGcq1ukLj7LTH+zKbGZKNc8KJqGHWJw/K1 PVKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691144657; x=1691749457; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+5Eyds8AZOTIj7eaREkCJcNrdRKcn3mEpCyJAFE/k2o=; b=D6+nHZQ8ncCxXyoT15VxYzQYQF8rkXizYIAVR3bgAsWN6lPdS1IkugRcJh+cHIka2J hs6t4vWd0ZO35TvIlaxmfJ7kFSH41hGao4BQHlbZhvwIwAGcRFIvOWr9tQbsMCORbba8 gX3VMWAe/eyz+xAbl8xAIlom8y0R1ioMZZ75IW4gs1dpZXP4X1cgjmtY+1jAVGw0b+iE ULu9dfHic1VU6MSF42q/iESH0cBTEz0OAZzKMq5fhANP3PfTKR4kW+o9x119v0GUbkMF zuXWHUfX8uv61Z1VAfnbJrS7ospgEszXh0PQpiElbG1Z4TCgHzVKh1nmwSd0PobBgM9D G+vg== X-Gm-Message-State: AOJu0YyDvhVOFVKyyeYJVjH3uZs7+HcrZV2/8QXXTCdoUGd2BEkUXcpA 5ZRXmxwysk8Sbmdqq3S8PKw= X-Google-Smtp-Source: AGHT+IHO1gQu885p8yGW8WtJQSum+ZZNaqje43m9tQFcfdVHopqpLFBIWr7JgK1jWKtK1ZoU2wtEXg== X-Received: by 2002:a2e:9819:0:b0:2b8:36d4:7b0a with SMTP id a25-20020a2e9819000000b002b836d47b0amr1408664ljj.29.1691144657060; Fri, 04 Aug 2023 03:24:17 -0700 (PDT) Received: from [192.168.26.149] (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.googlemail.com with ESMTPSA id u21-20020a2e8555000000b002b6ece2456csm389393ljj.121.2023.08.04.03.24.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Aug 2023 03:24:16 -0700 (PDT) Message-ID: Date: Fri, 4 Aug 2023 12:24:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: ARM board lockups/hangs triggered by locks and mutexes From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Russell King , Daniel Lezcano , Thomas Gleixner , Florian Fainelli , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Network Development , Linux Kernel Mailing List Cc: OpenWrt Development List , bcm-kernel-feedback-list References: Content-Language: en-US In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230804_032420_655621_5065EDC9 X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMi4wOC4yMDIzIDAwOjEwLCBSYWZhxYIgTWnFgmVja2kgd3JvdGU6Cj4gUmV2ZXJ0aW5nIHRo YXQgZXh0cmEgY29tbWl0IGZyb20gdjUuNC4yMzggYWxsb3dzIG1lIHRvIHJ1biBMaW51eCBmb3IK PiBob3VycyBhZ2FpbiAoY3VycmVudGx5IDMgZGV2aWNlcyB4IDYgaG91cnMgYW5kIGNvdW50aW5n KS4gU28gSSBuZWVkIGluCj4gdG90YWwgMTArMSByZXZlcnRzIGZyb20gNS40IGJyYW5jaCB0byBn ZXQgYSBzdGFibGUga2VybmVsLgoKSSBzd2l0Y2hlZCBiYWNrIHRvIE9wZW5XcnQncyBrZXJuZWwg NS40IGFuZCBhcHBsaWVkIGFsbCB0aG9zZSByZXZlcnRzIEkKZm91bmQuIE5vdGhpbmcuIEkgd2Fz IHN0aWxsIGdldHRpbmcgaGFuZ3MgLyBsb2NrdXBzICsgcmVib290cy4KCkFmdGVyIG1vcmUgYmlz ZWN0aW5nIGFuZCBJIGZvdW5kIG91dCBpdCdzIGJlY2F1c2UgT3BlbldydCBiYWNrcG9ydGVkCmNv bW1pdCBhZDliMTBkMWVhYWQgKCJtdGQ6IGNvcmU6IGludHJvZHVjZSBvZiBzdXBwb3J0IGZvciBk eW5hbWljCnBhcnRpdGlvbnMiKToKaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4 L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L2NvbW1pdC8/aWQ9YWQ5YjEwZDFlYWFkYTE2 OWJkNzY0YWJjYWI1OGYwODUzODg3N2UyNgoKSXQgZGlkbid0IG1ha2UgYW55IHNlbnNlIHRvIG1l LiBUaGF0IHBhdGNoIGRvZXMgbm90aGluZyBvbiBteSBkZXZpY2UgYW5kCml0cyBjb2RlIGlzIG9u bHkgZXhlY3V0ZWQgd2hlbiBib290aW5nLgoKSXQgbWFrZXMgZXZlbiBsZXNzIHNlbnNlIHRvIG1l LiBXaHkgc3VjaCBjaGFuZ2VzIHRoYXQgc2hvdWxkIG5vdCBhZmZlY3QKYW55dGhpbmcgYWN0dWFs bHkgYnJlYWsgc3RhYmlsaXR5IGZvciBCQ001MzU3Mz8KCkkgbmFycm93ZWQgYWJvdmUgcGF0Y2gg ZXZlbiBmdXJoZXIuIEl0J3MgYWN0dWFsbHkgZW5vdWdoIHRvIGFwcGx5IGJlbG93CmRpZmYgdG8g YnJlYWsga2VybmVsIHN0YWJpbGl0eToKCmRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9tdGRjb3Jl LmMgYi9kcml2ZXJzL210ZC9tdGRjb3JlLmMKaW5kZXggZjY5YzViOTRlLi5mMTBkZDNhZjEgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvbXRkL210ZGNvcmUuYworKysgYi9kcml2ZXJzL210ZC9tdGRjb3Jl LmMKQEAgLTU5MCw2ICs1OTAsMjUgQEAgc3RhdGljIGludCBtdGRfbnZtZW1fYWRkKHN0cnVjdCBt dGRfaW5mbyAqbXRkKQogIAlyZXR1cm4gMDsKICB9Cgorc3RhdGljIHZvaWQgbXRkX2NoZWNrX29m X25vZGUoc3RydWN0IG10ZF9pbmZvICptdGQpCit7CisJc3RydWN0IGRldmljZV9ub2RlICpwYXJ0 aXRpb25zLCAqcGFyZW50X2RuOworCXN0cnVjdCBtdGRfaW5mbyAqcGFyZW50OworCisJLyogQ2hl Y2sgaWYgTVREIGFscmVhZHkgaGFzIGEgZGV2aWNlIG5vZGUgKi8KKwlpZiAoZGV2X29mX25vZGUo Jm10ZC0+ZGV2KSkKKwkJcmV0dXJuOworCisJLyogQ2hlY2sgaWYgYSBwYXJ0aXRpb25zIG5vZGUg ZXhpc3QgKi8KKwlwYXJlbnQgPSBtdGRfZ2V0X21hc3RlcihtdGQpOworCXBhcmVudF9kbiA9IGRl dl9vZl9ub2RlKCZwYXJlbnQtPmRldik7CisJcHJfaW5mbygiWyVzXSBtdGQtPm5hbWU6JXMgcGFy ZW50X2RuOiVwT0ZcbiIsIF9fZnVuY19fLCBtdGQtPm5hbWUsIHBhcmVudF9kbik7CisJaWYgKCFw YXJlbnRfZG4pCisJCXJldHVybjsKKworCW9mX25vZGVfcHV0KHBhcmVudF9kbik7Cit9CisKICAv KioKICAgKglhZGRfbXRkX2RldmljZSAtIHJlZ2lzdGVyIGFuIE1URCBkZXZpY2UKICAgKglAbXRk OiBwb2ludGVyIHRvIG5ldyBNVEQgZGV2aWNlIGluZm8gc3RydWN0dXJlCkBAIC02NzMsNiArNjky LDcgQEAgaW50IGFkZF9tdGRfZGV2aWNlKHN0cnVjdCBtdGRfaW5mbyAqbXRkKQogIAltdGQtPmRl di5kZXZ0ID0gTVREX0RFVlQoaSk7CiAgCWRldl9zZXRfbmFtZSgmbXRkLT5kZXYsICJtdGQlZCIs IGkpOwogIAlkZXZfc2V0X2RydmRhdGEoJm10ZC0+ZGV2LCBtdGQpOworCW10ZF9jaGVja19vZl9u b2RlKG10ZCk7CiAgCW9mX25vZGVfZ2V0KG10ZF9nZXRfb2Zfbm9kZShtdGQpKTsKICAJZXJyb3Ig PSBkZXZpY2VfcmVnaXN0ZXIoJm10ZC0+ZGV2KTsKICAJaWYgKGVycm9yKSB7CgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=