Re: [PATCH 4/4] wifi: mt76: mt7915: enable coredump support

[Ben Greear <greearb@candelatech.com>]

On 11/8/22 11:02 AM, Ryder Lee wrote:
> Host triggered and catastrophic event triggered firmware core dumping
> for basic firmware issues triage, including state reporting, task/irq
> info, function calltrace and MCU memory dump.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
>   .../net/wireless/mediatek/mt76/mt7915/Kconfig |   1 +
>   .../wireless/mediatek/mt76/mt7915/Makefile    |   3 +-
>   .../wireless/mediatek/mt76/mt7915/coredump.c  | 409 ++++++++++++++++++
>   .../wireless/mediatek/mt76/mt7915/coredump.h  | 136 ++++++
>   .../wireless/mediatek/mt76/mt7915/debugfs.c   |   4 -
>   .../net/wireless/mediatek/mt76/mt7915/init.c  |  12 +-
>   .../net/wireless/mediatek/mt76/mt7915/mac.c   |  72 ++-
>   .../net/wireless/mediatek/mt76/mt7915/mmio.c  |  59 ++-
>   .../wireless/mediatek/mt76/mt7915/mt7915.h    |  22 +
>   .../net/wireless/mediatek/mt76/mt7915/regs.h  |  34 +-
>   10 files changed, 740 insertions(+), 12 deletions(-)
>   create mode 100644 drivers/net/wireless/mediatek/mt76/mt7915/coredump.c
>   create mode 100644 drivers/net/wireless/mediatek/mt76/mt7915/coredump.h

Please add a pr_err() or similar somewhere so that it is easier to see that
firmware crashed while looking at dmesg/etc.

And maybe suggestion of where to send the dump so that someone can get some
useful data out of it.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com