From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F0A9CD128A for ; Wed, 10 Apr 2024 13:24:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 53A4481272; Wed, 10 Apr 2024 13:24:15 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PojRyWZZgvB0; Wed, 10 Apr 2024 13:24:14 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8E4DB81EC4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1712755454; bh=V5q89Bwv1WpzyGoyl49lxOJNvOtae/CcEX23U7jiOf4=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=4GlogzUFHCY1aUCNfLe23ycb7nK523nfd9o99ihocEyp8injEnIJanJSJQCAMyA0M 6tjNUdaktdBnGujsdUHAjXjsEdAAhKZURt1VSuEkYQwssZkCv5lPt/BeO3MKuAK7Ke ou6UzOtrGYGP7nmsNohIVswJyx6az9P98lLCrDVfGDbqNExFiNoExNnQuSoQRF9TrR jA7No24zVzk4q3RDLwTqHp54sx4j+pbKcLTDsSPnnuWWA11RknTC5kLKFh5j8u5eQJ Pc7mhU6fwRDTehSi2jMD0gU7eYH4I0P4qk2y+uboVsG7ar2CnbbP9W1tlYqPXRhzQY qipoJd5N0pzuw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 8E4DB81EC4; Wed, 10 Apr 2024 13:24:14 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id A0B411BF5A4 for ; Wed, 10 Apr 2024 13:24:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8100E40B78 for ; Wed, 10 Apr 2024 13:24:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id I3b5OVh00oU9 for ; Wed, 10 Apr 2024 13:24:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.14; helo=mgamail.intel.com; envelope-from=przemyslaw.kitszel@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org B298640B0D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B298640B0D Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by smtp2.osuosl.org (Postfix) with ESMTPS id B298640B0D for ; Wed, 10 Apr 2024 13:24:11 +0000 (UTC) X-CSE-ConnectionGUID: 6+8V6FCQRge3k+XXYrb9zw== X-CSE-MsgGUID: 22kT6m6XRWW8nXXH9FTFfQ== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="11959944" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="11959944" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 06:12:20 -0700 X-CSE-ConnectionGUID: kTlCt1yRSwafBjg31lSS3A== X-CSE-MsgGUID: aZiHEEC9QQyPu3osHm9HJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="25028354" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Apr 2024 06:12:20 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 06:12:18 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Apr 2024 06:12:18 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 06:12:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MVYVBhLysoXV3z8QLTjqFz68LpxtTZpGGd4mok1GODsum5orpvhYR3RUxFSy0IOjqVJ/zrqxH8iDbkj+L9ZdbTLiJEbqEOTpnb2Qch0z1gYU6S8FcSCl3FCHisAU9EnzuxgbchTgqZQ1XQmYSS/TdTEwSR83xYPw9TAi+xuBuNBSpiVy5tQmAo1bW4kHw8pQqsPqf3RGF5J+yGzE1o7+NnoLeaWyqqSiCOvojhgj+3tS1hv8Tij1WCcHZ8z3Gt55YUUTM/xMKliXyDajJt5UTVncmlWizaOqeTD1JFtyWfr0g+obyRVOiVqEtlkRKdT4j23Eq75MUJjbhCapeIB2Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V5q89Bwv1WpzyGoyl49lxOJNvOtae/CcEX23U7jiOf4=; b=Xo1C96pGp5W7mDp7BNfRk9lapJfDWtr6UQG6XwHtjyuhsIE5jDx69ABwRexDXTwPIp2GC3R7D2xlr88rLxcIdKfh6T8R35nCz3pWYbFpzii6tZTrkSzeuPRl9BngfarcruoUIRmZZ9Os5f8XutgEBmmW/qPWaM5dvh7MPFNJz9jr4kvnQtSC0HT7P/5jpb0/NhGUuk/I8tDmy0yVjI+MArpwCE3C6Ab5UfOFDyez6RMJEmjPGEpwIcyAZ/FrbEDrBuzpPs9M1nKRSgY7O0yVw6s0L3HcazJhizz5QvaubNiu4B5EXYlLwMSpx6RpBtxw8/QP7F0nUz5wsQkesTQ1/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) by PH7PR11MB6650.namprd11.prod.outlook.com (2603:10b6:510:1a8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Wed, 10 Apr 2024 13:12:15 +0000 Received: from MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::5c8:d560:c544:d9cf]) by MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::5c8:d560:c544:d9cf%5]) with mapi id 15.20.7430.045; Wed, 10 Apr 2024 13:12:15 +0000 Message-ID: Date: Wed, 10 Apr 2024 15:12:10 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Alexander Lobakin References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com> <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com> <36a067fa-75c0-4e7d-b704-229deea2d440@intel.com> <61a952aa-1b3e-43c7-9f35-ab53e492305a@intel.com> From: Przemek Kitszel In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU6P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::29) To MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8102:EE_|PH7PR11MB6650:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5B/sVbvTU/IeCpgUt1tSVrv2HJVf1ZXaUzO3kuAZ5l9l8fOU88O4VSPMa9lI/laTHKP4v8JbHozS7hOOobgjYiCp8fw0qGyLr1XmxkKx4x1s/Hv682iIZhO0fDFAJ40Gpuhx7HL8P62HCZ0h5TzgYiyjivhuAMrnvR+Kk479VyJZJ015J4XKoPERWoIzvsg7BAlN182tGBxGDF9dy1uysghv0C9OWkF7wwxBqXlyTRMBVlPBTmttBJFFtpoMMy6MV5Z/SoDE0OgywBq94sm34VwvVuVIBHSxvgRwUQg4VKCTz9rZQh1CgwPlqVcS9tdWTAa1zR4UVvHdkY84KrumTEaeZjFcd3r6JwStmminnIrViXi+vnCmdyaPQGXJi3NmJYo4uGIypzgbRBbgy6pDKEgT8ABit7YE7c+0I2GI4qwZYRnVve65PTp0B6ymjAtvswYIqJBn1qWaVEFHk0/SAVFBV0m58HEGjlz4k7v50kXIocgvXgtCVDaAlmdt098oAzVWByL5Oe4vZPUC7GsEraSV0nKPmz0+vVbak4wP94q5OwQNCpFbqAEgsSevtThsA926AFZa7fjT3sTh8tl8SIKPm103k4EMX+OK2VJ5swwBmcCOu0CXugIyQB5uOZoaQdt53EVYab6wTa6+gLrhriWlXsHsZfxWXrcwHLXDck8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN6PR11MB8102.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(7416005)(366007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1huRUZ6NjhOT2JuZGYzMmI2Zjh6TVEydXdkZm8xY1pEekh0dTcvZTFpYXky?= =?utf-8?B?cWp5ZUJiN2Vwc0c5MzhidUZIdTJZVFBQV0JNQkNqclFyZHd1aDI1clVseUtz?= =?utf-8?B?VmhISDJzTzgxWWxyZFVueHo3bFQrSUhIaDBtUmR5RDBndEFrWjlxSUM1blU5?= =?utf-8?B?OHpSRTRScGxpdVNyY25BQjk4bUUrOFVLbnU5RFk4ZHYzM25OTFhxczNYS1or?= =?utf-8?B?Z0V1MVU1MUNQc0pkQWxlbVBSYmthM1NoZnI3QkdWOWFZOTlLUHNhanNpcDd2?= =?utf-8?B?T0N6SklxQjI2c2tNRUFXd2puVVZLelcvUU1WZUhZM3RhNnhCaCttVHdtaWNZ?= =?utf-8?B?dzczeUFQa2ErUEdEU09UUXJzWFJ4aXFWZ3ZoY0xjWHE4c2ZTdVB6ZzJVNjNt?= =?utf-8?B?N3dMc2RheUtWMlllWTdtcGtoQk9tOEVsTnBiWVZEM3pURlJIZWNXTVJORW0z?= =?utf-8?B?cGdIV1FmeXZ1MUNBd0FCNW00T3V0Q0N2cWFKVHQ3TDM2K2c0em40Z1N1Z2c5?= =?utf-8?B?QkRhR3hhNDY5TWxLTUpFT0UrQmFxVG5pbnhkWVhnT0RYZ0VQWHp6Z1M4Tks2?= =?utf-8?B?WVFBeEJHWi9pb0p5MUdZK3N4SXh6Q2dQQndJUUZIbWR2K2xuZFBzZTFHYllU?= =?utf-8?B?NXgyVFR0b2hVWEF1Y3UwV0gzM1MzTzJTZENBcEdaS1ZOcExCSGJOc0hHVVhi?= =?utf-8?B?YjgzTHRoNHB3dEltSjFWQ1lkSGkrQVF1dmVYRWlIU3NNMUdjckNVQjBYTTR6?= =?utf-8?B?R1BicFUxSDdOb2FQL3BEWmVJM1VmMVBxVThMaUFKUHRCM29mVUU5NkRGR1gv?= =?utf-8?B?TDRzemlxeEJNU0NEVGJLanVoVmo3QWIvZWJDSERhbWZNOUdMOHRvamRIU1pH?= =?utf-8?B?VVVtT09IM3RBWmRUNmduL3JHVHBES1RyTHZUdjhaZDdSbEthZE9hYXlLcHdm?= =?utf-8?B?TmZYWS9jM0VkN2kzeFBsZGlkQnFTY2VtWkFUbVdzZTRteFlIZkFTMEhCQlU3?= =?utf-8?B?Smw4YjA0M2xpQVYybjQ3SkVlZGRWNXpzR1lDMkFFTkIveExHNXdCaG5qc2Mz?= =?utf-8?B?aE12cUNXVVNvaUVDaGtSbVFmdE5ROWFNZTkrMkFjTW0rcmdNZmZaY0xlb3hz?= =?utf-8?B?TGl6UFlXd2h3dmFEUHNRa2tHT1JaNkhFdDUxZ3RtZkdtalMxS25sT0F4NlB2?= =?utf-8?B?ajZacXZOdzJMd1ZPdWR3cExYYTJlL3FtbzBIVHNQcnhPcmR2ellWRGRmdEc5?= =?utf-8?B?U2lqTXo3a1lhemFKRXFpQXBSaWdnTTFuZlFnSEUzemFpb21MN0IyUDd4cGNq?= =?utf-8?B?bTdIalNsTTB6SnNycW9yb1dRNmRLSVdsemdUNXBEcytyRUhFby9TUHB1d1Vr?= =?utf-8?B?VHJXVHNBQUdTYkREOXRmVytySmJmbXlQYkhrbFZOR2RRVGdjbm9yQTg3MnpU?= =?utf-8?B?cy9DNS9iYmlCcWp4eTRwdVZYdGlZOTBNUml4L2dwWEF3aXZNb0VKZnAwVjdH?= =?utf-8?B?cW5DRlY4eUthNDhFTVFDNVUzdTdwN1BmUjlyOVUwL3M3SnJLVGR6a3M2eXU1?= =?utf-8?B?bXI0QU5nWENEeXpiSyttQ0dod3ZrMzBZbzhZQXFnQ0VWYmFUYW5XaC85WEdk?= =?utf-8?B?ZGhFdlJrLzNkQWt5ZXNhcUlwTDNSbVpoK0VLd3JLaWhvWEthNmR2SmlrMFFK?= =?utf-8?B?WmkvU2JQK3hNWmJLbWw1dWlocmtLcklLTHhzcENBSzBQVlBVK2g1SVlYRjU5?= =?utf-8?B?YVlhTTdDYS9ZZWk3K3EzeTUrK2hVTWsxNzA3SnVSemtZbERYRHRqc0xIM3pM?= =?utf-8?B?YlhKSE52WFUvVm9FdXlYdGFOMldwRys1ckd0TVdtRFp2bnIxV0xZdzRZR1Ns?= =?utf-8?B?UXppZ3JnQ1ZoY1dSNm1ZWklQMDVvb0V3V3hYTUk2ZUpRWkNaWFY3OTlQV2dY?= =?utf-8?B?QS84R0pWcEgyKzZzbDltRHdnK2IxZHBPdUo1WGtGeEdtR29KdTJnYlhYTXdX?= =?utf-8?B?VXFNSXJRcWJtWEE2dThDVmZCWXNrY1c3N3hkRlFJQlFySFppRE5yYmJKRi9z?= =?utf-8?B?elErbkpOeG1NVXIwaWMzR05zSWJLOE05STlJL3BvZ01reXhyNXV4TkVCMWVu?= =?utf-8?B?aS9lODJUcjRDZlpEVGRCVklTWDNuSjAveUQwbjFzK0JMYVluanQ3K3Rwckxp?= =?utf-8?B?Q3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: cc26b9b1-65de-4dc0-3c91-08dc595fd7c1 X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 13:12:15.7293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dWdf/wsJX8HpqkXn4a6w5sdVKeretFqRN2ZNl32pwR9s8e+6TXNT0QT462g05+DDX2d3dA6svhoMYHjpMG4R0ahphVZDAFnAnRz8hITZQaU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6650 X-OriginatorOrg: intel.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712755452; x=1744291452; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=YzMh00NO2mTRF/V4XNsm5kJ+kg7c3ohhd9Tby9zL4WA=; b=WvLRDi9oVhs2tv9vgrxG3VQ8rW5FwobneWNZifuMv0JOPXpm+zKujFr9 UM4dHwJyHA6vlIFUq6sTa+T1Z8616is8E0McJyempXWhWScU/+Od7Z4Ia Z3Rs52ETXNKbp/oDvkdPFc7jyr97XcwX00mXxrwjAsmCnlYyv4wo16bOM b6QM0WfsLsIwuulLlV4yGc6T/+q5Cgzr9OWd9wNVLIqXoO42i+93PsF97 o35hQbzycfnzXrgQBnwgA+zsNx03TBy7wyp3GGpOQfEf1Q63d4wtsp5S6 LDbukk7j0hITBIeXf67yGYQiRmjpzH23sshxYr2LXJr6tfK1QOtU5REjq w==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WvLRDi9o Subject: Re: [Intel-wired-lan] [PATCH net-next v9 7/9] libeth: add Rx buffer management X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, Alexander Duyck , Ilias Apalodimas , Yunsheng Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Eric Dumazet , intel-wired-lan@lists.osuosl.org, nex.sw.ncis.osdt.itp.upstreaming@intel.com, Jakub Kicinski , Christoph Lameter , Paolo Abeni , "David S. Miller" , Vlastimil Babka Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 4/10/24 15:01, Alexander Lobakin wrote: > From: Przemek Kitszel > Date: Wed, 10 Apr 2024 15:01:32 +0200 > >> On 4/10/24 13:49, Alexander Lobakin wrote: >>> From: Przemek Kitszel >>> Date: Tue, 9 Apr 2024 12:58:33 +0200 >>> >>>> On 4/8/24 11:09, Alexander Lobakin wrote: >>>>> From: Przemek Kitszel >>>>> Date: Fri, 5 Apr 2024 12:32:55 +0200 >>>>> >>>>>> On 4/4/24 17:44, Alexander Lobakin wrote: >>>>>>> Add a couple intuitive helpers to hide Rx buffer implementation >>>>>>> details >>>>> >>>>> [...] >>>>> >>>>>>> +struct libeth_fqe { >>>>>>> +    struct page        *page; >>>>>>> +    u32            offset; >>>>>>> +    u32            truesize; >>>>>>> +} __aligned_largest; >>>>>>> + >>>>>>> +/** >>>>>>> + * struct libeth_fq - structure representing a buffer queue >>>>>>> + * @fp: hotpath part of the structure >>>>>>> + * @pp: &page_pool for buffer management >>>>>>> + * @fqes: array of Rx buffers >>>>>>> + * @truesize: size to allocate per buffer, w/overhead >>>>>>> + * @count: number of descriptors/buffers the queue has >>>>>>> + * @buf_len: HW-writeable length per each buffer >>>>>>> + * @nid: ID of the closest NUMA node with memory >>>>>>> + */ >>>>>>> +struct libeth_fq { >>>>>>> +    struct_group_tagged(libeth_fq_fp, fp, >>>>>>> +        struct page_pool    *pp; >>>>>>> +        struct libeth_fqe    *fqes; >>>>>>> + >>>>>>> +        u32            truesize; >>>>>>> +        u32            count; >>>>>>> +    ); >>>>>>> + >>>>>>> +    /* Cold fields */ >>>>>>> +    u32            buf_len; >>>>>>> +    int            nid; >>>>>>> +}; >>>>>> >>>>>> [...] >>>>>> >>>>>> Could you please unpack the meaning of `fq` and `fqe` acronyms here? >>>>> >>>>> Rx: >>>>> >>>>> RQ -- receive queue, on which you get Rx DMA complete descriptors >>>>> FQ -- fill queue, the one you fill with free buffers >>>>>     FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or >>>>> whatever >>>>> >>>>> Tx: >>>>> >>>>> SQ -- send queue, the one you fill with buffers to transmit >>>>>     SQE -- send queue element, i.e. "iavf_tx_buffer" >>>>> CQ -- completion queue, on which you get Tx DMA complete descriptors >>>>> >>>>> XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk >>>>> >>>>> I know that rxq, txq, bufq, complq is more common since it's been used >>>>> for years, but I like these "new" ones more :> >>>>> >>>> >>>> Thank you, that sounds right. If you happen to sent v10, a bit of code >>>> comment with this info would be useful ;) >>> >>> The current kdoc in front of each struct and function declaration is not >>> enough? :D >>> >>> Thanks, >>> Olek >> >> I've asked my initial question just after reading it thrice, without >> your reply `FQE` was as meaningful as `ABC` > > In the commit: > > + * struct libeth_fqe - structure representing an Rx buffer > > :z > > or you want me to expand FQ, FQE etc. abbrevs in the kdoc? yes, please very much! could be as an additional comment at the top of the file too, with that you could reuse the naming convention later in the file > > Thanks, > Olek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4F8CD1299 for ; Wed, 10 Apr 2024 13:24:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6159B6B0082; Wed, 10 Apr 2024 09:24:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C5EC6B0083; Wed, 10 Apr 2024 09:24:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43EFB6B0088; Wed, 10 Apr 2024 09:24:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 24C646B0082 for ; Wed, 10 Apr 2024 09:24:17 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A865D120652 for ; Wed, 10 Apr 2024 13:24:16 +0000 (UTC) X-FDA: 81993690912.06.CE9C8F7 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf13.hostedemail.com (Postfix) with ESMTP id DD0CC2000D for ; Wed, 10 Apr 2024 13:24:11 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WvLRDi9o; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712755452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V5q89Bwv1WpzyGoyl49lxOJNvOtae/CcEX23U7jiOf4=; b=uMxQR9ehtjSprUCUHML7CZoG1yfzs0ojfMEF2arw0+U3CmeWonEh93LqfIoCGvPiIn9t2m A1hYr3gI6dL5DotsNbAkr5x2gLRuTFkpznDYEMM8U/gP3p9Ivfv+t+wmI7w/Meu2G3pNd5 RB7lNQLb345EftOxSrwPT5X7U4733FE= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WvLRDi9o; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712755452; a=rsa-sha256; cv=fail; b=ViS673zcJ0epsi+5JCD50sVaRsBRDggBkjDerQZJcloMCnhj51eBcLtYzazkQzMh9VEoez xKGeRauhyBJn45NQ9MZYVPElTp1UG0TCSQJZD98o5CHwsUNMOcy2hU56j1KXpZfQojDFyr kUb0Ng6qEf0so7C2e+8cqRZp5dXxHyA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712755452; x=1744291452; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=YzMh00NO2mTRF/V4XNsm5kJ+kg7c3ohhd9Tby9zL4WA=; b=WvLRDi9oVhs2tv9vgrxG3VQ8rW5FwobneWNZifuMv0JOPXpm+zKujFr9 UM4dHwJyHA6vlIFUq6sTa+T1Z8616is8E0McJyempXWhWScU/+Od7Z4Ia Z3Rs52ETXNKbp/oDvkdPFc7jyr97XcwX00mXxrwjAsmCnlYyv4wo16bOM b6QM0WfsLsIwuulLlV4yGc6T/+q5Cgzr9OWd9wNVLIqXoO42i+93PsF97 o35hQbzycfnzXrgQBnwgA+zsNx03TBy7wyp3GGpOQfEf1Q63d4wtsp5S6 LDbukk7j0hITBIeXf67yGYQiRmjpzH23sshxYr2LXJr6tfK1QOtU5REjq w==; X-CSE-ConnectionGUID: LS+7xQ9iQm25+PCaXubzHw== X-CSE-MsgGUID: FK/X8tY6R4CiVn+BYYowIQ== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="11959948" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="11959948" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 06:12:20 -0700 X-CSE-ConnectionGUID: kTlCt1yRSwafBjg31lSS3A== X-CSE-MsgGUID: aZiHEEC9QQyPu3osHm9HJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="25028354" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Apr 2024 06:12:20 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 06:12:18 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Apr 2024 06:12:18 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 06:12:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MVYVBhLysoXV3z8QLTjqFz68LpxtTZpGGd4mok1GODsum5orpvhYR3RUxFSy0IOjqVJ/zrqxH8iDbkj+L9ZdbTLiJEbqEOTpnb2Qch0z1gYU6S8FcSCl3FCHisAU9EnzuxgbchTgqZQ1XQmYSS/TdTEwSR83xYPw9TAi+xuBuNBSpiVy5tQmAo1bW4kHw8pQqsPqf3RGF5J+yGzE1o7+NnoLeaWyqqSiCOvojhgj+3tS1hv8Tij1WCcHZ8z3Gt55YUUTM/xMKliXyDajJt5UTVncmlWizaOqeTD1JFtyWfr0g+obyRVOiVqEtlkRKdT4j23Eq75MUJjbhCapeIB2Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V5q89Bwv1WpzyGoyl49lxOJNvOtae/CcEX23U7jiOf4=; b=Xo1C96pGp5W7mDp7BNfRk9lapJfDWtr6UQG6XwHtjyuhsIE5jDx69ABwRexDXTwPIp2GC3R7D2xlr88rLxcIdKfh6T8R35nCz3pWYbFpzii6tZTrkSzeuPRl9BngfarcruoUIRmZZ9Os5f8XutgEBmmW/qPWaM5dvh7MPFNJz9jr4kvnQtSC0HT7P/5jpb0/NhGUuk/I8tDmy0yVjI+MArpwCE3C6Ab5UfOFDyez6RMJEmjPGEpwIcyAZ/FrbEDrBuzpPs9M1nKRSgY7O0yVw6s0L3HcazJhizz5QvaubNiu4B5EXYlLwMSpx6RpBtxw8/QP7F0nUz5wsQkesTQ1/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) by PH7PR11MB6650.namprd11.prod.outlook.com (2603:10b6:510:1a8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Wed, 10 Apr 2024 13:12:15 +0000 Received: from MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::5c8:d560:c544:d9cf]) by MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::5c8:d560:c544:d9cf%5]) with mapi id 15.20.7430.045; Wed, 10 Apr 2024 13:12:15 +0000 Message-ID: Date: Wed, 10 Apr 2024 15:12:10 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management Content-Language: en-US To: Alexander Lobakin CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Duyck , Yunsheng Lin , Jesper Dangaard Brouer , "Ilias Apalodimas" , Christoph Lameter , Vlastimil Babka , Andrew Morton , , , , , References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com> <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com> <36a067fa-75c0-4e7d-b704-229deea2d440@intel.com> <61a952aa-1b3e-43c7-9f35-ab53e492305a@intel.com> From: Przemek Kitszel In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU6P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::29) To MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8102:EE_|PH7PR11MB6650:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5B/sVbvTU/IeCpgUt1tSVrv2HJVf1ZXaUzO3kuAZ5l9l8fOU88O4VSPMa9lI/laTHKP4v8JbHozS7hOOobgjYiCp8fw0qGyLr1XmxkKx4x1s/Hv682iIZhO0fDFAJ40Gpuhx7HL8P62HCZ0h5TzgYiyjivhuAMrnvR+Kk479VyJZJ015J4XKoPERWoIzvsg7BAlN182tGBxGDF9dy1uysghv0C9OWkF7wwxBqXlyTRMBVlPBTmttBJFFtpoMMy6MV5Z/SoDE0OgywBq94sm34VwvVuVIBHSxvgRwUQg4VKCTz9rZQh1CgwPlqVcS9tdWTAa1zR4UVvHdkY84KrumTEaeZjFcd3r6JwStmminnIrViXi+vnCmdyaPQGXJi3NmJYo4uGIypzgbRBbgy6pDKEgT8ABit7YE7c+0I2GI4qwZYRnVve65PTp0B6ymjAtvswYIqJBn1qWaVEFHk0/SAVFBV0m58HEGjlz4k7v50kXIocgvXgtCVDaAlmdt098oAzVWByL5Oe4vZPUC7GsEraSV0nKPmz0+vVbak4wP94q5OwQNCpFbqAEgsSevtThsA926AFZa7fjT3sTh8tl8SIKPm103k4EMX+OK2VJ5swwBmcCOu0CXugIyQB5uOZoaQdt53EVYab6wTa6+gLrhriWlXsHsZfxWXrcwHLXDck8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8102.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(7416005)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1huRUZ6NjhOT2JuZGYzMmI2Zjh6TVEydXdkZm8xY1pEekh0dTcvZTFpYXky?= =?utf-8?B?cWp5ZUJiN2Vwc0c5MzhidUZIdTJZVFBQV0JNQkNqclFyZHd1aDI1clVseUtz?= =?utf-8?B?VmhISDJzTzgxWWxyZFVueHo3bFQrSUhIaDBtUmR5RDBndEFrWjlxSUM1blU5?= =?utf-8?B?OHpSRTRScGxpdVNyY25BQjk4bUUrOFVLbnU5RFk4ZHYzM25OTFhxczNYS1or?= =?utf-8?B?Z0V1MVU1MUNQc0pkQWxlbVBSYmthM1NoZnI3QkdWOWFZOTlLUHNhanNpcDd2?= =?utf-8?B?T0N6SklxQjI2c2tNRUFXd2puVVZLelcvUU1WZUhZM3RhNnhCaCttVHdtaWNZ?= =?utf-8?B?dzczeUFQa2ErUEdEU09UUXJzWFJ4aXFWZ3ZoY0xjWHE4c2ZTdVB6ZzJVNjNt?= =?utf-8?B?N3dMc2RheUtWMlllWTdtcGtoQk9tOEVsTnBiWVZEM3pURlJIZWNXTVJORW0z?= =?utf-8?B?cGdIV1FmeXZ1MUNBd0FCNW00T3V0Q0N2cWFKVHQ3TDM2K2c0em40Z1N1Z2c5?= =?utf-8?B?QkRhR3hhNDY5TWxLTUpFT0UrQmFxVG5pbnhkWVhnT0RYZ0VQWHp6Z1M4Tks2?= =?utf-8?B?WVFBeEJHWi9pb0p5MUdZK3N4SXh6Q2dQQndJUUZIbWR2K2xuZFBzZTFHYllU?= =?utf-8?B?NXgyVFR0b2hVWEF1Y3UwV0gzM1MzTzJTZENBcEdaS1ZOcExCSGJOc0hHVVhi?= =?utf-8?B?YjgzTHRoNHB3dEltSjFWQ1lkSGkrQVF1dmVYRWlIU3NNMUdjckNVQjBYTTR6?= =?utf-8?B?R1BicFUxSDdOb2FQL3BEWmVJM1VmMVBxVThMaUFKUHRCM29mVUU5NkRGR1gv?= =?utf-8?B?TDRzemlxeEJNU0NEVGJLanVoVmo3QWIvZWJDSERhbWZNOUdMOHRvamRIU1pH?= =?utf-8?B?VVVtT09IM3RBWmRUNmduL3JHVHBES1RyTHZUdjhaZDdSbEthZE9hYXlLcHdm?= =?utf-8?B?TmZYWS9jM0VkN2kzeFBsZGlkQnFTY2VtWkFUbVdzZTRteFlIZkFTMEhCQlU3?= =?utf-8?B?Smw4YjA0M2xpQVYybjQ3SkVlZGRWNXpzR1lDMkFFTkIveExHNXdCaG5qc2Mz?= =?utf-8?B?aE12cUNXVVNvaUVDaGtSbVFmdE5ROWFNZTkrMkFjTW0rcmdNZmZaY0xlb3hz?= =?utf-8?B?TGl6UFlXd2h3dmFEUHNRa2tHT1JaNkhFdDUxZ3RtZkdtalMxS25sT0F4NlB2?= =?utf-8?B?ajZacXZOdzJMd1ZPdWR3cExYYTJlL3FtbzBIVHNQcnhPcmR2ellWRGRmdEc5?= =?utf-8?B?U2lqTXo3a1lhemFKRXFpQXBSaWdnTTFuZlFnSEUzemFpb21MN0IyUDd4cGNq?= =?utf-8?B?bTdIalNsTTB6SnNycW9yb1dRNmRLSVdsemdUNXBEcytyRUhFby9TUHB1d1Vr?= =?utf-8?B?VHJXVHNBQUdTYkREOXRmVytySmJmbXlQYkhrbFZOR2RRVGdjbm9yQTg3MnpU?= =?utf-8?B?cy9DNS9iYmlCcWp4eTRwdVZYdGlZOTBNUml4L2dwWEF3aXZNb0VKZnAwVjdH?= =?utf-8?B?cW5DRlY4eUthNDhFTVFDNVUzdTdwN1BmUjlyOVUwL3M3SnJLVGR6a3M2eXU1?= =?utf-8?B?bXI0QU5nWENEeXpiSyttQ0dod3ZrMzBZbzhZQXFnQ0VWYmFUYW5XaC85WEdk?= =?utf-8?B?ZGhFdlJrLzNkQWt5ZXNhcUlwTDNSbVpoK0VLd3JLaWhvWEthNmR2SmlrMFFK?= =?utf-8?B?WmkvU2JQK3hNWmJLbWw1dWlocmtLcklLTHhzcENBSzBQVlBVK2g1SVlYRjU5?= =?utf-8?B?YVlhTTdDYS9ZZWk3K3EzeTUrK2hVTWsxNzA3SnVSemtZbERYRHRqc0xIM3pM?= =?utf-8?B?YlhKSE52WFUvVm9FdXlYdGFOMldwRys1ckd0TVdtRFp2bnIxV0xZdzRZR1Ns?= =?utf-8?B?UXppZ3JnQ1ZoY1dSNm1ZWklQMDVvb0V3V3hYTUk2ZUpRWkNaWFY3OTlQV2dY?= =?utf-8?B?QS84R0pWcEgyKzZzbDltRHdnK2IxZHBPdUo1WGtGeEdtR29KdTJnYlhYTXdX?= =?utf-8?B?VXFNSXJRcWJtWEE2dThDVmZCWXNrY1c3N3hkRlFJQlFySFppRE5yYmJKRi9z?= =?utf-8?B?elErbkpOeG1NVXIwaWMzR05zSWJLOE05STlJL3BvZ01reXhyNXV4TkVCMWVu?= =?utf-8?B?aS9lODJUcjRDZlpEVGRCVklTWDNuSjAveUQwbjFzK0JMYVluanQ3K3Rwckxp?= =?utf-8?B?Q3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: cc26b9b1-65de-4dc0-3c91-08dc595fd7c1 X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 13:12:15.7293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dWdf/wsJX8HpqkXn4a6w5sdVKeretFqRN2ZNl32pwR9s8e+6TXNT0QT462g05+DDX2d3dA6svhoMYHjpMG4R0ahphVZDAFnAnRz8hITZQaU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6650 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: DD0CC2000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tu68sdcmbc9q7ndkqmuqjix7yknpt7p8 X-HE-Tag: 1712755451-490846 X-HE-Meta: U2FsdGVkX1/4FWkQMyPeLgwRvrgUPUT3xMPpAJn6fjZezo7odnPD0GlXM2gDdbwcyUpVNar/f5xaLygjmjXDGQibbE243M5HR7f2Qg5Ma+83/J3rKm4rf7XZeIraeps6R3eVSBLgcYpotFF5JZGQcSBlpecJ1ZJ+BHQDTORuKAD7g22TmghIbyg0c6izaLUkQn4fPEPnxQfK0BlwRtZDYzOP9+oagJGIMDGu8QSwlGhYxwySCGZ+hfFZg6KdiFCcZGA8Ot5ZDBcOZKDpFAht57ak9BcLZ0xNXBR0zKdT4Xp5j/QJmYywq1bP68kwr9k1w6byHbg0ixRAU0ehUPghRzmEV7P6tIOAS1mPggzEX7Ql0gPELelowcUXKtYpKy7U0+m9RtR+W9FOn+vulS25fGBQmFlK/+EuEW5kQFiKxp2yyoPDfFKKZ/FGNpC8QUXtj1kD5f8a1YQc83uIyK3XZphincVQGCy9cWYfo1QSz/EJeZH1TlPHi/WZD0XBR4GcBBeILv+WpUcRrTfg8Ex3XpKyytY4Vl5rVImaftXtB4Rx2JisVVRSCgyobG8gYj5kulUcY52Jwc7sw3Y2AyNhlMLH+wYVrOGkMFghsAC8yCnJbnOx2DbVwfEkicGf3urCBSrrJb8MKuKMEguw9ZPv2DR1GEHsYwK56n3nI/2AK6zjbjv7nLn8rfZeDp0UAzb0kK7RYjzaT4SbiuOi+knwMX5Ye7bpVUMrC2oaMHM84aUPWU+MmYv0EE35NCIJ6MJayu7ulJrEk6tv5MjCr1QcCEPRGRZ5oaV+POIgOwwPPBdq7mWdLCRTeAgsKY0Y8xmaQiRCFkJcSNzIMpRCs5oGXjIDpmp7IVTxDuO7aCTtkm4SvCcX5D6RWWHN5OTiEaxT1GXXVwEd/V62y1Z7upQhVcs+TOktoVRo+m96FpcXZzKJCvlsG/jUZXZc85Mx+hBlk1LvyAwuBc7QPPrhmvJ J9yXdm2p MsHIm8VokqR5UysVGgHCqhSV1QT917RQHqbyplJ6AAI3VWdK6W93AGL9wqAcqObALTjeB34uxvaKoNxupfvV756/8AQN3wvd4HEvKFG1I/YwPrfzog6PxVQ7BSv9s/LWKe2b9sU4B9Zzt4gfGL4gV2NSyGkPfWaHBtZvIPdIm7ud3/u/EXyLc56zm+d81q8bsS9+7rO5BrDDe7Nje6IE98DGmKlDkYyu7mQjNeJH1yYHVFZzSVNyr7zoZykmg6zNnXH6x3lEeAGMY21QpZFSH1Pa7rf7so5Et+t4JZHDZLwt2nGBJTAwahAGRQpDbjUTdJaHMhFRYi0aitDUVOUfi4LrK6QGQQqiRUYqhzBHYiTpBq/KPiOGkvIa5Z53bEkUgMC1Sc3+Mi5mko65sMFixMt1jcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/10/24 15:01, Alexander Lobakin wrote: > From: Przemek Kitszel > Date: Wed, 10 Apr 2024 15:01:32 +0200 > >> On 4/10/24 13:49, Alexander Lobakin wrote: >>> From: Przemek Kitszel >>> Date: Tue, 9 Apr 2024 12:58:33 +0200 >>> >>>> On 4/8/24 11:09, Alexander Lobakin wrote: >>>>> From: Przemek Kitszel >>>>> Date: Fri, 5 Apr 2024 12:32:55 +0200 >>>>> >>>>>> On 4/4/24 17:44, Alexander Lobakin wrote: >>>>>>> Add a couple intuitive helpers to hide Rx buffer implementation >>>>>>> details >>>>> >>>>> [...] >>>>> >>>>>>> +struct libeth_fqe { >>>>>>> +    struct page        *page; >>>>>>> +    u32            offset; >>>>>>> +    u32            truesize; >>>>>>> +} __aligned_largest; >>>>>>> + >>>>>>> +/** >>>>>>> + * struct libeth_fq - structure representing a buffer queue >>>>>>> + * @fp: hotpath part of the structure >>>>>>> + * @pp: &page_pool for buffer management >>>>>>> + * @fqes: array of Rx buffers >>>>>>> + * @truesize: size to allocate per buffer, w/overhead >>>>>>> + * @count: number of descriptors/buffers the queue has >>>>>>> + * @buf_len: HW-writeable length per each buffer >>>>>>> + * @nid: ID of the closest NUMA node with memory >>>>>>> + */ >>>>>>> +struct libeth_fq { >>>>>>> +    struct_group_tagged(libeth_fq_fp, fp, >>>>>>> +        struct page_pool    *pp; >>>>>>> +        struct libeth_fqe    *fqes; >>>>>>> + >>>>>>> +        u32            truesize; >>>>>>> +        u32            count; >>>>>>> +    ); >>>>>>> + >>>>>>> +    /* Cold fields */ >>>>>>> +    u32            buf_len; >>>>>>> +    int            nid; >>>>>>> +}; >>>>>> >>>>>> [...] >>>>>> >>>>>> Could you please unpack the meaning of `fq` and `fqe` acronyms here? >>>>> >>>>> Rx: >>>>> >>>>> RQ -- receive queue, on which you get Rx DMA complete descriptors >>>>> FQ -- fill queue, the one you fill with free buffers >>>>>     FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or >>>>> whatever >>>>> >>>>> Tx: >>>>> >>>>> SQ -- send queue, the one you fill with buffers to transmit >>>>>     SQE -- send queue element, i.e. "iavf_tx_buffer" >>>>> CQ -- completion queue, on which you get Tx DMA complete descriptors >>>>> >>>>> XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk >>>>> >>>>> I know that rxq, txq, bufq, complq is more common since it's been used >>>>> for years, but I like these "new" ones more :> >>>>> >>>> >>>> Thank you, that sounds right. If you happen to sent v10, a bit of code >>>> comment with this info would be useful ;) >>> >>> The current kdoc in front of each struct and function declaration is not >>> enough? :D >>> >>> Thanks, >>> Olek >> >> I've asked my initial question just after reading it thrice, without >> your reply `FQE` was as meaningful as `ABC` > > In the commit: > > + * struct libeth_fqe - structure representing an Rx buffer > > :z > > or you want me to expand FQ, FQE etc. abbrevs in the kdoc? yes, please very much! could be as an additional comment at the top of the file too, with that you could reuse the naming convention later in the file > > Thanks, > Olek