From: "Orzel, Michal" <michal.orzel@amd.com>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Nicola Vetrini <nicola.vetrini@bugseng.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH 06/14] Arm/alternative: hide casting away of const
Date: Wed, 2 Sep 2026 13:47:41 +0200 [thread overview]
Message-ID: <f4b94f5a-d78f-4cad-9165-a92bc8111da5@amd.com> (raw)
In-Reply-To: <6b3a3849-304f-423b-a3c3-a614d83858c0@suse.com>
On 02-Sep-26 08:32, Jan Beulich wrote:
> We want to patch the original call site, which memory-wise is unrelated
> to the struct alt_instr * that we start from.
>
> No functional change intended.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/arm/alternative.c
> +++ b/xen/arch/arm/alternative.c
> @@ -134,7 +134,7 @@ static int __apply_alternatives(const st
> BUG_ON(alt->repl_len != alt->orig_len);
>
> origptr = ALT_ORIG_PTR(alt);
> - updptr = (void *)origptr + update_offset;
> + updptr = (void *)(long)origptr + update_offset;
NIT: Why long and not unsigned long like other places in this file?
Reviewed-by: Michal Orzel <michal.orzel@amd.com>
~Michal
next prev parent reply other threads:[~2026-09-02 11:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 6:28 [PATCH 00/14] address half the remaining Misra rule 11.8 violations Jan Beulich
2026-09-02 6:30 ` [PATCH 01/14] lib: obey to Misra rule 11.8 where possible Jan Beulich
2026-09-02 6:30 ` [PATCH 02/14] x86/bitops: don't cast away volatile-ness Jan Beulich
2026-09-02 11:29 ` Andrew Cooper
2026-09-02 6:31 ` [PATCH 03/14] x86: have cmpxchg16b() obey to Misra rule 11.8 Jan Beulich
2026-09-02 6:31 ` [PATCH 04/14] x86/boot: don't cast away const-ness Jan Beulich
2026-09-07 8:02 ` Roger Pau Monné
2026-09-02 6:32 ` [PATCH 05/14] x86/altcall: hide casting away of const Jan Beulich
2026-09-07 7:54 ` Roger Pau Monné
2026-09-02 6:32 ` [PATCH 06/14] Arm/alternative: " Jan Beulich
2026-09-02 11:47 ` Orzel, Michal [this message]
2026-09-02 12:35 ` Jan Beulich
2026-09-02 6:33 ` [PATCH 07/14] Arm64/GICv3: have gicv3_its_find_quirk() not cast away const-ness Jan Beulich
2026-09-02 11:22 ` Orzel, Michal
2026-09-02 6:33 ` [PATCH 08/14] Arm/guestcopy: deviate copy_guest() uses just like their x86 counterparts Jan Beulich
2026-09-07 6:37 ` Orzel, Michal
2026-09-02 6:34 ` [PATCH 09/14] ACPI: address a Misra rule 11.8 violation in Arm code Jan Beulich
2026-09-02 6:34 ` [PATCH 10/14] ELF/notes: use pointer-to-const by default in ELFNOTE_...() Jan Beulich
2026-09-02 6:35 ` [PATCH 11/14] crypto/vmac: don't cast away const-ness in aes_key_setup() Jan Beulich
2026-09-02 6:35 ` [PATCH 12/14] gnttab: don't cast away constness Jan Beulich
2026-09-02 6:36 ` [PATCH 13/14] passthrough/PCI: rework (s,b,d,f) init of struct pci_dev Jan Beulich
2026-09-02 12:44 ` Roger Pau Monné
2026-09-02 12:53 ` Jan Beulich
2026-09-02 15:07 ` Roger Pau Monné
2026-09-03 6:05 ` Jan Beulich
2026-09-02 6:37 ` [PATCH 14/14] xhci-dbc: don't cast away const-ness in xhci_find_dbc() Jan Beulich
2026-09-02 9:56 ` Marek Marczykowski-Górecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b94f5a-d78f-4cad-9165-a92bc8111da5@amd.com \
--to=michal.orzel@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=nicola.vetrini@bugseng.com \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.