From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 613A6C53219 for ; Tue, 28 Jul 2026 09:00:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9737310E563; Tue, 28 Jul 2026 09:00:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ffNueG0u"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id C423610E563; Tue, 28 Jul 2026 09:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1785229201; x=1816765201; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=eBqEMX5lIrTpK8C1DMTEZ22zMyuQi9s/I8Y9T8TrggQ=; b=ffNueG0uk1d/8S6IjksgT547cYnjho9H9CxnMijzzmj2ssKI1qIzfc8w Zm1kyjGUq8+Xw1k0/hZH91m0ucJPsNqsiFOtI/AsfQfplYu8KNLgDaAxe pyYlfDb5Mz6C3N39sJttjGojAwgPEBT1aHdK6e7Rg/5P0cK6ne8ylNu/i bj15+CVb5w2JzYn+LR/jBZ6TxeHhQt7jp+Fw7InTuVw+cvDz7yQ7PKB7g FkxO9MES9pLJpCUTulfRVqS1HXq9WlOIE8TpbVz0lyuSPp1krDERaGqR2 hS2FI4V57HP38fasNUZYMHZSXkyRhsWv1I34BnhB4Vg5jQF/Eo1NIze9D A==; X-CSE-ConnectionGUID: qDD2Csk6SDSmVNno9avJHA== X-CSE-MsgGUID: 2gXauqMQTPmhDm48c3CxJg== X-IronPort-AV: E=McAfee;i="6800,10657,11858"; a="84786102" X-IronPort-AV: E=Sophos;i="6.25,190,1779174000"; d="scan'208";a="84786102" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2026 02:00:00 -0700 X-CSE-ConnectionGUID: hdD8iPisSmO1tZreK9ENlA== X-CSE-MsgGUID: uhqj4BpzQDCrYGFgjUFc4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,190,1779174000"; d="scan'208";a="263145117" Received: from ncintean-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.76]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2026 01:59:56 -0700 From: Jani Nikula To: Mitul Golani , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org, uma.shankar@intel.com, shawn.c.lee@intel.com, kai.vehmanen@intel.com, ankit.k.nautiyal@intel.com, chaitanya.kumar.borah@intel.com, suraj.kandpal@intel.com Subject: Re: [PATCH v3] drm/i915/audio: treat UHBR SST like MST for cpu_transcoder signalling In-Reply-To: <20260708113558.1863316-1-mitulkumar.ajitkumar.golani@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260708113558.1863316-1-mitulkumar.ajitkumar.golani@intel.com> Date: Tue, 28 Jul 2026 11:59:53 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 08 Jul 2026, Mitul Golani wrote: > Both DP MST and UHBR SST require the audio component to use a real > cpu_transcoder (>= 0) value to identify the audio stream on a port. > For DP MST this was already handled; for UHBR SST it was not, causing > pin_eld_notify() to signal cpu_transcoder = -1 (the legacy SST sentinel) > and find_audio_state() to skip the per-transcoder entry for the UHBR > stream. > > After suspend/resume or replug, the ELD lookup fails and audio goes > silent. Fix by detecting UHBR SST alongside DP MST when deciding > whether a real cpu_transcoder value must be used for audio state > addressing, in both the pin_eld_notify() signalling and the > find_audio_state() lookup paths. [snip] Going through some merged patches while writing the pull request... > > - /* Non-MST */ > + /* Legacy SST. */ Please be careful about tossing around "legacy". It's the bog standard DP 1.4 non-UHBR SST that's used absolutely everywere that you're talking about here. It's not "legacy". BR, Jani. -- Jani Nikula, Intel