From: Jan Beulich <jbeulich@suse.com>
To: Penny Zheng <Penny.Zheng@amd.com>
Cc: ray.huang@amd.com,
"Stefano Stabellini" <stefano.stabellini@amd.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Sergiy Kibrik" <Sergiy_Kibrik@epam.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 02/20] xen: introduce CONFIG_SYSCTL
Date: Wed, 30 Apr 2025 17:20:48 +0200 [thread overview]
Message-ID: <f4e6a0ed-c869-4ecc-a6bf-7ef445ac2db5@suse.com> (raw)
In-Reply-To: <20250421073723.3863060-3-Penny.Zheng@amd.com>
On 21.04.2025 09:37, Penny Zheng wrote:
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -581,4 +581,15 @@ config BUDDY_ALLOCATOR_SIZE
> Amount of memory reserved for the buddy allocator to serve Xen heap,
> working alongside the colored one.
>
> +menu "Supported hypercall interfaces"
> + visible if EXPERT
> +
> +config SYSCTL
> + bool "Enable sysctl hypercall"
> + default y
Oh, and - just to re-iterate what I said earlier in the context of another patch:
Imo you would better introduce the option without prompt (simply "defbool y"),
and make it user selectable only in the final patch. That'll eliminate the need
for transient "#ifdef CONFIG_SYSCTL", i.e. reduce overall code churn.
Jan
next prev parent reply other threads:[~2025-04-30 15:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 7:37 [PATCH v3 00/20] xen: introduce CONFIG_SYSCTL Penny Zheng
2025-04-21 7:37 ` [PATCH v3 01/20] xen/x86: remove "depends on !PV_SHIM_EXCLUSIVE" Penny Zheng
2025-04-30 15:16 ` Jan Beulich
2025-05-21 3:32 ` Penny, Zheng
2025-04-21 7:37 ` [PATCH v3 02/20] xen: introduce CONFIG_SYSCTL Penny Zheng
2025-04-21 20:54 ` Stefano Stabellini
2025-04-30 15:05 ` Jan Beulich
2025-04-30 15:20 ` Jan Beulich [this message]
2025-04-30 15:48 ` Jan Beulich
2025-04-21 7:37 ` [PATCH v3 03/20] xen/xsm: wrap around xsm_sysctl with CONFIG_SYSCTL Penny Zheng
2025-04-21 7:37 ` [PATCH v3 04/20] xen/sysctl: wrap around XEN_SYSCTL_readconsole Penny Zheng
2025-04-21 7:37 ` [PATCH v3 05/20] xen/sysctl: make CONFIG_TRACEBUFFER depend on CONFIG_SYSCTL Penny Zheng
2025-04-21 7:37 ` [PATCH v3 06/20] xen/sysctl: wrap around XEN_SYSCTL_sched_id Penny Zheng
2025-04-21 7:37 ` [PATCH v3 07/20] xen/sysctl: wrap around XEN_SYSCTL_perfc_op Penny Zheng
2025-04-21 7:37 ` [PATCH v3 08/20] xen/sysctl: wrap around XEN_SYSCTL_lockprof_op Penny Zheng
2025-04-21 7:37 ` [PATCH v3 09/20] xen/pmstat: consolidate code into pmstat.c Penny Zheng
2025-04-30 15:24 ` Jan Beulich
2025-04-21 7:37 ` [PATCH v3 10/20] xen/pmstat: introduce CONFIG_PM_OP Penny Zheng
2025-04-21 21:09 ` Stefano Stabellini
2025-04-30 15:32 ` Jan Beulich
2025-04-21 7:37 ` [PATCH v3 11/20] xen/sysctl: introduce CONFIG_PM_STATS Penny Zheng
2025-04-21 21:12 ` Stefano Stabellini
2025-04-30 15:35 ` Jan Beulich
2025-04-21 7:37 ` [PATCH v3 12/20] xen/sysctl: wrap around XEN_SYSCTL_page_offline_op Penny Zheng
2025-04-21 7:37 ` [PATCH v3 13/20] xen/sysctl: wrap around XEN_SYSCTL_cpupool_op Penny Zheng
2025-04-21 7:37 ` [PATCH v3 14/20] xen/sysctl: wrap around XEN_SYSCTL_scheduler_op Penny Zheng
2025-04-21 7:37 ` [PATCH v3 15/20] xen: make avail_domheap_pages() inlined into get_outstanding_claims() Penny Zheng
2025-04-21 7:37 ` [PATCH v3 16/20] xen/sysctl: wrap around XEN_SYSCTL_physinfo Penny Zheng
2025-04-21 7:37 ` [PATCH v3 17/20] xen/sysctl: make CONFIG_COVERAGE depend on CONFIG_SYSCTL Penny Zheng
2025-04-21 7:37 ` [PATCH v3 18/20] xen/sysctl: make CONFIG_LIVEPATCH " Penny Zheng
2025-04-21 7:37 ` [PATCH v3 19/20] xen/sysctl: wrap around arch-specific arch_do_sysctl Penny Zheng
2025-04-21 21:19 ` Stefano Stabellini
2025-04-30 15:45 ` Jan Beulich
2025-04-21 7:37 ` [PATCH v3 20/20] xen/sysctl: wrap around sysctl hypercall Penny Zheng
2025-04-21 21:21 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4e6a0ed-c869-4ecc-a6bf-7ef445ac2db5@suse.com \
--to=jbeulich@suse.com \
--cc=Penny.Zheng@amd.com \
--cc=Sergiy_Kibrik@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=ray.huang@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.