From: Marek Vasut <marek.vasut@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-gpio@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Jan Kotas <jank@cadence.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH] gpio: of: Apply regulator-gpio quirk only to enable-gpios
Date: Sat, 16 Feb 2019 16:02:03 +0100 [thread overview]
Message-ID: <f4ee262c-16d2-cbb2-7717-2ca511b87361@gmail.com> (raw)
In-Reply-To: <20190216144742.rvitloqjzf7towgy@ninjato>
On 2/16/19 3:47 PM, Wolfram Sang wrote:
> On Sat, Feb 16, 2019 at 03:06:55PM +0100, Marek Vasut wrote:
>> On 2/16/19 3:04 PM, Wolfram Sang wrote:
>>>
>>>> + !strcmp(propname, "enable-gpio") &&
>>>
>>> I haven't looked at the actual issue, but one minor nit I usually have:
>>>
>>> I think 'strcmp() == 0' is easier to read since the above is too easy to
>>> be mistaken as "if not equal". I have just been bitten again by this
>>> after a long day, although I should know better... :/
>>
>> Note that I just followed the coding style in the rest of the function,
>> if we want to update the coding style the gpiolib, that's for separate
>> patch.
>
> Fair enough.
>
Could be something Gustavo can look at, since he seems to be doing a lot
of automated cleanups ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-02-16 15:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 13:46 [PATCH] gpio: of: Apply regulator-gpio quirk only to enable-gpios marek.vasut
2019-02-16 14:04 ` Wolfram Sang
2019-02-16 14:06 ` Marek Vasut
2019-02-16 14:47 ` Wolfram Sang
2019-02-16 15:02 ` Marek Vasut [this message]
2019-02-17 21:21 ` Linus Walleij
2019-02-17 21:58 ` Marek Vasut
2019-02-19 15:18 ` Thierry Reding
2019-02-19 15:25 ` Marek Vasut
2019-02-19 16:08 ` Thierry Reding
2019-02-19 16:30 ` Marek Vasut
2019-02-19 17:05 ` Thierry Reding
2019-02-19 17:22 ` Marek Vasut
2019-02-20 9:01 ` Linus Walleij
2019-02-20 10:19 ` Thierry Reding
2019-02-20 9:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ee262c-16d2-cbb2-7717-2ca511b87361@gmail.com \
--to=marek.vasut@gmail.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=gustavo@embeddedor.com \
--cc=jank@cadence.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.